Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Andrei Alecu
    @andreialecu
    @ericfong if you can test on phonegap, please do
    http://stackoverflow.com/questions/21297169/cors-and-phonegap-apps according to the top answer here it should be fine
    Eric Fong
    @ericfong
    Question: "room" in socket.io seems can emit message to multiple clients. Have we consider that ?
    Andrei Alecu
    @andreialecu
    it would add more complexity than the current solution
    you still have to authenticate users joining rooms somehow
    I looked into it in the past and wasn't feasible
    at least not to replace what we have, but maybe to enhance it further down the road
    emitToUsers() was pretty much unusable and broken in real world use before this PR
    Eric Fong
    @ericfong
    npm test passed. need more time to digest the code.
    Andrei Alecu
    @andreialecu
    @ericfong see private
    Andrei Alecu
    @andreialecu
    deployd/deployd#573 I will merge this if there are no objections, tested in modern browsers to be ok, and other browsers should respect min-height if they can't understand that height
    paging @ericfong @NicolasRitouet
    Nicolas Ritouet
    @NicolasRitouet
    I'm on with that
    Nicolas Ritouet
    @NicolasRitouet
    @andreialecu I rebased your css PR
    I’ll rebase the 572 now
    oh, @ericfong already did, perfect !
    Nicolas Ritouet
    @NicolasRitouet
    let me know when you think we should release
    Andrei Alecu
    @andreialecu
    deployd/deployd#574
    need a review/merge here, not a big change
    just a small bugfix + added some code comments
    Nicolas Ritouet
    @NicolasRitouet
    if I have time, I’ll do it this evening
    Andrei Alecu
    @andreialecu
    deployd/deployd#575 also this one
    Andrei Alecu
    @andreialecu
    hey guys
    Rares Golea
    @rgolea
    hey guys! I would like to start helping with maintaining deployd but I need somewhere to start. any ideas?
    I mean, how do you guys work? (git, git flow, PR to master…) where can I find docs on the architecture of deployd? (folders, injection, ctx, etc…) and what would you have me do? I would love to start helping with the docs but for that I need to know where are the docs right now and how to edit them, etc...
    Rares Golea
    @rgolea
    sorry… my bad… just found out where are the docs...
    I do need the rest of the info
    Andrei Alecu
    @andreialecu
    :point_up: May 25 2015 4:06 PM @NicolasRitouet @ericfong
    Nicolas Ritouet
    @NicolasRitouet
    @andreialecu I'll take care of this this evening
    Andrei Alecu
    @andreialecu
    deployd/deployd#576 this one is more pressing for me, and real simple
    Nicolas Ritouet
    @NicolasRitouet
    ok
    Andrei Alecu
    @andreialecu
    so I can keep using deployd/deployd instead of my own fork
    Nicolas Ritouet
    @NicolasRitouet
    I'm doing it right now
    @rgolea you can found some contribution guideline here: https://github.com/deployd/deployd/blob/master/CONTRIBUTING.md
    if they are not clear, let me know, we can improve it
    Rares Golea
    @rgolea
    thanks!
    I have to warn you I’m not a skilled developer… but I’ll do my best. Thank you for the chance
    Nicolas Ritouet
    @NicolasRitouet
    it’s ok, you can contribute on lot’s of different stuff
    Rares Golea
    @rgolea
    @NicolasRitouet thank you
    Nicolas Ritouet
    @NicolasRitouet
    it can be documentation, design (we’d like to redesign the homepage), easy bugs, etc..
    Rares Golea
    @rgolea
    the homepage?
    Andrei Alecu
    @andreialecu
    yup, documentation is severely lacking
    Rares Golea
    @rgolea
    you mean the dashboard?
    Andrei Alecu
    @andreialecu
    I think he means deployd.com
    Rares Golea
    @rgolea
    I will try my best on the docs but I will be posting a lot of questions
    I think I can manage that too
    would you like something more foundation, more bootstrap or more material-design?