Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Nicolas Ritouet
    @NicolasRitouet
    oh, @ericfong already did, perfect !
    Nicolas Ritouet
    @NicolasRitouet
    let me know when you think we should release
    Andrei Alecu
    @andreialecu
    deployd/deployd#574
    need a review/merge here, not a big change
    just a small bugfix + added some code comments
    Nicolas Ritouet
    @NicolasRitouet
    if I have time, I’ll do it this evening
    Andrei Alecu
    @andreialecu
    deployd/deployd#575 also this one
    Andrei Alecu
    @andreialecu
    hey guys
    Rares Golea
    @rgolea
    hey guys! I would like to start helping with maintaining deployd but I need somewhere to start. any ideas?
    I mean, how do you guys work? (git, git flow, PR to master…) where can I find docs on the architecture of deployd? (folders, injection, ctx, etc…) and what would you have me do? I would love to start helping with the docs but for that I need to know where are the docs right now and how to edit them, etc...
    Rares Golea
    @rgolea
    sorry… my bad… just found out where are the docs...
    I do need the rest of the info
    Andrei Alecu
    @andreialecu
    :point_up: May 25 2015 4:06 PM @NicolasRitouet @ericfong
    Nicolas Ritouet
    @NicolasRitouet
    @andreialecu I'll take care of this this evening
    Andrei Alecu
    @andreialecu
    deployd/deployd#576 this one is more pressing for me, and real simple
    Nicolas Ritouet
    @NicolasRitouet
    ok
    Andrei Alecu
    @andreialecu
    so I can keep using deployd/deployd instead of my own fork
    Nicolas Ritouet
    @NicolasRitouet
    I'm doing it right now
    @rgolea you can found some contribution guideline here: https://github.com/deployd/deployd/blob/master/CONTRIBUTING.md
    if they are not clear, let me know, we can improve it
    Rares Golea
    @rgolea
    thanks!
    I have to warn you I’m not a skilled developer… but I’ll do my best. Thank you for the chance
    Nicolas Ritouet
    @NicolasRitouet
    it’s ok, you can contribute on lot’s of different stuff
    Rares Golea
    @rgolea
    @NicolasRitouet thank you
    Nicolas Ritouet
    @NicolasRitouet
    it can be documentation, design (we’d like to redesign the homepage), easy bugs, etc..
    Rares Golea
    @rgolea
    the homepage?
    Andrei Alecu
    @andreialecu
    yup, documentation is severely lacking
    Rares Golea
    @rgolea
    you mean the dashboard?
    Andrei Alecu
    @andreialecu
    I think he means deployd.com
    Rares Golea
    @rgolea
    I will try my best on the docs but I will be posting a lot of questions
    I think I can manage that too
    would you like something more foundation, more bootstrap or more material-design?
    Andrei Alecu
    @andreialecu
    I think the homepage itself is ok
    Nicolas Ritouet
    @NicolasRitouet
    as @andreialecu mentionned, we have lots of issues in the docs repo: https://github.com/deployd/docs/issues
    yeah, it’s not the priority, but if somebody is good for designing stuff, I’m open to improvements :)
    Rares Golea
    @rgolea
    okay… I will do my best...
    Rares Golea
    @rgolea
    have you guys merged the @andreialecu ’s session2 branch to master? https://github.com/andreialecu/deployd/tree/refactor-session2
    Nicolas Ritouet
    @NicolasRitouet
    which PR is it?
    Rares Golea
    @rgolea
    let me see...
    I can’t find it… maybe he didn’t PR yet...
    Nicolas Ritouet
    @NicolasRitouet
    @andreialecu why is engine.io needed? is it in addition to socket.io?
    Nicolas Ritouet
    @NicolasRitouet
    ok, I get it, engine.io is a dependency of socket.io and you need to specify a specific version of engine.io to make it work
    Andrei Alecu
    @andreialecu
    @NicolasRitouet yes, they updated ws in the master
    but they didn't bump the version and release to npm
    Nicolas Ritouet
    @NicolasRitouet
    ok
    I’ll make a new release