Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Andrei Alecu
    @andreialecu
    yup, documentation is severely lacking
    Rares Golea
    @rgolea
    you mean the dashboard?
    Andrei Alecu
    @andreialecu
    I think he means deployd.com
    Rares Golea
    @rgolea
    I will try my best on the docs but I will be posting a lot of questions
    I think I can manage that too
    would you like something more foundation, more bootstrap or more material-design?
    Andrei Alecu
    @andreialecu
    I think the homepage itself is ok
    Nicolas Ritouet
    @NicolasRitouet
    as @andreialecu mentionned, we have lots of issues in the docs repo: https://github.com/deployd/docs/issues
    yeah, it’s not the priority, but if somebody is good for designing stuff, I’m open to improvements :)
    Rares Golea
    @rgolea
    okay… I will do my best...
    Rares Golea
    @rgolea
    have you guys merged the @andreialecu ’s session2 branch to master? https://github.com/andreialecu/deployd/tree/refactor-session2
    Nicolas Ritouet
    @NicolasRitouet
    which PR is it?
    Rares Golea
    @rgolea
    let me see...
    I can’t find it… maybe he didn’t PR yet...
    Nicolas Ritouet
    @NicolasRitouet
    @andreialecu why is engine.io needed? is it in addition to socket.io?
    Nicolas Ritouet
    @NicolasRitouet
    ok, I get it, engine.io is a dependency of socket.io and you need to specify a specific version of engine.io to make it work
    Andrei Alecu
    @andreialecu
    @NicolasRitouet yes, they updated ws in the master
    but they didn't bump the version and release to npm
    Nicolas Ritouet
    @NicolasRitouet
    ok
    I’ll make a new release
    0.8.3, no breaking changes, right? (at least, not on documented features)
    Andrei Alecu
    @andreialecu
    there is the one about CORS, when you call deployd cross domain over the web with XHR
    and you need to specify allowed origins explicitly
    Nicolas Ritouet
    @NicolasRitouet
    ok
    Andrei Alecu
    @andreialecu
    instead of allowing all by default (which was a huge security issue)
    a note in the release should be sufficient
    Nicolas Ritouet
    @NicolasRitouet
    yep, I remember now
    Andrei Alecu
    @andreialecu
    @rgolea that PR was merged deployd/deployd#572
    Nicolas Ritouet
    @NicolasRitouet
    damn, build is broken
    Andrei Alecu
    @andreialecu
    restarting
    Nicolas Ritouet
    @NicolasRitouet
    I already did :(
    Andrei Alecu
    @andreialecu
    and still broken?
    looks like it's passing now
    Nicolas Ritouet
    @NicolasRitouet
    cool
    Andrei Alecu
    @andreialecu
    travis sometimes randomly breaks builds
    Nicolas Ritouet
    @NicolasRitouet
    and weird
    :)
    Andrei Alecu
    @andreialecu
    it was a 100ms timeout in one test
    not being respected
    from what I could gather
    before restarting
    Nicolas Ritouet
    @NicolasRitouet
    indeed
    Andrei Alecu
    @andreialecu
    @NicolasRitouet just realized: https://github.com/deployd/deployd/blob/master/.travis.yml you may remove node 0.11, since it was unstable and never released for production, should speed up travis builds a bit
    Nicolas Ritouet
    @NicolasRitouet
    ok
    Andrei Alecu
    @andreialecu
    Looks like I finally got the attention of socket.io's maintainer after people complaining for two months and no response :) https://github.com/Automattic/socket.io/issues/2056#issuecomment-105319753
    Nicolas Ritouet
    @NicolasRitouet
    nice
    then, I’ll wait to have the new version before I release