Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 31 20:13
    jkodu synchronize #1339
  • Jan 31 20:13

    jkodu on core-preload-cssom-updates

    chore: update code owners with … feat(rule): Require unique aria… fix(i18n): Fix Japanese transla… and 6 more (compare)

  • Jan 31 20:08
    jkodu synchronize #1339
  • Jan 31 20:08

    jkodu on core-preload-cssom-updates

    test: update preload related te… (compare)

  • Jan 31 18:54
    stephenmathieson commented #1343
  • Jan 31 18:54
    stephenmathieson synchronize #1343
  • Jan 31 18:54

    stephenmathieson on remove-grunt-lint

    chore: rerun prettier (#1340) Merge branch 'develop' into rem… (compare)

  • Jan 31 16:53
    jkodu edited #1339
  • Jan 31 16:52
    jkodu edited #1339
  • Jan 31 16:50
    jkodu edited #1339
  • Jan 31 16:49
    jkodu synchronize #1339
  • Jan 31 16:49

    jkodu on core-preload-cssom-updates

    fix: update preload cssom to ca… (compare)

  • Jan 31 16:20
    WilcoFiers closed #1342
  • Jan 31 15:27
    tysonwolker starred dequelabs/axe-core
  • Jan 31 10:27

    jkodu on chore-prettier

    (compare)

  • Jan 31 10:27

    jkodu on develop

    chore: rerun prettier (#1340) (compare)

  • Jan 31 10:27
    jkodu closed #1340
  • Jan 31 09:27
    undeadinu starred dequelabs/axe-core
  • Jan 30 19:05
    AdnoC review_requested #1344
  • Jan 30 19:05
    AdnoC opened #1344
PriyalakshmiNandan
@PriyalakshmiNandan
Hi Team.. I am new to Axe-Accessibility Testing.. I just tried to implement Axe with Selenium and I have followed the instruction that was available under -
https://github.com/dequelabs/axe-selenium-java repository..
I have only one query just by calling new AXE.Builder(driverInst, scriptUrl).analyze() will analyze the specified url against the WCAG standard's rules? And where these rules are maintained.. [are these coming from Axe.core? or can you tell me how axe-selenium's Axe class integrates with Axe.core and gets the list of rule?]
Steven Lambert
@straker
@PriyalakshmiNandan axe-selenium uses axe-core under the hood to analyze the page. axe-core defines a list of rules that are run here https://github.com/dequelabs/axe-core/blob/develop/doc/rule-descriptions.md. The default setting will run all rules not marked as experimental
the rules are a mix of tests against WCAG standards as well as some best practices rules not defined by WCAG but help with accessibliity
Glen Pike
@glenpike
Hi, we've been using the axe browser extension for Chrome & Firefox and I've just started playing with the axe-matchers in our Rails test suite. The first thing I've noticed is that the axe-matchers are picking up on aria-allowed-role(https://dequeuniversity.com/rules/axe/3.1/aria-allowed-role?application=axeAPI) issues, which the browser extension does not. Is this something to do with versions / settings, or something I'm not aware of?
Jey
@jkodu
@glenpike thanks for reporting the issue with axe-matchers. Just from looking at it briefly, it looks like rule tagged as best practice may be included by axe-matchers. I am investigating the issue further. Can you confirm if you just ran something like page.be_accessible without any additional clauses?
Glen Pike
@glenpike
Hi @jkodu thanks for the reply, yes, I've been running assertions like this expect(page).to be_accessible.within('#main-content'), but if I suppress that error: expect(page).to be_accessible.within('#main-content').skipping('aria-allowed-role') I don't seem to get any of the other complaints I get from the dev-tools axe either - e.g.
Screenshot 2019-07-08 at 14.14.42.png
(I might be misunderstanding something here...)
Jey
@jkodu
@glenpike understood. I will get back after some debugging.
Oliver Small
@ollysmall
Hey, new here! I have a decorative background video which keeps getting flagged in my axe audit. Does anyone have any recommendations/best practices for decorative videos?
Oliver Small
@ollysmall
Is there a way to get axe to ignore decorative videos?
Steven Lambert
@straker
@ollysmall What does the decorative video look like in the HTML? You could add aria-hidden=true on a parent element
for best practices, I suggest making sure the video can be still be paused by the user so if it is or becomes distracting they can stop it from playing
Oliver Small
@ollysmall
@straker thanks, I just tried the aria-hidden on the parent element but it still gets flagged in my axe audit. Any other ideas to ensure it doesn't get highlighted as an issue? Below is the current code block which gets used in a slideshow. Users have the ability to change slides so they can change to a slide without the video and once they manually change the slide the slideshow pauses.
<div class="video_background" aria-hidden="true">
    <video preload="auto" paused="" muted="" loop="" playsinline="" data-width="1920" data-height="1080">
        <source src="https://player.vimeo.com/external/examplevideo.mp4" type="video/mp4" class="slide-item__image">
    </video>
</div>
Jey
@jkodu
@glenpike I did some thorough debugging by comparing results between axe chrome and firefox extension vs that of axe matchers, using clauses like within and skipping. In all cases I got EXPECTED results with axe matchers which were the same as reported by the extension. The only time results were not the same was when within was pointing to a non existing node on the page. Also the browser extension runs on the entire document context as against a scoped Element on the page, this may be a reason on your end to see different number of results. Hope that helps.
Steven Lambert
@straker
@ollysmall So I ran axe.run on your video code using the newly released axe v3.3.0, and it didn't produce any violations. Which problems were being flagged in your axe audit?
<main>
  <h1>Hello</h1>
  <div class="video_background" aria-hidden="true">
     <video preload="auto" paused="" muted="" loop="" playsinline="" data-width="1920" data-height="1080">
        <source src="https://player.vimeo.com/external/examplevideo.mp4" type="video/mp4" class="slide-item__image">
    </video>
  </div>
</main>
Oliver Small
@ollysmall
@straker ahhh... I've just realised that they are actually issues which "need review" rather than actual violations! Am I fine to just keep the aria-hidden on it and mark them as "not an issue"? The descriptions of the issues were "<video> elements must have captions" and "<video> elements must have an audio description track". It would be nice if there was a way for the video to stop being highlighted as needing review - some kind of tag which defines it as a decorative video only.
Steven Lambert
@straker
@ollysmall Should be fine to keep the aria-hidden. We've actually had a few requests about not checking background videos for captions dequelabs/axe-core#1674. I'll do some digging and see what that would look like
Oliver Small
@ollysmall
@straker cool, good to know! Thanks so much for your help!
Glen Pike
@glenpike

@jkodu thanks for checking. Reading the comments from Oliver, I can see that my issues in the browser are showing under 'Need review'. Are these not flagged by the axe-matchers because they need visual checks?
Typically, all the items flagged are 'Ensures the contrast between foreground and background colors meets WCAG 2 AA contrast ratio thresholds' and the tool says 'Element's background color could not be determined due to a background image'

Interestingly, the browser doesn't pick up on the 'aria-allowed-role' violations for me.

aknowlescti
@aknowlescti
If I fix all the violations found by the Axe Chrome extension v. 3.2.2, will my site be Level AA compliant?
Steven Lambert
@straker
@aknowlescti it will not. automated testing tools, such as axe, can only check for testable accessibility violations, which is only ~20-30% of accessibility violations. you still will need to do manual testing to be complaint
aknowlescti
@aknowlescti
@straker Thank you. That is very helpful information.
Anastasia Lanz
@anastasialanz
I was testing out the aria roles issue about a required parent role and noticed that the Firefox aXe extension will flag it, but it will not show up with the Chrome aXe extension. Has anyone else seen this happening?
Oliver Small
@ollysmall
When focus trapping inside of a modal, is it good practice to set the focus back on the first focusable element if the user continues to tab after the last focusable element within the modal? That way they can tab back to the start easier?
Wilco Fiers
@WilcoFiers
@ollysmall It's a common pattern, but I think the better way to handle modals is to disable everything in the background, since that means users still have access to their browser chrome. If you loop focus, you prevent users from moving focus out of the page, for example to go to the back button.
Oliver Small
@ollysmall
@WilcoFiers good point! I have written some custom code to disable focusable elements in the background but I will go ahead and remove the focus looping. As a secondary question, does there need to be any aria attribute on a button/link that would launch a modal? I have added role="dialog" and aria-modal="true" to the modal container but my button has no indicator that it will open a modal.
Cassey Lottman
@clottman

I am trying to set up react-axe 3.2.0 and after the first burst of errors on my page, I see an Expect axe._selectorData to be set up exception.
Googling, it seems this issue happens if you call axe twice, but I’m only calling it once. It also happens on old versions, but I have the latest one. Anyone have any clues?

I downgraded to 2.1.9 and don’t get that error any more. But do get Error: No response from frame: #react-tabs-1 > .embed__embedContainer___3gG1g > iframe.embed__embedIframe___xD0aJ. I’ve tried passing in a variety of things to try to get it stop checking iframes at all, as iframes on our site contain user content we don’t control and also are slow to load. But no luck.

I’d expect one of these options I’m passing to make axe not wait for my iframes:
axe(React, ReactDOM, 3000, { iframes: false, exclude: [['iframe']] });

Anyone know what I'm doing wrong?

Steven Lambert
@straker
@clottman do you have a test page we could look at? I don't know a lot about react-axe but can give it a look
Adil Hussain
@adilsofficial
Hi All,
I'm new with axe-core and webdriverjs, I generated the test report of testSubject in JSON format using AxeBuilder().analyze() but I would like to generate the test results in JSON-LD encoded EARL format. I tried to integrate the Axe EARL Reporter but unable to connect it. Do you have some guidelines or tutorial to work on it?
Justin Schieck
@JustinSchieck
Hi all. I apologize if this has been talked about already but Ive noticed that sometimes on sites we hit (Error: Could not establish connection. Receiving end does not exist.) is there any information on what could be causing this error? It seems to be intermittent.
Wilco Fiers
@WilcoFiers
Thanks for reporting Justin. The problem happens when the extension is unable to inject axe into the web page. Closing the extension, refreshing the page and then opening it back up should solve it. We've seen a recent spike of this happening, and are looking into it.
Wilco Fiers
@WilcoFiers
Do you have any way to help us reproduce the issue Justin? That would really help. We've not been able to reproduce this consistently.
Justin Schieck
@JustinSchieck
I'll try, seems to be pretty random and I have no way to really get any logs for you. I turned on the local browse mode in details as it wasn't able to access local files thinking that might be it but its happening on other sites. If i find a way, I'll post it here. Thanks for the quick reply
Justin Schieck
@JustinSchieck
Screen Shot 2019-09-10 at 1.27.58 PM.png
i mean this probably doesnt help but i tried running it on this gitter conversation and got the same issue. I have a screenshot
Wilco Fiers
@WilcoFiers
Yeah, the randomness is exactly why we're having such a hard time pinning it down. I'm not getting it on Gitter at all. Thanks for reporting anyway, we'll keep working on it.
Jason
@scurker
@JustinSchieck Is there any way you could provide a short screencast/video of your full screen when this happens?
I don't see axe-version displayed in the extension, which means there's some sort of tab communication issue
Justin Schieck
@JustinSchieck
in my above screenshot it says the version number 3.9.0
Jason
@scurker
That's the version of the extension, you should also see the version of axe (axe-core 3.3.2)
Justin Schieck
@JustinSchieck
oh good point. sure one sec on the full screen.
Actually I will have to send it later from a personal comp.
Justin Schieck
@JustinSchieck
Screen Shot 2019-09-10 at 2.18.25 PM.png
got it without all the important work related stuff.
aimeeew
@aimeeew
Hello, I was wondering if I could get some clarification on how the aXe Chrome extension works please - does it make any POST requests/submit any data when encountering a form?
Steven Lambert
@straker
It shouldn't submit any form data
Wilco Fiers
@WilcoFiers
Nope, axe tests the page in the state it is in. It doesn't interact with the page, as that might cause unintended side effects. Wouldn't want to accidentally delete someone's bank account or whatever