Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Dec 11 2020 04:48
    dependabot[bot] labeled #379
  • Dec 11 2020 04:48
    dependabot[bot] opened #379
  • Dec 11 2020 04:48

    dependabot[bot] on npm_and_yarn

    Bump ini from 1.3.5 to 1.3.7 B… (compare)

  • Sep 08 2020 02:33
    codecov-commenter commented #378
  • Sep 08 2020 02:31
    dependabot[bot] labeled #378
  • Sep 08 2020 02:31
    dependabot[bot] opened #378
  • Sep 08 2020 02:31

    dependabot[bot] on npm_and_yarn

    Bump http-proxy from 1.17.0 to … (compare)

  • Sep 07 2020 06:38
    diegohaz commented #171
  • Sep 07 2020 06:37
    diegohaz commented #171
  • Sep 07 2020 06:35
    diegohaz commented #171
  • Sep 07 2020 06:22
    sunny775 commented #171
  • Sep 07 2020 06:20
    sunny775 commented #171
  • Sep 07 2020 06:19
    sunny775 commented #171
  • Sep 04 2020 20:13
    codecov-commenter commented #377
  • Sep 04 2020 20:11

    dependabot[bot] on npm_and_yarn

    (compare)

  • Sep 04 2020 20:11
    dependabot[bot] closed #369
  • Sep 04 2020 20:11
    dependabot[bot] commented #369
  • Sep 04 2020 20:11
    dependabot[bot] labeled #377
  • Sep 04 2020 20:11
    dependabot[bot] opened #377
  • Sep 04 2020 20:11

    dependabot[bot] on npm_and_yarn

    Bump handlebars from 4.1.2 to 4… (compare)

Haz
@diegohaz
But, if people still want to migrate, I think the easiest way is cloning redux-ssr and putting their components, containers, store etc. in there, since those pieces didn't change too much.
Santino
@santino
I'm looking into the redux-ssr and I have one question, why did you get rid of the csrf token?
Haz
@diegohaz
CSRF attack can happen when you accept form data within your application. On universal-redux, PostCreateForm is universal, that is, it responds to POST requests on server side. On redux-ssr, it doesn't.
Ruslan Kyba
@kybarg
Seems like "redux-ssr" is less suitable for today's web) "universal-redux" can come in handy when people don't wait for website to fully load and submit login form)
Haz
@diegohaz
I really don't see people worrying about forms working on server (even on big companies I'm working with). That's why I didn't implement it on redux-ssr
But it's not hard to implement at all. That's just a combination of https://github.com/diegohaz/redux-form-submit and https://github.com/expressjs/csurf
Santino
@santino
@diegohaz I'm having some issues with redux-saga-thunk (thanks for this library BTW, sounds very interesting).
I have registered it and on my request and success actions I see the meta just fine, also the proper thunk branch in my store is populated correctly; still thought I can't get the promises to work.
I'm doing dispatch(action(payload)) and adding a .then() or .catch() doesn't seem to do anything, they never get called
Haz
@diegohaz
@santino could you share some pieces of code (and log from redux devtools)?
It seems like that's working, but the promise isn't being fulfilled
Santino
@santino
sorry for not coming back to your earlier, been a bit busy but managed to fix the issue and now the redux-saga-thunk is working as it's meant to do

I have a question though, exploring the code, I see in failure actions you're doing this:

export const postCreateFailure = (error, request, thunk) => ({
  type: POST_CREATE_FAILURE,
  error: true,
  payload: error,
  meta: {
    request,
    thunk,
  },
})

I see that when you grab the error in the catch after dispatching an action what you actually receive is that error: true that is present in the snippet above but I believe the payload: error is unused hence useless here, is that the case and should we just not send a payload since you can't make use of it?

it seems like instead of the payload you need to feed the error property with anything you might need to deal with
Haz
@diegohaz
Oh, that's a bug on redux-saga-thunk then
We need to pass response to reject, not err
Would you mind to send a PR there?
error: true,
payload: error,
That's the Flux Standard Action default
Santino
@santino
sure thing, can look into that
Matt
@Geczy
I'm sure you can see it but can you take a look at diegohaz/arc#292 @diegohaz
scrapcupcake
@scrapcupcake
Howdy folks. A simple question but I don't see it in the docs; Where can I put static assets, background images and such, so they'll be visible to my dev server and storybook server? Public doesn't seem like its doing the trick, or I don't understand what url their buried under.
scrapcupcake
@scrapcupcake
Looks like I solved it for myself; public is being copied into the build, but added it to storybook via -s ./public in the package.json
Haz
@diegohaz
@scrapcupcake Nice. Could you send a PR?
Ruslan Kyba
@kybarg
Hi @diegohaz ! I run into issue... My API returns response {items: [...], count: 100} and I can't understand how to make it work with new approach in redux-ssr branch as payload is a promise as I uderstand and I cant get it attributes before resloved
Haz
@diegohaz
@kybarg You should be able to use payload.items, update saga to store response.items instead of response or update the API service to handle it
Ruslan Kyba
@kybarg
@diegohaz payload.items results into Can't get property 'items' of undefined
Steven Haddix
@steven-haddix
@diegohaz I have a quick question about the modal container in the arc project. Is there a reason you allowed a prop override of isOpen here but used an || operator?
it seems you can only override if true
Haz
@diegohaz
@steven-haddix You are right
Maybe we should change it to isOpen: typeof isOpen === 'undefined' ? fromModal.isOpen(state, name) : isOpen?
Steven Haddix
@steven-haddix
Yeah I think something like that makes sense. That way you can override with a close as well as open parameter.
@diegohaz
Haz
@diegohaz
@steven-haddix Do you want to open a PR?
Steven Haddix
@steven-haddix
@diegohaz Yeah I'll try to get one up a little later today
for PR's do you typically do one for each of the branches? (plain, redux, ssr)
Haz
@diegohaz
Just do for the specific branch (redux) and I merge it later with ssr
Steven Haddix
@steven-haddix
@diegohaz any thoughts on how to handle unmounting (updating redux store) the react modal if the page transitions during the modal being open?
Haz
@diegohaz
@steven-haddix I would dispatch an action to close the modal inside react-router's history.listen.
Steven Haddix
@steven-haddix
@diegohaz that's pretty clever. i like it.
Mauro Silva
@maurosergiosilva
Hi
I'm new using arc and wat to know if I can solve some doubs with you gys :)
Mauro Silva
@maurosergiosilva
I'm studing how components works, and how to fit my prefered components (Grommet 2.0).
I'm play with it in Storybook now. My first question is about how you deal with my new components and those from arc.
For example, Grommet has a Button that I will use isteand Button from Arc components. But if I change Storybooks and test, how I will upgrade arc!? I mean I will net work in my fork !?
Mauro Silva
@maurosergiosilva
Theres no way just use Arc stuffs as dependencys that I upgrade in my project !? Like a core that my projects use and could be upgraded.
?
Mauro Silva
@maurosergiosilva
Mybe using lerna so generator culd know what modules install
How you deal with those problems!?
In you projects?!
Mauro Silva
@maurosergiosilva
OK, for now I create my my-example scrit and set to src-my-example
Ben Dean
@bd
anyone around? i could sure benefit from a few minutes time with someone who knows a little bit about the redux-ssr branch and webpack, especially w.r.t. containers