Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 07 16:14
    kaste auto_merge_enabled #1631
  • Oct 07 16:13
    kaste synchronize #1631
  • Oct 07 16:13

    kaste on do-not-appveyor

    Remove testing on "appveyor" Add testing on Windows to the G… (compare)

  • Oct 07 16:11

    kaste on rebind-tag-show-commit

    (compare)

  • Oct 07 16:11

    kaste on master

    Re-bind `gs_tags_show_commit` t… Merge pull request #1630 from t… (compare)

  • Oct 07 16:11
    kaste closed #1630
  • Oct 07 16:09
    kaste opened #1631
  • Oct 07 16:08

    kaste on do-not-appveyor

    Remove testing on "appveyor" Add testing on Windows to the G… (compare)

  • Oct 07 16:05
    kaste synchronize #1630
  • Oct 07 16:05

    kaste on rebind-tag-show-commit

    Re-bind `gs_tags_show_commit` t… (compare)

  • Oct 07 16:05
    kaste closed #1629
  • Oct 07 16:05

    kaste on master

    Fix: Move cursor to active bran… Rename `gs_branches_set_cursor`… Merge pull request #1629 from t… (compare)

  • Oct 07 16:05

    kaste on hotfix-branch-navigate-to-active-branch

    (compare)

  • Oct 07 16:05
    kaste auto_merge_enabled #1630
  • Oct 07 16:04
    kaste opened #1630
  • Oct 07 16:04

    kaste on rebind-tag-show-commit

    Re-bind `gs_tags_show_commit` t… (compare)

  • Oct 07 16:02
    kaste auto_merge_enabled #1629
  • Oct 07 16:02
    kaste opened #1629
  • Oct 07 16:01

    kaste on hotfix-branch-navigate-to-active-branch

    Fix: Move cursor to active bran… Rename `gs_branches_set_cursor`… (compare)

  • Oct 06 12:09
    kaste closed #377
Adrian L Lange
@p3lim
not sure what's causing this, can only find this issue with Lua (which got its syntax updated in 3186)
Simon
@stoivo
Hmm
Kyle Bebak
@kylebebak
Hey all, a question
In divmain/GitSavvy@5f75d37 it seems like code was added that runs git commit before the git commit view is opened is there are pre commit hooks
This is a little weird, because these pre-commit hooks are running twice:
once before the git commit view is opened, and once when the commit actually takes place
Kyle Bebak
@kylebebak
I've tested this in multiple repos, using a hook I found in an old issue in GitSavvy
#!/bin/sh

sleep 1
echo "yo"
sleep 1
echo "hey"
sleep 1
echo "who loves slow commits?"
sleep 2
echo "this guy"
sleep 2

exit 0
One side effect of running actually running /usr/local/bin/git commit -q before opening the commit view is that if there's nothing to commit, the view simply doesn't open
Because this command exits with a status code of 1, not 0
This behavior does not occur if you don't have a pre-commit hook
You can open the commit view even if there's nothing to commit
So I guess those are the issues: we shouldn't run /usr/local/bin/git commit -q before opening the commit view, even if there is a pre commit hook. git commit and the pre commit hook should only be run when the user explicitly runs the commit from the commit view
Kyle Bebak
@kylebebak
If it makes sense to create an issue for this I'd be glad to
Randy Lai
@randy3k
We need to run the commit command before the view is opened. That is needed for the pre commit message hook at least, to obtain the message.
Kyle Bebak
@kylebebak
Rats, I figured there was a good reason it was running before opening the view =(
How about making it configurable via settings? Whether the command runs before opening the view?
Randy Lai
@randy3k
The issue of running the command only occurs when there is nothing to commit!?
if that's the case, we just need to catch the exception.
Kyle Bebak
@kylebebak
Yeah, I agree, but it won't solve the issue of having to run the pre commit hook twice, which is a bit painful for slow hooks, like the silly one I pasted above
But that's fine, I'm going to move slow stuff into pre-push instead of pre-commit
Randy Lai
@randy3k
It is unfortunately a side effect of perpare-commit-msg hook. AFAIK, there is no way to just invoke the perpare-commit-msg hook. Right now, the perpare-commit-msg hook and pre-commit hook are fired before the view is opened.
After the view the closed, we do the actual commit together with the commit-msg hook.
Unfornately, as the result of this, the hook pre-commit is triggered again.
There is a option to pass --no-verify in the second commit command, the pre-commit hook will not be triggered, however, it will also disable the commit-msg hook if there is any.
Kyle Bebak
@kylebebak
Ahh, cool, I'll look into passing --no-verify for the second command
Thanks for explaining, this definitely doesn't merit creating an issue
Simon
@stoivo
How do you run tests?
herr kaste
@kaste
You install 'UnitTesting' via PackageControl. Then invoke Test Current Package and more often Test Current File via command palette.
For Test Current File you must first be looking at a test file, after that you can walk around because it will remember the last file used.
dholland2377
@dholland2377
is anyone able to assist with a small setup problem I'm having?
dholland2377
@dholland2377
disregard, I skipped a step :(
Simon
@stoivo
ok, just come back if there are some questions later
Wasim Juned
@wasimjuned_twitter
Not quite sure I understand how to use GitSavvy in Sublime. I've installed the package as mentioned here: https://github.com/divmain/GitSavvy
but I can't find any Usage instructions. Do you right click, use a menu action, or use the Command Palette to trigger an action? Specifically I'm wanting to show blame or log for current file but would be useful to find out more generically how to use this plugin.
herr kaste
@kaste
Usually you start with the command palette, over time you probably do everything with key bindings. The package also ships documentation accessible via GiSavvy Help or in the GitHub repo.
Wasim Juned
@wasimjuned_twitter
@kaste Is there any documentation on the keybindings to show blame or log for current file?
E.g. to keep it simple I tried git log. According to this: https://github.com/divmain/GitSavvy/blob/master/docs/history.md#git-blame-current-file
I enter git: log somewhere. I've tried entering it into the Command Palette but nothing happens.
herr kaste
@kaste
Something like this should happen
IrvNLeDXpP.gif
Try to have a git controlled folder open, and a git controlled file of course. Otherwise check if GitSavvy is actually installed.
Simon
@stoivo
@kaste divmain/GitSavvy#1124 agree?
herr kaste
@kaste
@stoivo yes
Simon
@stoivo
Good
Simon
@stoivo
Hey core team, It would be good for us if we could have a hangout tougther. Just to talk for 15 minutes or so. Make a some disision on what we want to to with releases. What do you think. I would like to talk with you all, get to know you a little better. What do you think? What timeszones are you in.
I am from Norway so we are +2 now(summer and winter time)
Simon
@stoivo
Maybe we have to fork GitSavvy to a orginization and ask packagecontroll to move the GitSavvy source from divmain/GitSavvy to gitsavvy/GitSavvy
Randy Lai
@randy3k
It is however a project of divmain, I guess we will need to get his consensus. (Actually I sent him multiple emails related to this idea but he didn’t report)
Reply
herr kaste
@kaste
Fwiw GitSavvy is MIT so we have consensus to fork etc. We cannot republish under the same name though. Package control does support renaming so it is possible technically.
I mean in the long run there is no other option but it's sad.
Simon
@stoivo
Hmm, what do you think of having a google hangout together?
herr kaste
@kaste
You know my Gmail address