The only issues I have run into so far are some pretty bad memory leaks due to not cleaning up removed DOM nodes when data changes
but its in play store hang on
Its not as smooth as iOS
"666-666-6666" is not a valid phone :)
i'll try all 5s next
things are "closed" at the moment, but i'll try again later to play with the functionality
@dmvaldman have you run up against this problem yet: https://github.com/aprender/ReFamous/issues/11#issuecomment-247228511
The infamous crew just flagged it with me, I'm checking if its an issue with ReFamous now.
The scroll view comes in a container by default now
So it should just work.
on line 156 try changing
if (!contentLength) return false;
to
if (!contentLength || ! viewportSize) return false;
for instance, you'll be able to go from portrait to landscape with
undefined sized items, and your place in the scrollview will be fixed
the
unit value will be 1 if roundToPixel is set to true. This will lead to the x, and y value of the CSS3 transform to be rounded to the nearest integer
the text will be the same, it will just make sure the
<div> is translated by a whole number (to avoid blurring of text due to anti-aliasing)
note however, that if the
Surface is in a ContainerSurface that doesn't also have roundToPixel = true then the text may still be blurry
I see that this.roundTopixel is past as a parameter to _setTransform, but this.roundToPixel will be undefined because is never defined in the DOMOutput constructor, if im not wrong. https://github.com/dmvaldman/samsara/blob/1c1358047baa22610375a3dacf98a78b6ff4fcfe/samsara/dom/_DOMOutput.js#L214
thanks for the tip!
@dmvaldman