Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Dec 19 2020 05:41
    dmvaldman closed #76
  • May 27 2020 05:36

    dmvaldman on master

    Update README.md (compare)

  • Jul 27 2019 15:56

    dmvaldman on master

    Fix spaces (compare)

  • Jul 27 2019 15:28

    dmvaldman on master

    Upgrade eslint version due to s… (compare)

  • Dec 16 2017 02:03
    skaraman commented #76
  • Dec 16 2017 01:49
    skaraman commented #76
  • Dec 16 2017 01:48
    skaraman commented #76
  • Dec 16 2017 01:37
    skaraman commented #76
  • Dec 16 2017 01:35
    skaraman commented #76
  • Dec 16 2017 00:34
    skaraman edited #76
  • Dec 16 2017 00:28
    skaraman opened #76
  • Oct 01 2017 12:10
    culyun commented #74
  • Oct 01 2017 12:08
    culyun commented #74
  • Oct 01 2017 04:41

    dmvaldman on noqueue

    Fix typo End event happens on different … Locking seems to be working and 2 more (compare)

  • Sep 30 2017 17:03
    trusktr commented #74
  • Sep 30 2017 07:57
    culyun commented #74
  • Sep 30 2017 00:40
    dmvaldman closed #75
  • Sep 08 2017 05:22
    dmvaldman commented #75
  • Sep 07 2017 22:36
    newswim opened #75
  • Sep 02 2017 16:21
    dmvaldman commented #74
David Valdman
@dmvaldman
that means i'm doing a good job! hopefully it only gets easier on your end
Andrew Prendergast
@aprender
@dmvaldman have you run up against this problem yet: https://github.com/aprender/ReFamous/issues/11#issuecomment-247228511
The infamous crew just flagged it with me, I'm checking if its an issue with ReFamous now.
Richard Kopelow
@richardkopelow
Is there a ScrollView type container like the old famous? I'm sure I could build one but no sense in reinventing the wheel if I needn't
David Valdman
@dmvaldman
@richardkopelow if you specify a size for the scroll view it will be clipped in a container
The scroll view comes in a container by default now
So it should just work.
Richard Kopelow
@richardkopelow
Gotcha, I missed it in the code, I didn't see it in the docs on samsara.org .
David Valdman
@dmvaldman
@richardkopelow pull requests welcome! https://github.com/dmvaldman/samsara-guides
Richard Kopelow
@richardkopelow
Ok, I am having a problem with the ScrollView, it is crashing online 157. It says that the viewportSize is undefined. Any ideas?
David Valdman
@dmvaldman
hmm not sure why. the demos that use Scrollview seem to be working fine (Carousel, ParallaxCats and SafariTabs)
on line 156 try changing if (!contentLength) return false;
to if (!contentLength || ! viewportSize) return false;
Richard Kopelow
@richardkopelow
I was chaining the add function off of adding a container surface, Once I added the scroll view to the containerSurface itself it worked.
David Valdman
@dmvaldman
:thumbsup: there will be some changes soon to the scrollview. they'll enable parts of the scrollview to animate in size without distorting the placement of other parts
for instance, you'll be able to go from portrait to landscape with undefined sized items, and your place in the scrollview will be fixed
Fredy Mendez
@frh3ddy
Hi, does the property roundToPixel in the Surface options object still works? I set it to true but I see no difference. the text looks the same. i went to see the sourcecode for the surface and I didnt see any place where roundToPixel is been used.
the unit value will be 1 if roundToPixel is set to true. This will lead to the x, and y value of the CSS3 transform to be rounded to the nearest integer
the text will be the same, it will just make sure the <div> is translated by a whole number (to avoid blurring of text due to anti-aliasing)
note however, that if the Surface is in a ContainerSurface that doesn't also have roundToPixel = true then the text may still be blurry
Fredy Mendez
@frh3ddy
Oh. I see. I asked because it has no effect at all when I set roundToPixel to true, and it only ahppen when Origin or align are set. the surface is not inside a containerSurface.
Fredy Mendez
@frh3ddy
I see that this.roundTopixel is past as a parameter to _setTransform, but this.roundToPixel will be undefined because is never defined in the DOMOutput constructor, if im not wrong. https://github.com/dmvaldman/samsara/blob/1c1358047baa22610375a3dacf98a78b6ff4fcfe/samsara/dom/_DOMOutput.js#L214
David Valdman
@dmvaldman
oh hmm, you may be right. i'll take a closer look soon!
David Valdman
@dmvaldman
@frh3ddy fixed in dmvaldman/samsara@cfb7952
thanks for the tip!
Joe Andrews
@joeandrews
Hi David, I am seeing some weird flickering issues on android chrome that I suspect is due to the < 1 opacity transitions I am using. Trying to put together a concise codepen but thought I would mention in the mean time incase you had run into any issues yourself
@dmvaldman
David Valdman
@dmvaldman
hey @joeandrews sorry I didn't get this earlier! could you give a little more detail about the flickering you're seeing? a demo would help a lot. are you animating the opacity? is there overflow : hidden?
Joe Andrews
@joeandrews
I am animating opacity and there is overflow hidden, will post a demo tomorrow
Fredy Mendez
@frh3ddy
Hello again David, i was wondering if is there a way to stop the scrolling of a scrollView that is a parent of another scrollView, I have a Parent scrollview with direction Y, and its items are scrol
Fredy Mendez
@frh3ddy
sorry for the previews incomplete comment, here is the complete one. Hello again David, i was wondering if is there a way to stop the scrolling of a scrollView that is a parent of another scrollView, I have a Parent scrollview with direction Y, and its items are scrollViews with direction X, it works when using a mouse with a mouse wheel, because the mouse wheel controls the parent view and. to scroll the child view I enable drag. but when using a trackpad or a mobile device both views scroll. so maybe it would be useful to expose a method in the scrollview to stop listening for scroll events if possible. let me know if you thinks it can be done or maybe is already possible but I just couldn’t find it.
David Valdman
@dmvaldman
hmm interesting...
hadn't thought about that >.<
i guess what you would want is to prevent the event from bubbling. i would think that this should happen automatically because we called event.preventDefault. but maybe i'm missing something
David Valdman
@dmvaldman
okay i've reproduced it
okay got a fix for ya
event.stopPropagation() must also be called in addition to event.preventDefault()
lemme read into this a bit more to make sure i'm not gonna break something else ;-)
David Valdman
@dmvaldman
@frh3ddy fixed on master dmvaldman/samsara@dffba67. good work team
David Valdman
@dmvaldman
This message was deleted
Kapture 2016-10-11 at 0.12.52.gif
here's a (really corrupted) teaser showing some beginning work on a 3d camera
David Valdman
@dmvaldman
when it's done there will be a couple cameras to choose from. one like in the video, where you can rotate and zoom around an object, and another more general one, where you can plan any path through 3d space and have the camera follow it
Fredy Mendez
@frh3ddy
That was quick, thanks.
David Valdman
@dmvaldman
one thing to keep in mind @frh3ddy is that this change would completely disable dragging of the outermost scrollview in either direction, when you drag one of the inner scrollviews
if you wanted something where horizontal dragging went to one scrollview and vertical to another, that would require something different
for that i would propose having some kind of "slider" that mapped to motion of the outer scrollview
Fredy Mendez
@frh3ddy
Slice-1.jpg
yeah, I just test it, I dont know if it this will help. when I try it on an ipad, if I touch on a surface inside the outter scrollview, and then with the other finger, scroll the inner scrollview it works as espected, so I guees that if i can set the variable isTouching to true on the outter scrollview, it could work. or maybe is just how ios handles touch gestures, I hope you undertand what im trying to say