Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 16 12:18
    matthewp commented #1192
  • Aug 16 12:18
    matthewp labeled #1192
  • Aug 14 18:55
    coveralls commented #1193
  • Aug 14 18:36
    greenkeeper[bot] labeled #1193
  • Aug 14 18:35
    greenkeeper[bot] opened #1193
  • Aug 14 18:35

    greenkeeper[bot] on rimraf-3.0.0

    chore(package): update rimraf t… (compare)

  • Aug 14 18:23
    hurgleburgler opened #1192
  • Aug 14 18:11

    greenkeeper[bot] on rimraf-2.7.1

    (compare)

  • Aug 14 17:12

    greenkeeper[bot] on rimraf-2.7.1

    chore(package): update rimraf t… (compare)

  • Aug 14 01:12

    greenkeeper[bot] on rimraf-2.7.0

    (compare)

  • Aug 14 00:20

    greenkeeper[bot] on rimraf-2.7.0

    chore(package): update rimraf t… (compare)

  • Aug 09 08:52
    coveralls commented #1191
  • Aug 09 08:34
    greenkeeper[bot] labeled #1191
  • Aug 09 08:34
    greenkeeper[bot] opened #1191
  • Aug 09 08:33

    greenkeeper[bot] on commander-3.0.0

    fix(package): update commander … (compare)

  • Aug 08 20:11
    matthewp labeled #1190
  • Aug 08 20:10
    matthewp labeled #1188
  • Aug 08 20:10
    matthewp commented #1188
  • Aug 08 18:16
    hurgleburgler commented #1188
  • Aug 08 18:10
    hurgleburgler commented #1188
Pestdoktor
@Pestdoktor
Oh, I see a PR is already on the way for that, nice
Gregg Roemhildt
@roemhildtg
Yeah. I just discovered that too quite recently
Matthew Phillips
@matthewp
I'm working on that PR now
Gregg Roemhildt
@roemhildtg
It was after I made that change to fix xhr requests that I started seeing this authentication issue
Matthew Phillips
@matthewp
which fix was that?
Gregg Roemhildt
@roemhildtg
the response.ok. Prior to that, donejs wasn't authenticating because it was throwing an error, even tthough the request was successful, it was missing that ok prop
Matthew Phillips
@matthewp
oh, i see
is it possible to create a small example app with this? if so I can take a look
the only thing I can think is that somehow it is remembering the auth value and setting it in XHR requests or something like that..
Gregg Roemhildt
@roemhildtg
@matthewp that's not going to be super easy..There's a lot of moving parts to this - sql server, authentication, ssr...it took quite a while to get this far.
I did find somethign though
feathers-authentication client is setting some global. And its getting executed in a server environment
Could that be causing this?
Matthew Phillips
@matthewp
I don't think that code is a problem
there is a package that sounds familiar for this issue... one sec
I feel like maybe this was used for this problem: https://canjs.com/doc/can-zone-storage.html
trying to find an example usage...
Gregg Roemhildt
@roemhildtg
I had looked into that. Not sure what to do with it though. maybe use instead of cookie-storage when done-ssr is rendering?
Matthew Phillips
@matthewp
yeah, that's what im thinking
was looking for an example but didn't see one
Gregg Roemhildt
@roemhildtg
How do we check for when done ssr is rendering again?
Matthew Phillips
@matthewp
Gregg Roemhildt
@roemhildtg
:thumbsup: sounds good. Some other stuff came up today...but I'll look into this again after the weekend
Nico R.
@nriesco
If someone has some spare time I posted an issue I have sorting data from a REST API using a promise. I’m looking for front-end side sorting-filtering, not api side.
Thanks!!!
Justin Meyer
@justinbmeyer
Sort is a mutation
This is a mutation in a getter, so it will loop
@nriesco posted a bit in the forum post
Nico R.
@nriesco
@justinbmeyer thanks, I wasn’t able to clone the define list as suggested
I’ll upload new samples (fails)
Nico R.
@nriesco
for instance this won’t work either:
modifiedElements: {
    get: function() {
      if (this.elements !== undefined) {
        return this.elements.map(element => {
          element.order = 123; // this won't work on first load
          return element;
        });
      }
    }
  },
sort will enter an infinite loop but modifying the element won’t. It will show the unmodified errors on first load.
Justin Meyer
@justinbmeyer

@nriesco I'm confused ... the last example shows modifying element (element.order = 123;), and says it doesn't work. But then you imply modifying won't enter an infinite loop:

sort will enter an infinite loop but modifying the element won’t.

This seems contradictory.

Nico R.
@nriesco
@justinbmeyer I’m looking for a way to modify data. It could be either sort, modify or filter. When trying to do any of these actions it just won’t do it “on load”.
But the difference between sort and modify (via map) is that the modification actually works and the sort will end up in an infinite loop
Justin Meyer
@justinbmeyer
what do you mean it just won't do it "on load"?
Also, to be clear .. you can create new data, but you shouldn't MUTATE data in a getter
Do you have to MUTATE data?
Nico R.
@nriesco
I mean if I load/reload the page it won’t show any modified data
Justin Meyer
@justinbmeyer
within SSR?
does it break if you are using development.html?
It shows unmodified data?
Nico R.
@nriesco
Yes is breaks
sorry
it does not break
Production.html breaks
development.html shows unmodified data