Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Jakub
    @donjakobo
    I pinged you on twitter too ;)
    I keep getting an error in Authorization.php on line 79, running PHP 5.3.X
        if ( ! is_array($permission_keys))
        {
            $permission_keys = [$permission_keys];
        }
    Jan Dvorak
    @StorytellerCZ
    @donjakobo Hi, I will try to get some time to take a look on it this week.
    Jan Dvorak
    @StorytellerCZ
    @donjakobo I pushed a fix to my branch together with other updates. I will merge it to the main repository later today. Try it out and let me know what you think.
    Jan Dvorak
    @StorytellerCZ
    Wow! Not sure how, but I managed to find time and solve quiet a bit of issues. I have one issue to solve in HybridAuth (error handling when things go wrong) and then I think we are ready for a beta. If I can do the remaining task in #124 that would be a nice plus.
    Jakub
    @donjakobo
    @AdwinTrave thanks for the effort :)
    appreciate all the work you've done on A3M. I did a very minor facelift update today, cleaning up the homepage etc; We can try to merge Ci3-beta into master sometime soon, as I think the 2.X branch is ready to be deprecated (we can do a final release for history sake)
    Luke Ollett
    @l0c0luke
    do you think this will ever be made into a composer package as opposed to a bootstrapped application?
    Jakub
    @donjakobo
    @l0c0luke answering for myself, I personally don't have experience w composer packages, so that's unlikely. You can help by forking / contributing if that is a goal. Otherwise @AdwinTrave might have need for this.
    Luke Ollett
    @l0c0luke
    cool, thanks for reply @donjakobo ... just to explain my context, i am migrating a project from CI1.8 up to CI2 and now it's at 3 ... a huge pain but whatever, thats what im getting paid for... we were using your original library and would like to continue to use it... we are using it as a module using the HMVC thing...
    app got customized, they even threw shit into the controllers and models that you provide... now while im migrating to this ci3-beta i want to avoid all those pitfalls...
    but thanks for the work. new version is huge improvement
    Jan Dvorak
    @StorytellerCZ
    @donjakobo @l0c0luke I don't have composer experience either so that is problematic. On the other hand that seems what everyone is doing so it might happen, but not for the current release unless somebody else makes it happen.
    PS: As you can see I changed my username AdwinTrave -> StorytellerCZ (to be in sync with my other accounts elsewhere).
    Jan Dvorak
    @StorytellerCZ
    @l0c0luke good catch pushing a fix now
    Luke Ollett
    @l0c0luke
    some more observations, take them as you will... sorry to not push a pr... i think php naming conventions have you use camelcase for functions ... so Index should be index
    if you are using CI3, you should include HybridAuth through it's composer package
    this will remove the need to require it's classes in some of your controllers and the hybrid auth lib
    I use sublime text, and on save check for PSR2 which seems to be the way for coding php now adays. makes the files look real nice and easy to read in diffs and commits
    i added a scope key to the facebook config array and just put email in there, hybrid auth defaults to a lot of permissions.
    Jan Dvorak
    @StorytellerCZ
    This message was deleted
    @l0c0luke Anything HybridAuth related push a PR to HybridAuth and it will then reflect in A3M as well. As for PSR standards and all that stuff, HybridAuth predates that and will follow then from v3. A3M follows the CodeIgniter styleguide.
    Luke Ollett
    @l0c0luke
    ahhh CI style guide, didnt realize. ill look that up. thanks
    Luke Ollett
    @l0c0luke
    using session variables for these queries allows for database errors if the id is not set ... https://github.com/donjakobo/A3M/blob/ci3-beta/application/libraries/account/Authorization.php#L111 ... if the user is not logged in and this function is called, then you get the following error ...
    SELECT COUNT(*) AS `numrows` FROM `a3m_acl_role` JOIN `a3m_rel_account_role` ON `a3m_acl_role`.`id` = `a3m_rel_account_role`.`role_id` WHERE `a3m_rel_account_role`.`account_id` = AND `a3m_acl_role`.`suspendedon` IS NULL AND `a3m_acl_role`.`name` = 'Admin'
    
    Filename: modules/account/models/Acl_role_model.php
    
    Line Number: 118
    You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND a3m_acl_role.suspendedon IS NULL AND a3m_acl_role.name = 'Admin'' at line 4
    in all tehse functions i would check for existence first and reutrn false if aint there or use some sort of deafult that would return false on query. but might as well save a query.
    Jakub
    @donjakobo
    @l0c0luke feel free to put in a fix for those and we will commit. Thanks :)
    Buyung A
    @buyzer
    hello , nice to meet you all :)
    Gelinger Media
    @gelinger777
    @l0c0luke did you solved the problem with ACl_role_model???
    kukuxumusu21
    @kukuxumusu21
    hellos fellas, as of now is it good to use this API? thanks