Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 22 2019 16:30
    jcchalte commented #567
  • Jan 15 2019 14:44
    Tigraine commented #564
  • Jan 15 2019 13:45
    CZEMacLeod commented #564
  • Jan 15 2019 11:23
    twenzel commented #564
  • Jan 15 2019 09:32
    Tigraine closed #564
  • Jan 15 2019 09:32
    Tigraine commented #564
  • Dec 28 2018 00:28
  • Dec 19 2018 18:19
    petersmm commented #548
  • Nov 27 2018 08:07

    twenzel on master

    Fix typo in description (compare)

  • Nov 26 2018 11:27

    twenzel on master

    Updated Nuget key (compare)

  • Nov 23 2018 15:38
  • Nov 16 2018 16:56
    rcollette commented #283
  • Nov 12 2018 20:00
    CZEMacLeod commented #283
  • Nov 10 2018 05:12
    rcollette closed #283
  • Nov 04 2018 08:28
  • Oct 30 2018 20:30
    petersmm commented #548
  • Oct 30 2018 20:30
    petersmm commented #548
  • Oct 30 2018 07:56
    twirpx opened #567
  • Oct 24 2018 21:09
    twenzel commented #524
andersnm
@andersnm
looking forward to it!
btw develop and master branches are out of sync
Daniel Hoelbling-Inzko
@Tigraine
yes - @twenzel based his PR on the master branch..
Toni Wenzel
@twenzel
Will update the dev branch soon.
@Tigraine Yes I need help releasing the nuget packages. At the moment I have to access (or link) to the appveyor project in order to view the build output. Does the build succeed?
Daniel Hoelbling-Inzko
@Tigraine
@twenzel When did we switch to a Appveyor build? ;)
I usually ran the build locally on my machine using the psake script
@twenzel Btw thanks so much for helping out with the project - you might have seen I gave you commit access to the repo.
Welcome to the team :) :clap:
Toni Wenzel
@twenzel
@Tigraine I thought you're using Appveyor because of the appveyor.yml and its nuget api key. Should be switch to Appveyor. (It's free for OpenSource projects)
Daniel Hoelbling-Inzko
@Tigraine
Maybe @rytmis added appveyor :D
Lauri Kotilainen
@rytmis
I did!
The notion of having to publish manually didn't appeal to me.
Ah, right. Now I remember. The Appveyor account is my own, and it's linked to my fork.
There, it's building now, @twenzel
Lauri Kotilainen
@rytmis
Team Dotless should now also have access to https://ci.appveyor.com/project/rytmis/dotless/ -- but if someone wants to register a dotless account in AppVeyor, I think you can fairly easily just use the appveyor.yml I created way back when, and run with that.
So yeah, builds from Master trigger a publish, but it only succeeds if the latest reachable tag is of a version that has not yet been published. So the way to publish a new Nuget is to merge to master, then tag that with the appropriate version spec (e.g. 1.6.0-beta01), and if it's a heretofore unknown version, the build will push it to nuget.org.
Lauri Kotilainen
@rytmis
Build failed, but if you're targeting netstandard now, it's probably because the build agent was VS2015. Imma try changing to VS2017
Lauri Kotilainen
@rytmis
I'd investigate, but it appears that I'm having connectivity issues with Github. :/
Toni Wenzel
@twenzel
@rytmis to create a team/organisation account in appveyor they need an email.
either we create a new mail account (or use any existing) and create an appveyor account. Or we use the appveyor project from @rytmis (when it's possible to target to another github repository). Or I'm creating a new appveyor project.
Toni Wenzel
@twenzel
@andersnm dev branch is now in sync
Toni Wenzel
@twenzel
@rytmis @Tigraine is the secure api_key within the appveyor.xml the correct one to push the nuget packages? If not can anyone provide me the correct encrypted nuget api key (using https://ci.appveyor.com/tools/encrypt) in order to push the packages dotless, dotless.Core, dotless.AspNet, dotless.CLI
Daniel Hoelbling-Inzko
@Tigraine
I have no clue how that works any more .. I can add you as a maintainer to nuget if you tell me your account :)
Whats your account?
Toni Wenzel
@twenzel
@Tigraine "twenzel" ;)
Lauri Kotilainen
@rytmis
@twenzel, I changed the Appveyor build to target the dotless repo
Daniel Hoelbling-Inzko
@Tigraine
@twenzel You've now got access to the nuget
@rytmis :+1:
Toni Wenzel
@twenzel
@rytmis Great! Can you provide me the projectId so I can update the build status badge. This can be retrieved from Settings\Badges.
@rytmis I can view the build at appveyor but not start a new one..
Lauri Kotilainen
@rytmis
Hold on a sec
I gave the "Users" group all permissions except for "delete" and added Team Dotless to the Users role.
(This I did yesterday, already)
@Tigraine, You are the admin of the Dotless org -- can you please add @twenzel to the Team Dotless team?
Daniel Hoelbling-Inzko
@Tigraine
I already added him 3 days ago :)
on github
Toni Wenzel
@twenzel
There's a github webhook url at the appveyor team settigns

GitHub organization webhook URL

Configure webhook with the following URL for your GitHub organization to notify AppVeyor about team membership changes:

https://ci.appveyor.com/api/github-org/webhook?id=xy

Lauri Kotilainen
@rytmis
I don't think that's it, though, because I added that team to Appveyor yesterday -- if you were already a member, it should have worked.
Maybe it's best if someone creates a new Appveyor account altogether? :)
Toni Wenzel
@twenzel
@rytmis @Tigraine Can I release the current master as version 1.6.0? or is this 1.5.3?
Daniel Hoelbling-Inzko
@Tigraine
If it contains any feature changes i'd do a 1.6.0
And I'd say .NET standard support would qualify as a feature :)
Lauri Kotilainen
@rytmis
Have you checked for API breakage?
If it breaks existing APIs (even by way of package splits), the correct SemVer thing to do would be to bump to 2.0
Daniel Hoelbling-Inzko
@Tigraine
Right
Lauri Kotilainen
@rytmis
Mind you, I'm just stating my opinion -- I'm just another contributor. :)