Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 13:04
    JohannesDeml edited #1609
  • 13:02
    dnfadmin commented #1609
  • 13:01
    dnfadmin commented #1609
  • 13:00
    JohannesDeml opened #1609
  • 13:00
    JohannesDeml commented #1604
  • 10:28
    timcassell commented #1596
  • 08:07
    timcassell synchronize #1596
  • 04:20
    timcassell synchronize #1596
  • Dec 04 19:35
    frank-dong-ms commented #1608
  • Dec 04 19:34
    frank-dong-ms commented #1608
  • Dec 04 16:21
    JohannesDeml commented #1150
  • Dec 04 16:20
    JohannesDeml commented #1150
  • Dec 04 16:20
    JohannesDeml commented #1150
  • Dec 04 14:25
    adamsitnik commented #1608
  • Dec 04 14:25
    adamsitnik assigned #1608
  • Dec 04 14:12
    frank-dong-ms opened #1608
  • Dec 04 10:22
    timcassell commented #1596
  • Dec 04 10:18
    timcassell edited #1596
  • Dec 04 10:17
    timcassell synchronize #1596
  • Dec 04 10:12
    timcassell synchronize #1596
Daniel Hughes
@trampster
It doesn't work if set to 9.0 like what worked for @JasonBock
Clinton Ingram
@saucecontrol
What does it do if you set it to 9.0? That's the correct solution
Daniel Hughes
@trampster
If I set it to 9.0 it doesn't compile because the Source Generator doesn't generate any source
Clinton Ingram
@saucecontrol
the roslyn build in the 5.0 RC1 SDK definitely recognizes langversion 9.0. are you compiling with an older VS version instead?
Daniel Hughes
@trampster
No I'm on linux
I'm running 5.0.100-rc.1.20452.10
I'm using vscode and running from the commandline
Daniel Hughes
@trampster
The Source Generator announcement says that it requires Preview: https://devblogs.microsoft.com/dotnet/introducing-c-source-generators/
Why do I need to use the Preview LangVersion to consume a Source Generator?
Although Source Generators are not technically a C# language feature, they are in preview. Rather than introduce a new setting just for Source Generators, we decided it would be easier to just use the existing switch that enables preview language features for the C# compiler.
Given that Preview features are things that could benefit most from benchmarking, it seems an odd choice to not support them.
Daniel Hughes
@trampster
Roslyn doesn't have any problems recognizing langversion 9.0, its just that langversion 9.0 doesn't seem to include Source Generators yet.
Clinton Ingram
@saucecontrol
That's very strange... At the time that announcement was made, Roslyn didn't recognize 9.0, only preview. I believe SDK preview 7 was the first to recognize 9.0, so I would have expected all 9.0 roslyn features to fall under that flag at that point
Daniel Hughes
@trampster
I've asked about it on the roslyn gitter, my guess is that Source Generators wasn't deemed ready in time for c# 9.0 so stayed in preview.
The .net 5 RC1 announcement didn't mention Source Generators, which I thought was strange at the time but could be that it has been delayed.
Clinton Ingram
@saucecontrol
ohhhhhh
you can probably set up an inproc benchmark then https://benchmarkdotnet.org/articles/samples/IntroInProcess.html
Martz
@Martz2804_twitter

hi all, I have a question regarding benchmarkdotnet setup, read the docs but I can't seem to find the solution for it. Maybe this isn't the right tool or I (plan to) use it wrong.

Say you have a library you want to perf test with FunctionA() which calls into a lot of code internal to the lib. You want to benchmark the perf of FunctionA() accross multiple versions of the library. Is there a way to automate this "version switching" with benchmarkdotnet? I can't seem to find it

Clinton Ingram
@saucecontrol
You can do it if the library is in a nuget package: https://benchmarkdotnet.org/articles/samples/IntroNuGet.html
TeBeCo
@tebeco
i think theres a sample about nuget and newtonsoft doing this exactly
oO faster
Clinton Ingram
@saucecontrol
lol
TeBeCo
@tebeco
^^
Martz
@Martz2804_twitter
I don't know how I missed this... thank you folks, for the quick answer :) seems to be what I'm after!
TeBeCo
@tebeco
perfect ;)