Where communities thrive

Join over 1.5M+ people
Join over 100K+ communities
Free without limits
Create your own community

Explore more communities

dotnet/corefx-hackathon

.NET Core Hackathon (6/2) - CoreFX repo chat room - https://github.com/dotnet/corefx/wiki/Hackathon

People

Repo info

Activity

Karel Zikmund

@karelz

Andrii Kurdiumov

@kant2002

receive notification :)

Leonid Tsarev

@leotsarev

Does any one received "Predefined type 'System.Object' is not defined or imported" when running build-test (after successful build)?

Karel Zikmund

@karelz

For everyone: You don't need to block on being assigned the issue (it is just convenience for everyone). Just state the intent of working on something in comments, so others don't work on the same thing ...

Leonid Tsarev

@leotsarev

Karel, please don't feel obligated to answer if you already out

Karel Zikmund

@karelz

@leotsarev that's a weird one. In general: build & build-test is what all team members use + our regular contributors + our CI, so any failures (beyond potentially rare flakiness of a test or sensitivity to environment) is suspiscious

did any test execute for you at all?

Leonid Tsarev

@leotsarev

No.

Ouch, nevermind, I tried to run build and got " DIA SDK is missing" and it seems to be mentioned in the docs

Karel Zikmund

@karelz

yeah, that's a nasty one - the build should have clearly failed

if it was not clear, it is something for us to improve on

if that's the case, please file a new issue adding full log how the failure looks like and that it was not clear it failed right away

(we will eventualy fix it)

Leonid Tsarev

@leotsarev

I was under impression that successful first sync means successful first build

Karel Zikmund

@karelz

oh, if something in the docs lead you to that, point me to it, we can try to improve it

did you read the "new docs"? https://github.com/dotnet/corefx/wiki/Build-and-run-tests#typical-workflow

Leonid Tsarev

@leotsarev

Yes, I was just misread

Sorry for this, it's my fault

Karel Zikmund

@karelz

ok, it happens to all of us :)

Laurent Kempé

@laurentkempe

@karelz

@laurentkempe which tests fail?

I am trying to figure it by running the tests from VS but till now could not run any tests

Jonathan Mezach

@jmezach

So the hackathon in Amsterdam is getting underway

Marco Rossignoli

@MarcoRossignoli

Great!have a nice coding!

Martijn Laarman

@Mpdreamz

Anyone hitting

c1 : fatal error C1083: Cannot open source file: 'C:\Projects\corefx\src\Native\Windows\clrcompression\zlib-intel\adler32.c':

One of many similar errors building c:/Projects/corefx/src/Native/../../bin/obj/Windows_NT.x64.Debug/native\install.vcxproj

Viktor Hofer

@ViktorHofer

@laurentkempe running tests inside currently does not work. Please use the console: msbuild /t:RebuildAndTest inside the test project where its csproj lives

Good Morning all! I'm a member of the team and working from Europe which means I should be available to any questions staying now 😁

starting

Mikhail Shilkov

@mikhailshilkov

Hi @ViktorHofer and all

Viktor Hofer

@ViktorHofer

@Mpdreamz when do you hit these errors? By calling .\build.cmd or by doing something special?

Mikhail Shilkov

@mikhailshilkov

I'm on that picture from Amsterdam

I found an issue which looks very simple: dotnet/corefx#16619

Viktor Hofer

@ViktorHofer

Hi Amsterdam team :)

Martijn Laarman

@Mpdreamz

Calling build.cmd yeah. This is on a clean checkout git clean -fxd and clean.cmd -all

Mikhail Shilkov

@mikhailshilkov

I can find FormattableString in src\CoreLib\System but I have no idea which project/solution I should open and also where the tests are....

Viktor Hofer

@ViktorHofer

Ok 5min

I'll switch to my laptop and will give you pointers

Martijn Laarman

@Mpdreamz

Thanks @ViktorHofer :smile:

Laurent Kempé

@laurentkempe

@ViktorHofer Thanks will try that

Viktor Hofer

@ViktorHofer

@Mpdreamz building should work fine. On which OS? Have you read the instructions and installed all prerequisites?

Martijn Laarman

@Mpdreamz

I did yeah I should have all the required prereqs for Windows

Viktor Hofer

@ViktorHofer

And you are using the visual Studio developer command prompt when calling build?

@mikhailshilkov it's inside Syste.Private.Corelib in coreclr. Have you already cloned the coreclr repo, installed all depencies as described in the instructions and built coreclr ones?

You then open coreclr/src/mscorlib/System.Private.CoreLib.sln

Mikhail Shilkov

@mikhailshilkov

@ViktorHofer ouch, I'm in corefx

Martijn Laarman

@Mpdreamz

I am on Windows Insider build. Building from CMD (it looks like the build calls into dev prompt https://github.com/dotnet/corefx/blob/master/run.cmd#L33 already)

Mikhail Shilkov

@mikhailshilkov

The issue is filed under corefx

Viktor Hofer

@ViktorHofer

Right, as we expose

Mikhail Shilkov

@mikhailshilkov

I'll clone coreclr, thank you @ViktorHofer

Viktor Hofer

@ViktorHofer

Right, as we expose it there in corefx, but the implementation is in coreclr :) The build takes quite a while...

Leonid Tsarev

@leotsarev

Completed about 20% of my issue.
Opened early PR in hope of getting early feedback while I continue
dotnet/corefx#30072