## Where communities thrive

• Join over 1.5M+ people
• Join over 100K+ communities
• Free without limits
• Create your own community
##### Activity
Viktor Hofer
@ViktorHofer
what do you want to know?
Eriawan Kusumawardhono
@eriawan
I need to know the tests (unit tests?) that define possible filenames
@ViktorHofer while I'm waiting for installing CLI to finish, could I open the corefx solution within VS 2017 safely? imho it'll be faster for me to find using VS :slight_smile:
Viktor Hofer
@ViktorHofer
have you done one first build in corefx?
you can't use VS before you have at least one inital build with .\build.cmd
Eriawan Kusumawardhono
@eriawan
to be honest, no I haven't done a build in corefx
Viktor Hofer
@ViktorHofer
The inital build should take ~20-30min
Eriawan Kusumawardhono
@eriawan
20 to 30 min? hmmm
ok. yes, I'll look at that tests now
Viktor Hofer
@ViktorHofer
The link I sent is probably the best place to add the mentioned problematic filename tests
Eriawan Kusumawardhono
@eriawan
great, thanks! I thought the same. because the filename tests should be closely related to FileSystem
Viktor Hofer
@ViktorHofer
I would have expected a file with shared TestData which is used across all the different test files but I couldn't fine one at a first glance
Jeremy who created the issue will probably explain further on Monday but you shouldn't be blocked
Eriawan Kusumawardhono
@eriawan
TestData? is this a folder that's shared across tests?
Eriawan Kusumawardhono
@eriawan
ah, I find it. it's TestData.cs.
Viktor Hofer
@ViktorHofer
sounds good :)
Eriawan Kusumawardhono
@eriawan
thanks
Ahson Khan
@ahsonkhan
There are still some issues available if anyone is interested: https://github.com/dotnet/corefx/issues?q=is%3Aissue+is%3Aopen+label%3AHackathon+no%3Aassignee
Sanders Lauture
@golf1052
hi, i wanted to pickup: dotnet/corefx#27861
Karel Zikmund
@karelz
once you accept, I can assign it to you (so others don't do the same)
Sanders Lauture
@golf1052
ok i've accepted
Karel Zikmund
@karelz
cool, have fun!
Sanders Lauture
@golf1052
first verify on major browsers, is IE a major browser 😅
Tanner Gooding
@tannergooding
@golf1052, according to wikipedia, it is still the 2nd/3rd most popular desktop browser: https://en.wikipedia.org/wiki/Usage_share_of_web_browsers
Karel Zikmund
@karelz
IE, Chrome should be enough
maybe + Edge
Sanders Lauture
@golf1052
who would have known reading cookies in IE would be so difficult
opening a cookie file from INetCache gives me: Cookies are no longer stored in files. Please use Internet*Cookie* APIs to access cookies.
all the other browsers (firefox, chrome, edge) support UTC (instead of GMT)
Karel Zikmund
@karelz
so what happens when you give them GMT?
the RFC requires GMT support - so it is weird that they would not support it ...
they might support UTC on top of that, but not instead ... or am I missing something?
Sanders Lauture
@golf1052
if i give GMT it will set the cookie, same with UTC
Karel Zikmund
@karelz
ok, that makes more sense
Sanders Lauture
@golf1052
I'm looking at creating the SetCookies test, i noticed this annotation on the current SetCookies test: https://github.com/dotnet/corefx/blob/master/src/System.Net.Primitives/tests/UnitTests/CookieContainerTest.cs#L346
not sure what it means
Karel Zikmund
@karelz
We run the tests also on other platforms (.NET Framework, UWP) - your fix is not going to flow into .NET Framework, it will be just in CoreFX for .NET Core and UWP, so you need to exclude the test in .NET Framework
Sanders Lauture
@golf1052
ok so i should add that annotation on my test as well?
Karel Zikmund
@karelz
yes
Sanders Lauture
@golf1052
ok, thanks
Sanders Lauture
@golf1052
Karel Zikmund
@karelz
cool, thanks! I see that Dacid and Max already did code review
Eriawan Kusumawardhono
@eriawan
guys, when running build.cmd I get this error quite often: D:\mygithub\corefx\Tools\dotnetcli\sdk\2.1.300-rc1-008673\NuGet.targets(114,5): error : Failed to download package ' System.Security.Cryptography.X509Certificates.TestData.1.0.2-prerelease' from 'https://dotnetmyget.blob.core.windows.ne t/artifacts/dotnet-core/nuget/v3/flatcontainer/system.security.cryptography.x509certificates.testdata/1.0.2-prerelease/ system.security.cryptography.x509certificates.testdata.1.0.2-prerelease.nupkg'. [D:\mygithub\corefx\external\test-ru ntime\XUnit.Runtime.depproj] [D:\GITHUB_REPO\corefx\external\test-runtime\XUnit.Runtime.depproj]
how to fix this?
Karel Zikmund
@karelz
did you try to run sync ahead of time
that will make build offline - it seems like you have some connectivity problems, so doing sync first might help
Eriawan Kusumawardhono
@eriawan
ok, I'll do sync now
thanks!