CREV - Code REView system that we desperately need; consider joining the Matrix channel instead: https://matrix.to/#/!uBhYhtcoNlyEbzfYAW:matrix.org ; they are bridged
programmerjake @dpc:matrix.org: Luke responded: http://lists.libre-riscv.org/pipermail/libre-riscv-dev/2019-August/002600.html
dpc The max flow algorightm might be useful! Thank you!
dpc The DDoS think... I'm just planing to leave it unadressed just like PGP devs... :D
dpc Just kidding. :D
dpc *thing
dpc The flow algorithm will have to get involved with what we download eventually, yes.
@dpc workflow question: i want to get myself into a position to review
lazy_static 1.4.0. i see that there is already a review for lazy_static 1.3.0. ideally, crev could drop me into a sub-shell w here i can see the diff between 1.3.0 and 1.4.0. is there a way to do that? i see that there is a cargo crev review --diff flag, but i'm not sure what that's supposed to.
(also, when i drop into a subshell, it tells me that i can run the
review command. i assumed that meant the subshell introduced this command, but it did not. so i guess that should say cargo crev review instead?)
(i'm tempted to just git clone
lazy_static and look at git diff 1.3.0..1.4.0, but that is obviously the wrong workflow.)
dpc Cargo crev diff lazy_static
dpc > <@gitter_burntsushi:matrix.org> (also, when i drop into a subshell, it tells me that i can run the review command. i assumed that meant the subshell introduced this command, but it did not. so i guess that should say cargo crev review instead?)
Yes
dpc That's a tough one. I'm siding on "not yet", but then there are no imediately plans for breaking changes.
dpc NixOS? :)
Ralith of course
dpc Also, considering that crev is mostly for Rust developers, I would expect cargo install to work quite well for them, no?
dpc There's even shell.nix in github repo. :)
dpc I've added a new command lookup <query> that lookups crates from crates.io and then sorts them by number or proofs.
Ralith manually built binaries in a nix system tend to bitrot rapidly
dpc libgit2 uses ssl
dpc If there's a way to make it rustls I'm all happy about it.
Ralith oh, the foreign dep? that sucks
Ralith guess we don't have a pure rust git impl
dpc Yes.
dpc crev keeps track of latest url using the timestamps
Ralith good to know
dpc The fact that it's a popular and widely available format is also a plus.
dpc We just have to review these yaml parsers... 😁
Ralith iirc e.g. the python implementation is unmaintained and has had worrying bug reports open for years
Ralith that is to say, the C reference implementation which python among many other people use
dpc I remember Python's yaml.open vs yaml.open_safe... :D
dpc What can I say... Python is just a bad language. :shotsfired:
dpc :D
dpc At very least they should just oxidize. I though there are nice libraries for using Rust to write python modules. :)
dpc Also, we only use a subset of yaml features ... Very small one.
dpc One could use a shell-script and sed/grep to parse proofs.