Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Dec 08 20:59
    LaszloGombos commented #2081
  • Dec 08 20:37
    LaszloGombos commented #2081
  • Dec 08 17:03
    LaszloGombos commented #2081
  • Dec 08 16:58
    LaszloGombos commented #2108
  • Dec 08 16:28
    ryncsn edited #2108
  • Dec 08 16:27
    ryncsn commented #2108
  • Dec 08 16:27
    ryncsn synchronize #2108
  • Dec 08 16:24
    ryncsn commented #2108
  • Dec 08 15:48
    LaszloGombos commented #2081
  • Dec 08 15:48
    LaszloGombos commented #2081
  • Dec 08 15:47
    LaszloGombos labeled #2081
  • Dec 08 15:46
    LaszloGombos commented #2081
  • Dec 08 15:45
    LaszloGombos commented #2081
  • Dec 08 15:33
    LaszloGombos milestoned #2081
  • Dec 08 15:33
    LaszloGombos milestoned #2081
  • Dec 08 15:33
    LaszloGombos milestoned #2081
  • Dec 08 15:33
    LaszloGombos milestoned #2081
  • Dec 08 14:39
    LaszloGombos commented #2094
  • Dec 08 13:48
    Conan-Kudo commented #2094
  • Dec 08 13:47
    Conan-Kudo closed #2047
xevious
@xevious:matrix.org
[m]
Business priorities prevented me from doing anything today other than confirming that the behavior is exactly the same on bare metal.
xevious
@xevious:matrix.org
[m]
I finally had some time to figure out the issue with that test.
Testing it in my fork on GitHub now. It passed with Fedora. I figured I should test all the other distros, as well, because with my luck there's some obscure issue with Arch or something.
Conan Kudo
@conan_kudo:matrix.org
[m]
xevious: can you post a link to the successful run in the PR?
xevious
@xevious:matrix.org
[m]
I will in a little while. I took a break for dinner.
xevious
@xevious:matrix.org
[m]
The Gentoo container takes so long to build.
xevious
@xevious:matrix.org
[m]
Conan Kudo: Any idea if this is a container configuration issue or an intermittent failure? https://github.com/iammattcoleman/dracut/actions/runs/3253792319/jobs/5341391873
Conan Kudo
@conan_kudo:matrix.org
[m]
not a clue
we don't run the tests on all the platforms because it gets too wonky and slow
xevious
@xevious:matrix.org
[m]
I'm not sure what's going wrong with the Gentoo test.
It failed with a node12 error, and I noticed a warning about node12 being deprecated. So, I updated it to use actions/checkout@v3 (instead of v2) and that changed it to use node16, but it's failing with the same error (just with 16 instead of 12).
It's passing on all the other OSes, though.
xevious
@xevious:matrix.org
[m]
Conan Kudo: I just added a comment with links to the test passing in all the containers except Gentoo.
xevious
@xevious:matrix.org
[m]
Update: I actually need to update the Gentoo container to add some missing dependencies.
Conan Kudo
@conan_kudo:matrix.org
[m]
I've approved it and now I just need a way to override to merge it
I've canceled the PRs test run because it'll get stuck again until after we merge it
Conan Kudo
@conan_kudo:matrix.org
[m]
@johannbg: could you approve dracutdevs/dracut#1991 so that it will be merged?
Conan-Kudo @Conan-Kudo sighs
Neal Gompa (ニール・ゴンパ)
@Conan-Kudo
It's rather unfortunate that I can't do anything about these PRs :(
Neal Gompa (ニール・ゴンパ)
@Conan-Kudo
@xevious:matrix.org IT IS DONE!
Conan Kudo
@conan_kudo:matrix.org
[m]
@lnykryn, @pvalena: Pull requests to backport this to Fedora and RHEL 9 have been made:
xevious
@xevious:matrix.org
[m]
Conan Kudo: Are you able to mark this discussion as resolved? https://github.com/dracutdevs/dracut/discussions/1736
Conan Kudo
@conan_kudo:matrix.org
[m]
I don't see a way to do that
I locked the discussion, I don't see any other option
github discussions suck :/
xevious
@xevious:matrix.org
[m]
Running Gentoo CI jobs is going to be very costly. I noticed that all of the container builds except Gentoo finished quickly for my new changes. Gentoo is still going.
Looking at the last container build run, Gentoo takes 4h30m, whereas all the others finish in under 4 minutes:
Conan Kudo
@conan_kudo:matrix.org
[m]
we might want to consider dropping Gentoo or at least moving it to manual
Laszlo Gombos
@laszlogombos:matrix.org
[m]
Conan Kudo: For PRs, building container only required if the PR changes Dockerfile (e.g. test has a new dependency). Running tests on Gentoo without a new dependency is just as fast as other containers as far as I know.
Conan Kudo: Would you consider reviewing some other PRs as well ? This one seems like a core issue with dracut dracutdevs/dracut#1947
Conan Kudo
@conan_kudo:matrix.org
[m]
I've done a few that I felt comfortable reviewing
Laszlo Gombos
@laszlogombos:matrix.org
[m]
Conan Kudo: Thank you very much for the review. Given the review activity on the project in past year, I think it would be good to reconsider and change the "At least 2 approving reviews are required to merge this pull request." to 1 reviews. Not sure who/how is the best way to go about discussing that.
Conan Kudo
@conan_kudo:matrix.org
[m]
yeah I've raised the issue of @pvalena and @lnykryn not being around too much for upstream dracut
I'm hoping that they'll be able to spend more time upstream and give us reviews
Laszlo Gombos
@laszlogombos:matrix.org
[m]
Conan Kudo: Thanks. Appreciated (by all the other fellow contributors as well).
xevious
@xevious:matrix.org
[m]
Conan Kudo Laszlo Gombos Thanks for all your help with the autooverlay module. I appreciate all your guidance/help while I was coding it Conan Kudo, and Laszlo Gombos your help with getting the tests working surfaced a few errors I never would've come across with the bare metal tests I was doing.
1 reply
Laszlo Gombos
@laszlogombos:matrix.org
[m]
Thanks for your contribution xevious . Noticed that you started reviewing other PRs as well, glad to see it !
xevious
@xevious:matrix.org
[m]
Laszlo Gombos: I just gave you access to the Gentoo image I built (with the lvm2 package restricted to only build dmsetup) to run the tests locally and in CI. It was built with the virtual/dist-kernel kernel package, not sys-kernel/gentoo-kernel-bin. You can get it with: docker pull ghcr.io/iammattcoleman/dracut-gentoo:latest
1 reply
Conan Kudo
@conan_kudo:matrix.org
[m]
Laszlo Gombos: could you take a look at my PR please? dracutdevs/dracut#2037
Davide Cavalca and I came across this issue while working on other dracut-centric stuff
Conan Kudo
@conan_kudo:matrix.org
[m]
xevious, Laszlo Gombos: could you both take a look at this for me? dracutdevs/dracut#2105
it seems to do what I want in local tests (let me set all the cowfs stuff, while also letting me short-circuit to not create anything by default)
though I'm marking it as draft for now while I do a few more tests
xevious
@xevious:matrix.org
[m]
I've got a lot going on the next few days. Can you remind me about it on Tuesday if noon-ish comes around and I haven't mentioned that I'm checking it out?
Conan Kudo
@conan_kudo:matrix.org
[m]
xevious: sure
Mrfai
@Mrfai
I have a problem that booting an ISO in a VM using qemu/kvm, the network is not configured properly. If I add a sleep 1 or udevadm settle before the rd.break=initqueue in 99base/init.sh everything works and eth0 gets an IP address. Without it, I the interface is named ens3 and it does not get an IP. I guess it's a corner case because on real hardware (on two notebooks) I had no problems. But looking at the init.sh code I seems reasonable to add udevadm settle (and not udevsettle) before the main loop.
I use network-legacy and no systemd dracut modules on my iso. But systemd-udevd is available in the initrd.