These are chat archives for dronekit/dronekit-android

10th
Sep 2016
Bill Bonney
@billbonney
Sep 10 2016 19:01
@ne0fhyk I’m having some problem building the develop barcnh of tower
Fredia Huya-Kouadio
@ne0fhyk
Sep 10 2016 19:02
@billbonney what issues are you running into?
and can you try with the standalone branch instead.
Bill Bonney
@billbonney
Sep 10 2016 19:03
ok, roger that. I had to fix public specifiers on dronekit-android for the standalone app
Fredia Huya-Kouadio
@ne0fhyk
Sep 10 2016 19:03
that branch contains the 3dr services free version of Tower, and it hasn't been merged into develop yet.
Bill Bonney
@billbonney
Sep 10 2016 19:04
Then In tower it’s not seeing imports like
import com.o3dr.services.android.lib.drone.connection.DroneSharePrefs;
@ne0fhyk does standalone require a build on dk-android?
Fredia Huya-Kouadio
@ne0fhyk
Sep 10 2016 19:06
no
though you can link it to your own build for dronekit-android if you plan to make some modifications to dk-android
Bill Bonney
@billbonney
Sep 10 2016 19:06
    //DroneKit-Android client lib
//    compile 'com.o3dr.android:dronekit-android:3.0.1'
    //Comment line above, and uncomment line below to use your local version of the dronekit-android client lib
    //Don't forget to uncomment the lines in the settings.gradle file as well.
     compile project(':ClientLib’)
Is this the only change to reference the local client lib?
Fredia Huya-Kouadio
@ne0fhyk
Sep 10 2016 19:07
the instructions for linking are in the settings.gradle file
Bill Bonney
@billbonney
Sep 10 2016 19:07
I do plan to make some changes to dk-android
Fredia Huya-Kouadio
@ne0fhyk
Sep 10 2016 19:08
okay, you can use the master or develop version of dk-android, they should be identical
Bill Bonney
@billbonney
Sep 10 2016 19:08
I’ve had this all building in previous 3DR servcies, but it’s the usual thing that I’ve forgotton the adnroid dev studi setup stuff. I’m getting there
Fredia Huya-Kouadio
@ne0fhyk
Sep 10 2016 19:08
but for tower you have to use the standalone branch
Bill Bonney
@billbonney
Sep 10 2016 19:08
ok
just doing tower branch change now
I was following the changes here to add the clientlib https://github.com/DroidPlanner/Tower/wiki/Work-with-DroneKit-Android
whcih worked for develop, but you have that different change in the code now
(see above)
Fredia Huya-Kouadio
@ne0fhyk
Sep 10 2016 19:11
both methods work. the first one you referenced is a bit faster since you can made modifications in dk-android and it'll be picked up right away by Tower instead of having to rebuild the .aar file
Bill Bonney
@billbonney
Sep 10 2016 19:11
How do I link in ClientLib project?
Fredia Huya-Kouadio
@ne0fhyk
Sep 10 2016 19:11
the compiling issue you ran into was because the DroneSharePrefs was removed from the latest version of dk-android
Bill Bonney
@billbonney
Sep 10 2016 19:12
is this also removed import org.droidplanner.android.droneshare.data.DroneShareDB;
Fredia Huya-Kouadio
@ne0fhyk
Sep 10 2016 19:12
to link in the ClientLib project, repeat the same change as the one above in Android/build.gradle
and in the settings.gradle file, there's a block you need to uncomment
and you need to indicate the path to your dk-android project.
no, DroneShareDB is available.
Bill Bonney
@billbonney
Sep 10 2016 19:14
That makes sense. just trying a build
Error:(290) Error: Fragments should be static such that they can be re-instantiated by the system, and anonymous classes are not static [ValidFragment]
SlideToUnlockDialog unlockDialog = new SlideToUnlockDialog() {
seems to produce an error
Fredia Huya-Kouadio
@ne0fhyk
Sep 10 2016 19:16
that error was fixed. are you sure you have the latest from github?
the SlideToUnlockDialog was abstract. It shouldn't be anymore.
Bill Bonney
@billbonney
Sep 10 2016 19:17
0730a845841d85e86f65ce2b1e1ca4adf790c870
at this commit
just checking
mmm
I’m still getting an error with the SlideToUnlockDialog class
In planeFlightControlFragment
I just did a clean build and rebuilt everything
Bill Bonney
@billbonney
Sep 10 2016 19:22
I need to pop out for 20mins, but i’ll take a look when I get back, but I have a build system working, just some minor issues it looks like with current changes.
@ne0fhyk thanks for help
Fredia Huya-Kouadio
@ne0fhyk
Sep 10 2016 19:23
no problem :)
if you're using android studio to switch branches, it might not be picking up the latest.
i usually do a git remote update on the terminal to make sure everything is up-to-date.
Bill Bonney
@billbonney
Sep 10 2016 19:24
ok
still getting this error
/Users/bonney/dev_src/tower/Tower/Android/src/org/droidplanner/android/fragments/control/PlaneFlightControlFragment.java
Error:(290) Error: Fragments should be static such that they can be re-instantiated by the system, and anonymous classes are not static [ValidFragment]
BRB
Fredia Huya-Kouadio
@ne0fhyk
Sep 10 2016 19:35
found the issue. The code in the PlaneFlightControlFragment had not been updated correctly
@billbonney I just push the fix to the standalone branch.
Bill Bonney
@billbonney
Sep 10 2016 19:54
@ne0fhyk great, thanks
Bill Bonney
@billbonney
Sep 10 2016 20:18
@ne0fhyk I am getting this build erro now
Tower/Android/res/values/arrays.xml:5: Error: "RCQuickModes" is not translated in "de" (German), "es" (Spanish), "fr" (French), "it" (Italian), "pt-BR" (Portuguese: Brazil), "zh-CN" (Chinese: China), "zh-TW" (Chinese: Taiwan) [MissingTranslation] <string-array name="RCQuickModes”>
Fredia Huya-Kouadio
@ne0fhyk
Sep 10 2016 20:19
it's a lint error. I get these as well, but it still build and upload to the device
Bill Bonney
@billbonney
Sep 10 2016 20:22
ok, a little confusing
Fredia Huya-Kouadio
@ne0fhyk
Sep 10 2016 20:30
i pushed an update to the standalone branch to disable the warnings.
Bill Bonney
@billbonney
Sep 10 2016 20:30
oh, cool
Fredia Huya-Kouadio
@ne0fhyk
Sep 10 2016 20:31
i did a couple of runs, and they don't show anymore in my builds, but let me know if you see them again
Bill Bonney
@billbonney
Sep 10 2016 20:37
cool, the only issue I have now is how to run the debug build
 Error running Android
         Cannot debug application from module Android on device samsung-sm_t310-4300c63a61027041.
         This application does not have the debuggable attribute enabled in its manifest.
         If you have manually set it in the manifest, then remove it and let the IDE automatically assign it.
         If you are using Gradle, make sure that your current variant is debuggable
Close, needed to select the Build VAriants
Bill Bonney
@billbonney
Sep 10 2016 21:50
@ne0fhyk I now have it building and installing, but crashes on startup. To get this far I had to download v1.7u80 of JDK install, and point the project to that version