These are chat archives for dropbox/pyston

7th
Aug 2015
Rudi Chen
@rudi-c
Aug 07 2015 18:35
@Daetalus Sorry for the late reply. Right now typing format in the interpreter throws ../../src/runtime/types.cpp:1485: pyston::BoxedString *builtinFunctionOrMethodRepr(pyston::BoxedBuiltinFunctionOrMethod *): Assertion `false' failed: builtinFunctionOrMethodRepr not properly implemented
That's why I meant.
Sun
@Daetalus
Aug 07 2015 18:39
That's ok.
Weird, format work fine with me, I just add complex support to format.
Never mind.
Sun
@Daetalus
Aug 07 2015 19:23

Quote from the comment in CPython float comparison function:

(Float)Comparison is pretty much a nightmare.

During add full support to complex, I realized that our float comparision seems need to complete rewrite.IMHO, it totally wrong... Just one case:

>>> a = 1.152921504606847e+18
>>> b = 1152921504606846977
>>> a == b
True

I decide to use copy CPython float comparision code. But it will let the PR get bigger. Should I to create a PR with some common complex functions first?

The code in above was run in Pyston. CPython will return False
Kevin Modzelewski
@kmod
Aug 07 2015 19:40
oh, yeah adopting the cpython comparison code is probably a good idea
sounds like a fun source of subtle bugs if we don't :)
it'd be nice to keep the changes separated if possible
Sun
@Daetalus
Aug 07 2015 19:40
Ok, thanks!