These are chat archives for dropbox/pyston

13th
Oct 2015
Kevin Modzelewski
@kmod
Oct 13 2015 00:04
hi @aisk, I think you need to enable the freeze() calls
we should probably have asserts that that gets called, since I guess it's necessary now
the assertion that's getting tripped inside freeze() is that there is no __dict__ descriptor that was added.
Sun
@Daetalus
Oct 13 2015 00:05
Hi @kmod #902 is ready to review.
Kevin Modzelewski
@kmod
Oct 13 2015 00:06
I'm not sure if our handling of this is right for now, but you should do AST_cls->giveAttr("__dict__", dict_descr); before calling AST_cls->freeze()
Sun
@Daetalus
Oct 13 2015 00:08
Also include #945
Kevin Modzelewski
@kmod
Oct 13 2015 00:29
do you know what that crash was that you were getting earlier?
for the readline change
Sun
@Daetalus
Oct 13 2015 00:33
Just rebase the file. Seems #947 and #948 fix the crash.
An Long
@aisk
Oct 13 2015 14:11
@kmod thx 😁 I'll try it latter.