These are chat archives for dropbox/pyston

30th
Mar 2016
Marius Wachtler
@undingen
Mar 30 2016 15:50
@kmod could you please help me with fixing exceptions_regressions.py (you need to have either the interpreter enabled or or set FORCE_LLVM_CAPI_CALLS to true.
the problem is that we call runtimeCallCapi and the refcounting inserter adds the decref before we do the NULL check on the return value --> SEGFAULT...
I tried setNullable(..., true) but I run into another assert with it and thought you may already know how I should fix this
Kevin Modzelewski
@kmod
Mar 30 2016 17:56
oh interesting
I don't think the refcounter should be adding the decref before the null check
let me take a look
oh, heh
it inserts it between the null-check and the branch-if-null
Kevin Modzelewski
@kmod
Mar 30 2016 18:01
I think setNullable sounds like a good solution
I just never implemented xdecref, which I assume is what the assert is
Kevin Modzelewski
@kmod
Mar 30 2016 18:21
ok, I just pushed an implementation of xdecref (in the llvm jit)
which seems to fix this particular case
turning on FORCE_LLVM_CAPI_CALLS causes a whole bunch of errors, I'm going to look into them
Kevin Modzelewski
@kmod
Mar 30 2016 18:50
ooh interesting we allow you to do type(None).__new__(type(None)) to create new None objects :)
Marius Wachtler
@undingen
Mar 30 2016 19:02
:-D