These are chat archives for dropbox/pyston

8th
May 2016
Dong-hee Na
@corona10
May 08 2016 03:42
Long time no see @kmod Can you review #1162 PR??
Wedzerai
@McWeda
May 08 2016 10:14
Hello World. Also new here. I managed to build pyston on ubuntu, but only after making small changes. I had to change source files src/runtime/{float.cpp, long.cpp, capi.cpp} to use std::isinf, and std::isnan (with std:: qualifier). In from_cpython/Include/pymath.h I tweaked the macro definition of Py_IS_INFINITY to test for __cpluspus.
#ifndef Py_IS_INFINITY
 #  if defined HAVE_DECL_ISINF && HAVE_DECL_ISINF == 1
-#    define Py_IS_INFINITY(X) isinf(X)
+#     if defined __cplusplus
+#         define Py_IS_INFINITY(X) std::isinf(X)
+#     else
+#         define Py_IS_INFINITY(X) isinf(X)
+#     endif
 #  else
 #    define Py_IS_INFINITY(X) ((X) &&                                   \
                                (Py_FORCE_DOUBLE(X)*0.5 == Py_FORCE_DOUBLE(X)))
I was wondering if I had missed something.
Dong-hee Na
@corona10
May 08 2016 10:15
Can you explain ubuntu version exactly?
Wedzerai
@McWeda
May 08 2016 10:16
It's Ubuntu 16.04
x86_64
Dong-hee Na
@corona10
May 08 2016 10:16
but also gcc version?
Wedzerai
@McWeda
May 08 2016 10:17
gcc version 5.3.1 20160413 (Ubuntu 5.3.1-14ubuntu2)
without the changes I was getting "../../src/runtime/float.cpp:1268:13: error: use of undeclared identifier 'isinf'
"
also "src/runtime/capi.cpp:511:13: error: use of undeclared identifier 'isinf'"
Dong-hee Na
@corona10
May 08 2016 10:20
hmm My gcc version is 4.8.4.. this is just my opinion. but this problem might be depends on compiler version problem. you could write fixed code and make PR.
Maintainers will review your code.
Wedzerai
@McWeda
May 08 2016 10:21
ok. thanks for the speedy reply
kchoi
@choikwa
May 08 2016 20:32
hi
Marius Wachtler
@undingen
May 08 2016 20:35
hi!
kchoi
@choikwa
May 08 2016 22:09
can I contribute?
Marius Wachtler
@undingen
May 08 2016 22:18
sure, we are always looking for new contributors :-)
here are some issues which may be a good start: https://github.com/dropbox/pyston/labels/probably%20easy
kchoi
@choikwa
May 08 2016 22:20
very cool
hm.. why does ninja need sudo
Marius Wachtler
@undingen
May 08 2016 22:23
currently we are still finishing up the refcounting stuff so there is much more on the refcounting branch going on than on master in case you are wondering why there are only a few new commits on master. But really soon the refcounting branch will be the new master :-) and than development should be more "normal" again ;-)
it should not need root permissions... normally we even run it through our makefile wrapper... are you following https://github.com/dropbox/pyston/blob/master/docs/INSTALLING.md ?
kchoi
@choikwa
May 08 2016 22:26
didnt see that
thanks
Marius Wachtler
@undingen
May 08 2016 22:27
it will take some time because you will need to build llvm+clang... (we need to apply some custom patches)
kchoi
@choikwa
May 08 2016 22:39
that's pretty large
kchoi
@choikwa
May 08 2016 22:49
I can't seem to build it
Marius Wachtler
@undingen
May 08 2016 23:03
what error do you get?
and what distribution?
Dong-hee Na
@corona10
May 08 2016 23:49
@choikwa If you hard to build it. use docker images which are not yet merged.
use #1148 or #1099
but if you want to contribute it you need to set user.email and user.name for your own both images are set anynomous