These are chat archives for dropbox/pyston

23rd
Jun 2016
Sun
@Daetalus
Jun 23 2016 18:03
What about set has_getattribute=true if (tp_getattro!=NULL || tp_getattr!=NULL) ? @undingen
Marius Wachtler
@undingen
Jun 23 2016 18:48
can't we just do?
            static BoxedString* getattribute_str = getStaticString("__getattribute__");
            if (p->name_strobj == getattribute_str) {
                if (type->tp_getattr == NULL && descr && descr->cls == &PyWrapperDescr_Type
                    && ((PyWrapperDescrObject*)descr)->d_wrapped == PyObject_GenericGetAttr)
                    descr = NULL;
            }
or was this what your recommended?
Sun
@Daetalus
Jun 23 2016 18:51
That's just my thought, I didn't know where to put the logic before. But I think you give me a choice.
Sun
@Daetalus
Jun 23 2016 20:11
I would be glad if the marius solution is acceptable.