These are chat archives for dropbox/pyston

6th
Oct 2016
An Long
@aisk
Oct 06 2016 04:29
Hi I found the master branch's code is broken on my machine
../../src/core/bst.cpp:1454:18: error: 'visit_deletesubslice' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
    virtual bool visit_deletesubslice(BST_DeleteSubSlice* node) {
Maybe I'm using a different version of compiler?
Seo Sanghyeon
@sanxiyn
Oct 06 2016 04:32
Probably. What is your compiler version?
An Long
@aisk
Oct 06 2016 04:32
Ubuntu clang version 3.6.0-2ubuntu1 (tags/RELEASE_360/final) (based on LLVM 3.6.0)
looks like the travis ci's clang version is 3.5
Kevin Modzelewski
@kmod
Oct 06 2016 05:49
sorry, yes that is broken on newer OSes, should be fixed soon
ok, should be fixed now on master. this is an annoying warning because I'm not sure how to have our CI help us spot these kinds of issues
An Long
@aisk
Oct 06 2016 05:54
Can we add a new CI target that uses newer version of clang / gcc for test?
Dong-hee Na
@corona10
Oct 06 2016 05:54
@kmod Can you review #1382 ?
Marius Wachtler
@undingen
Oct 06 2016 09:01
@kmod thanks for fixing the missing overrides, I thought I found all missing ones but did check with a new compiler
Marius Wachtler
@undingen
Oct 06 2016 09:27
@corona10 I'm not kmod but I thought I would review it so that you don't have to wait until kmod comes online
unfortunately I don't think we should merge this :-(
Dong-hee Na
@corona10
Oct 06 2016 10:41
@undingen I read your review thanks! I close my PR. :-)
Marius Wachtler
@undingen
Oct 06 2016 10:44
thanks :-)