These are chat archives for dry-rb/chat

15th
Feb 2017
Piotr Solnica
@solnic
Feb 15 2017 04:17
@gotar I think I know why you had issues with instrumentation patch in rom, you basically can’t boot!(:rom) too early, otherwise patch won’t be applied before your relations are built
Oskar Szrajer
@gotar
Feb 15 2017 07:41
yeah i assume it's condition problem, is there a way to force order, like in rom force loading monit first? maybe in init?
@solnic
for now i just add:
        notifications ||= Athit::Container[:notifications]
        notifications.instrument(:sql, name: name.relation, query: dataset.sql) do
          super
        end
works, but it's ugly hack
Oskar Szrajer
@gotar
Feb 15 2017 07:49
:facepalm: ok fixed ;]
there is just use :monitor missing in rom boot file (init section)
@timriley @solnic
so probably should be added to dry-web-roda geenrator too
thx guys for help
Oskar Szrajer
@gotar
Feb 15 2017 08:00
@timriley I already add those missing line to dry-web-roda skeleton apps
Tim Riley
@timriley
Feb 15 2017 10:16
@gotar oh! Would you mind PR-ing this? I'll add you as a contributor if you're not already, too.
Oskar Szrajer
@gotar
Feb 15 2017 10:18
I put this automaticaly on master branch (for mistake ;P) hope you don't mind
specs do not catch this problem with monitor because non of them use db
Piotr Solnica
@solnic
Feb 15 2017 10:20
@gotar well first of all I need to add notifications support to rom, so that we don’t have a monkey patch :)
I’ve got it in a local branch, I’ll push this tomorrow
Tim Riley
@timriley
Feb 15 2017 10:35
@gotar oh no worries, master is good. I actually want to add some specs that generate an app and add enough files to set up a persistence layer, just to test that all works properly
Oskar Szrajer
@gotar
Feb 15 2017 10:40
now should all works
probably there is not to much users of those skeletons but I use them for every app ;]
Tim Riley
@timriley
Feb 15 2017 10:46
😎