These are chat archives for dry-rb/chat

27th
Feb 2017
Pablo Herrero
@pabloh
Feb 27 2017 13:48
@rx have you considering releasing the gem?
John Backus
@backus
Feb 27 2017 20:02
@flash-gordon @solnic FYI dry-rb/dry-struct#31 -> Class.new(Dry::Struct::Value) # => TypeError: no implicit conversion of nil into Hash
Seems like a show stopper
Piotr Solnica
@solnic
Feb 27 2017 20:07
Damn
How is it possible that specs passed ;)
John Backus
@backus
Feb 27 2017 20:09
There are things in the specs that inherit from Dry::Struct::Value
I was wondering the same thing since I helped port them from dry-types
Nikita Shilnikov
@flash-gordon
Feb 27 2017 20:09
hm, so I'm gonna fix it
rake spec doesn't run value's specs
for some reason
Nikita Shilnikov
@flash-gordon
Feb 27 2017 20:18
hm, or does, interesting
Piotr Solnica
@solnic
Feb 27 2017 20:20
o_O
John Backus
@backus
Feb 27 2017 20:23
@flash-gordon I think this test sets @schema on Dry::Struct::Value https://github.com/dry-rb/dry-struct/blob/master/spec/dry/types/struct_spec.rb#L147-L150
which is why the later ones pass
if you freeze Dry::Struct::Value in the spec helper then the struct tests properly fail and that test fails also
Nikita Shilnikov
@flash-gordon
Feb 27 2017 20:28
@backus wait a sec, I found something
this is why it's not working, but I still don't get why it's not failing
@backus aah, you were right
that specs changes the state, dammit
we need a random order in specs
Nikita Shilnikov
@flash-gordon
Feb 27 2017 20:46
@solnic @backus I pushed the fix, waiting for the specs to pass on Travis
with order = :random the problem showed up
Gustavo Caso
@GustavoCaso
Feb 27 2017 20:47
Woow @flash-gordon quick fix thanks :+1:
Nikita Shilnikov
@flash-gordon
Feb 27 2017 20:50
np ;)
Nikita Shilnikov
@flash-gordon
Feb 27 2017 21:01
@solnic @backus can you push the gem? I bumped the version and travis says it's green
Piotr Solnica
@solnic
Feb 27 2017 21:15
As soon as my son goes finally to sleep, yes
;)
Don Morrison
@elskwid
Feb 27 2017 22:44
:baby: :zzz: