These are chat archives for dry-rb/chat

3rd
May 2017
Piotr Solnica
@solnic
May 03 2017 08:45
@flash-gordon I’d like to revisit hash schema implementation in dry-types, and try to figure out a more flexible way for setting them up. This was brought up before by @Kukunin I believe, I was initially against it, but we start to see more use cases where a more flexible solution would be very useful. /cc @backus
ie now we need a symbolized hash which has strict semantics too, and we’re stuck :)
this is definitely something to figure out before 1.0.0
if we can come up with a flexible solution which is also fast, that would be awesome. Oh and the lib should still provide a bunch of common, built-in hash schema types
@apotonick I’ll let you know once I have something working with the new dry-v + dry-schema, and re rom, I reported an issue about reform/rom integration so we can discuss things there I guess
Sergey Kukunin
@Kukunin
May 03 2017 11:43
@flash-gordon I have a crash on latest master of dry-struct. on the first attribute call.
equalizer.instance_variable_get('@keys').concat(new_schema.keys)
NoMethodError: undefined method `concat' for nil:NilClass
  /Users/kukunin/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/dry-struct-fbe71e6445a8/lib/dry/struct/class_interface.rb:78:in `attributes'
  /Users/kukunin/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/dry-struct-fbe71e6445a8/lib/dry/struct/class_interface.rb:50:in `attribute'
  /Users/kukunin/Sites/matic-www/gems/shift-domain/lib/shift/domain/attachment.rb:8:in `block in <module:Domain>'
Nikita Shilnikov
@flash-gordon
May 03 2017 11:44
@Kukunin I think you need dry-core from master, check it out
Sergey Kukunin
@Kukunin
May 03 2017 11:44
thanks. going to try
yep. that's the reason. thanks
any plans to release dry-struct 0.2.2 with minor changes?
it seems that major changes are coming (already in master)
Nikita Shilnikov
@flash-gordon
May 03 2017 11:49
nope, I'll release 0.3, soon. Bumping dry-core will require releasing rom as well, takes some time...
Sergey Kukunin
@Kukunin
May 03 2017 11:52
what's about releasing dry-rb/dry-struct@bfc867e commit as 0.2.2?
and next release will be 0.3
Nikita Shilnikov
@flash-gordon
May 03 2017 11:53
too late :) I don't have time for this
Sergey Kukunin
@Kukunin
May 03 2017 11:53
ok. looking forward 0.3 version =)
you're doing great job, though. thanks
Nikita Shilnikov
@flash-gordon
May 03 2017 11:57
@Kukunin it's about today/tomorrow I hope
Sergey Kukunin
@Kukunin
May 03 2017 11:58
:+1: