What would be the best/easiest to mock the result of a
Dry::Transcation::Operation when it returns a block?Operation.new.call(arg) do |result|
result.success { ... }
result.failure { ... }
end
@pablocrivella are you using rspec?
Yes
too bad your operation is not injected and you manually instantiate it
this makes mocking it harder
I will try the injected version ASAP then :)
Is it still possible to inject a operation, even if i’m using inside other operation:
i.e:
class CheckAccess
include Dry::Transaction::Operation
def call(user)
return Success(user.licenses.first) if active_license_for?(user)
check_purchase = CheckPurchase.new
check_purchase.call(user.purchases.first) do |result|
result.success do |purchase|
Success(purchase)
end
result.failure do
if user.on_trial?
Success(Trial.new(user: user))
else
Failure(user)
end
end
end
end
private
def active_license_for?(user)
user.licenses.first_or_initialize.active?
end
end
I prefer not using that block syntax at all. It’s a kind of dry-matcher Class enhancement.
I think it’s just a sugar-syntax that’s hard to write tests.
Just use normal Result matcher.
Or better, with the nature of your code, use Do notation
I think it’s just a sugar-syntax that’s hard to write tests.
Just use normal Result matcher.
Or better, with the nature of your code, use Do notation
In that context I personally would just use the plain Result API
check_purchase.call(user.purchases.first).or {
if user.on_trial?
Success(Trial.new(user: user))
else
Failure(user)
end
}
@pablocrivella also, that
check_purchase operation cannot injected given you hard code its initialization in the call method
if you want it to be an injected dependency, you need to pass it to initialize
e.g.
def initialize(check_purchase:)
@check_purchase = check_purchase
end
Then you can use it from inside
#call and also inject a test double during your tests
@pablocrivella https://www.rubypigeon.com/posts/dependency_injection_containers_vs_hardcoded_constants/ may be a helpful read for you
Thanks @timriley ! I’ll take a look
There is not something similar to
include Dry::Transaction(container: Container) for Operations right? Is that a flaw on my desing? should operations not depend on other operations as a common practice?