Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 09:29

    solnic on master

    Clear exception message when an… Add gem names to plugins Merge pull request #128 from sk… (compare)

  • 09:29
    solnic closed #128
  • 09:29
    solnic closed #127
  • Dec 04 18:49
    micahphone starred dry-rb/dry-monads
  • Dec 04 17:43
    icy-arctic-fox starred dry-rb/dry-types
  • Dec 02 12:37
    pedrofurtado starred dry-rb/dry-view
  • Dec 02 11:59
    lenon starred dry-rb/dry-monads
  • Dec 01 11:06

    flash-gordon on declare-finalized

    (compare)

  • Dec 01 11:06

    flash-gordon on master

    Set initial value for ivar Merge pull request #131 from dr… (compare)

  • Dec 01 11:06
    flash-gordon closed #131
  • Dec 01 11:05
    flash-gordon opened #131
  • Dec 01 11:03

    flash-gordon on declare-finalized

    Set initial value for ivar (compare)

  • Nov 30 16:50
    paul commented #32
  • Nov 30 16:50
    paul synchronize #32
  • Nov 30 16:44
    paul synchronize #32
  • Nov 30 16:02
    paul synchronize #32
  • Nov 30 16:01
    paul commented #32
  • Nov 30 12:12

    flash-gordon on master

    Use GH badge for CI status (compare)

  • Nov 30 12:08

    dry-bot on master

    [devtools] config sync (compare)

Hannes Nevalainen
@kwando
a hash
Krzysztof Wawer
@wafcio
ok but can you give example how this hash looks ?
Hannes Nevalainen
@kwando
though the input is not there problem, it blows up when compiling the rules
the* problem
/dry-validation-185ec9d6959d/lib/dry/validation/rule_compiler.rb:48:in `visit_and': undefined method `&' for #<Dry::Validation::Rule::Conjunction:0x007fc95b01ef10> (NoMethodError)
Krzysztof Wawer
@wafcio
in 0.1.0 I don’t have this problem
Hannes Nevalainen
@kwando
ok, I use master.. probably not a very good idea =P
Krzysztof Wawer
@wafcio
I am not fun of using version from master because it can be unstable. For me stable versions are tagged versions
Hannes Nevalainen
@kwando
I do not really think there is a "stable" version yet though =P
Piotr Solnica
@solnic
@kwando there was an issue with nil? predicate, I had to rename it to none? to avoid conflicts with the built-in nil? method on Object
btw I just added support for optional values
Hannes Nevalainen
@kwando
Dry::Rule::Composite is missing & | methods
Piotr Solnica
@solnic
so ie key(:age) { |age| age.none? | (age.int? & age.gt?(18)) } this is translated to a coercion that will turn empty strings to nils
in Schema::Form
this is an explicit way of handling nil and optional values
@kwando oh, lemme fix that
I need to do it properly though, we have a very specific rule interface but I haven’t added shared specs for that, so we have some holes like you found :)
lemme brew some coffee and fix this situation :)
btw thanks guys for testing this so early, I appreciate that a lot <3
Hannes Nevalainen
@kwando
np really, thanks for "fixing" ruby =) <3
Piotr Solnica
@solnic
@kwando I’m afraid I can’t fix that part, my C skills don’t exist :joy:
@kwando anyhow, I can’t repro issue with missing & and | in composite
it inherits from Rule so it has these interfaces
@kwando do you have a repro?
Hannes Nevalainen
@kwando
hmm, I must have used a old version somehow =S
173a2e407ff9e652c3cb26932474375f5bcfa482 had the error
Hannes Nevalainen
@kwando
@solnic sneaky, you fixed it while splitting rules to separate files =P
Piotr Solnica
@solnic
@kwando huh?
oh lol
I know what happened
composite class def was before methods on abstract rule were defined
now it’s after
lol :)
well, at least I added missing specs :)
Piotr Solnica
@solnic

[√] support for built-in form coercions based on type-check predicates
[√] support for optional keys
[√] support for optional values
[√] support for passing a block to predicates in dsl

^^ @kwando @wafcio gonna release those features today :)

Andy Holland
@AMHOL
Piotr Solnica
@solnic
@AMHOL no, I didn’t see it :/
Andy Holland
@AMHOL
Ahh OK
It just removes messages and adds a compiler for returning an errors hash
So messages/i18n would become an external concern
Piotr Solnica
@solnic
@AMHOL error hash?
Andy Holland
@AMHOL
Yeah, like: { attribute: [{code: :gt?, value: 1, options: { num: 3 }}] }
Wanted to see what you thought about it before I did anything more with it
Just seems weird to me for a validation library to load yaml files and stuff
Piotr Solnica
@solnic
nested hashes will be more difficult to process. I'm also not sure if making the assumption that errors are always "attached" to a specific attribute will turn out to be correct in the longer term
Andy Holland
@AMHOL
Ahh OK
Hannes Nevalainen
@kwando
@solnic I'm struggling a bit on how to do something similar to this with dry-data and dry-validation. https://gist.github.com/kwando/9663d5781e34ee82a8f8
Hannes Nevalainen
@kwando
Same thing but with dry components --> https://gist.github.com/kwando/01ff386521d46a432ebe
Piotr Solnica
@solnic
@kwando @timriley input-type compiler is not finished, please gimme a day or two...
Hannes Nevalainen
@kwando
Oh, I'm not complaining! Just feeding you one of my use cases =)