so my opinion about dry-validation - it has freaky error format: sometime I see
errors = schema.call(email: 'jane@doe.org', age: 17).messages
puts errors.inspect
# { :age => [["age must be greater than 18"], 17] }another time I see
errors = schema.call(email: nil, age: 19).messages
puts errors.inspect
# { :email => [["email must be filled", nil]] }I caused that I droped dry-validation today.
maybe I will back to dry-validation when I will have more time
and when I saw
[[„invalid”, nil]]
I said WHAT ???
invalid was my translation message
first array includes compiled error messages, the second argument is the original input value
[[…, …], …]
I said not today
error messages can be compiled to anything, I just used a simple hash for now as the default but it can be literally anything, it’s a pluggable “behavior” in dry-v
like it was in 0.1.0 version
displaying these errors is still pretty simple though, not sure why it has put you off :)
errors.each { |attribute, (messages, _)| … } or something
I will try to repro and fix
maybe README is old
ok
I’ll try to fix it later today or tomorrow
good news people, "validation hints” landed on master, here’s a higher-level spec which shows current behavior, seems innocent but it’s pretty crucial - we provide all validation messages even though not all predicates are being applied (because it makes no sense). This is the very first step. Soon I’ll start experimenting with optimizations like dropping some messages when other have higher priority and expose an interface to provide your own optimization rules so that validation messages will not have redundant information.
@AMHOL @kwando I can haz some feedback? ^
it’s a pretty big addition
I'll take the red pill