Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Feb 26 16:22
    karpinovsky starred dry-rb/dry-auto_inject
  • Feb 26 16:22
    karpinovsky starred dry-rb/dry-container
  • Feb 26 16:22
    karpinovsky starred dry-rb/dry-matcher
  • Feb 26 16:22
    karpinovsky starred dry-rb/dry-monads
  • Feb 26 16:22
    karpinovsky starred dry-rb/dry-initializer
  • Feb 26 16:21
    karpinovsky starred dry-rb/dry-system
  • Feb 26 16:21
    karpinovsky starred dry-rb/dry-types
  • Feb 26 14:03
    solnic commented #143
  • Feb 26 13:19
    davydovanton commented #143
  • Feb 26 13:04
    solnic commented #143
  • Feb 25 23:58
    davydovanton review_requested #143
  • Feb 25 23:56
    davydovanton synchronize #143
  • Feb 25 23:56

    davydovanton on strategies-fail

    Fix error with mutation of froz… (compare)

  • Feb 25 22:40
    davydovanton review_requested #143
  • Feb 25 22:40
    davydovanton review_requested #143
  • Feb 25 22:40
    davydovanton assigned #143
  • Feb 25 22:40
    davydovanton opened #143
  • Feb 25 22:40
    davydovanton review_requested #143
  • Feb 25 22:40
    davydovanton labeled #143
  • Feb 25 22:34

    davydovanton on strategies-fail

    Fix error with mutation of froz… (compare)

Piotr Solnica
@solnic
I put it there because it’s useful for cases like each rule and figuring out the index of a given value when it comes from an array
displaying these errors is still pretty simple though, not sure why it has put you off :)
errors.each { |attribute, (messages, _)| … } or something
Krzysztof Wawer
@wafcio
I don’t understand why there is two different format: { :age => [["age must be greater than 18"], 17] } and { :email => [["email must be filled", nil]] }
Piotr Solnica
@solnic
two formats?
Krzysztof Wawer
@wafcio
[[…], …] and [[…, …]]
Piotr Solnica
@solnic
oh, now THAT seems like a bug :joy:
I will try to repro and fix
Krzysztof Wawer
@wafcio
I read it from README file
maybe README is old
Piotr Solnica
@solnic
maybe I made a mistake writing readme, that’s more likely :)
Krzysztof Wawer
@wafcio
ok
Piotr Solnica
@solnic
lemme see
Krzysztof Wawer
@wafcio
so I will give chance dry-validation, again :)
Piotr Solnica
@solnic
yeah, it’s a bug, I’ll fix it and push a release
Krzysztof Wawer
@wafcio
I wanted switch to dry-validation in 0.1.0 version, but like I said some time aga in 0.1.0 we dry-validation didn’t have optional keys
ok
Piotr Solnica
@solnic
uhm, it’s pretty messed up right now, no wonder it got you confused
I’ll try to fix it later today or tomorrow
Piotr Solnica
@solnic
@wafcio I fixed that issue we talked about yesterday with error messages hash structure. it’s in master
Piotr Solnica
@solnic
good news people, "validation hints” landed on master, here’s a higher-level spec which shows current behavior, seems innocent but it’s pretty crucial - we provide all validation messages even though not all predicates are being applied (because it makes no sense). This is the very first step. Soon I’ll start experimenting with optimizations like dropping some messages when other have higher priority and expose an interface to provide your own optimization rules so that validation messages will not have redundant information.
Piotr Solnica
@solnic
dryrb/dry-validation#40
@AMHOL @kwando I can haz some feedback? ^
it’s a pretty big addition
Andy Holland
@AMHOL
:joy:
I'll take the red pill
Piotr Solnica
@solnic
haha
Hannes Nevalainen
@kwando
@solnic niceness! I'll have to use it before I can have better feedback =)
Hannes Nevalainen
@kwando
dry-validation for validating ENV on boot => friendly error messages <3
Piotr Solnica
@solnic
Yep. One of the many use cases

validateallthethings

Whoops
Hannes Nevalainen
@kwando
markdown =P
Piotr Solnica
@solnic
Hashtag goes wrong ;)
Andy Holland
@AMHOL

hashtaggoeswrong

Chris Richards
@cmrichards
Hey solnic, thanks for all your work on Virtus
Piotr Solnica
@solnic
@cmrichards hey, my pleasure, although I’m no longer working on it ;)
Chris Richards
@cmrichards
I know, that's why I'm saying thanks!
Any idea when dry-data and dry-validation will be ready enough to use in place of Virtus?
@solnic
Piotr Solnica
@solnic
depends on what you need :)
I stopped using virtus already fwiw
philosophy is quite different than in virtus
so it requires a different approach
which is why it cannot be treated as a replacement
Chris Richards
@cmrichards
@solnic I use Virtus only for web forms in rails. I include activerecord validations. It works perfectly.
It's hard to imagine anything simpler
Piotr Solnica
@solnic
really? dry-data/validation is not just simpler but more powerful :D
Chris Richards
@cmrichards
Great, i'll try it.
Piotr Solnica
@solnic
I'm wrapping up stuff for dry-v 0.4.0