dry-rb/chat

WE MOVED TO ZULIP => https://dry-rb.zulipchat.com <=

Simon Schmid

@sled

are incomplete types possible e.g if I set some attributes as optional with a default, do I have to pass the key in the initializer e.g ModelType.new({optional_field: nil}) vs ModelType.new

Piotr Solnica

@solnic

@sled it’s being discussed how structs should work wrt optional attrs dry-rb/dry-types#72

currently you need constructor_type(:schema) to be set for optional types with default values to be set when sth is missing

Simon Schmid

@sled

thx! now I just have to bend rails to re-load my types correctly :D

Piotr Solnica

@solnic

@sled see dry-types-rails

Simon Schmid

@sled

yes but this seems broken

just read the conversation here in gitter

Piotr Solnica

@solnic

ah damn

Simon Schmid

@sled

yep, not the first time rails breaks my balls ;)

I think the issue is the "registry" of the container is not re-loaded properly

Piotr Solnica

@solnic

could be it

I don’t use rails at the moment so I’m not looking into it

Simon Schmid

@sled

sure I'm trying to fix it on my own

after reloading it tells me Dry::Container::Error: There is already an item registered with the key "customer.types.address"

Andy Holland

@AMHOL

@sled can you post your dry-types related code in a gist?

Simon Schmid

@sled

@AMHOL uhm for the reloading?

Andy Holland

@AMHOL

Nah just interested in how you're using it

I think calling

module Types
  include Dry::Types.module
end

in an initializer

Then defining your custom types somewhere in the app/lib directory should stop the problem from happening

Simon Schmid

@sled

I'll try right away :)

https://gist.github.com/sled/954be0a9e749a4036cc8e6bee614339d

I also noticed there are no setters, do you have any best practices on how to modify certain attributes easily?

the one I came up with is Hypo::Types::Location.new(original.to_h.merge(phone_number: '123456'))

Andy Holland

@AMHOL

Yeah, mutable structs won't be added to dry-types core

Piotr Solnica

@solnic

we deliberately fight with mutability

(so dramatic)

Andy Holland

@AMHOL

@sled see https://github.com/dry-rb/dry-types/issues/72#issuecomment-207108282

Simon Schmid

@sled

@solnic, I totally support that - however it's still nice to have an easy way of creating a copy with the modifications

might be a cool case for keyword arguments

Simon Schmid

@sled

@AMHOL just tried with the initializer and putting custom types into app/lib, however if I auto-load these paths it fails with the same error

Andy Holland

@AMHOL

Ahh shit, yeah

Forgot types get registered automatically when you inherit from Struct

Simon Schmid

@sled

yep I think I need to "reset" the container's registry somehow

Piotr Solnica

@solnic

related ^^

that’s from Programming Clojure book but it’s a universal truth

Dung Nguyen

@mmeeoorroo

I have Product and Category, both are Types::Struct
Product has a field with Category type. How can we make that field nullable so that I don't have to join/query categories table?

Simon Schmid

@sled

attribute :category, Category.optional :D

just learned today

Dung Nguyen

@mmeeoorroo

thanks but I get error 'NoMethodError: undefined method `optional' for Category:Class' :D

Simon Schmid

@sled

is your category a type?

Dung Nguyen

@mmeeoorroo

class Category < Dry::Types::Struct; end

class Product < Dry::Types::Struct
attribute :category, Category.optional
end

is that correct?

Simon Schmid

@sled

mh... another guess: attribute :category, Types::Strict::Nil | Category

(I'm still learning too)

Dung Nguyen

@mmeeoorroo

still not work, I will learn more :D

thanks @sled

Simon Schmid

@sled

@mmeeoorroo actually the one with | works for me

ah nope

Where communities thrive

People

Repo info

Activity