Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Nov 10 21:35
    pregozgin starred dry-rb/dry-monads
  • Nov 10 12:22
    flash-gordon opened #371
  • Nov 10 12:22

    flash-gordon on no-rewrap-for-structs

    Don't build constructors when c… (compare)

  • Nov 08 06:56
  • Nov 08 01:12

    AMHOL on master

    Fix gem metadata URIs (compare)

  • Nov 07 22:01
    orien edited #20
  • Nov 07 21:58

    flash-gordon on master

    Add project metadata to the gem… Merge pull request #20 from ori… (compare)

  • Nov 07 21:58
    flash-gordon closed #20
  • Nov 07 21:58
    flash-gordon commented #20
  • Nov 07 21:51
    orien opened #20
  • Nov 07 21:44
  • Nov 07 19:56

    flash-gordon on master

    Update CHANGELOG (compare)

  • Nov 07 19:54

    flash-gordon on fix-keyword-warnings

    (compare)

  • Nov 07 19:54

    flash-gordon on master

    Fix keyword warnings This chan… Merge pull request #114 from dr… (compare)

  • Nov 07 19:54
    flash-gordon closed #114
  • Nov 07 19:53
    flash-gordon opened #114
  • Nov 07 19:53

    flash-gordon on fix-keyword-warnings

    Fix keyword warnings This chan… (compare)

  • Nov 07 19:40
    Travis dry-rb/dry-view (master) errored (634)
  • Nov 07 19:37
    Travis dry-rb/dry-view (master) errored (633)
Piotr Solnica
@solnic
this would be a good improvement, i thought about it already but didn't bother as I was focused more on dry-v
it even crossed my mind to make it auto-curry like in rom relations but thought I won't do it since I don't have an immediate use-case yet
Chris Richards
@cmrichards
Hey. Dry-validation will tell me if my form params are valid, but how would I then create an object representing the form that has attributes with the correct types?
Luca Guidi
@jodosha
@solnic @timriley @fran-worley @AMHOL @tak1n here's the PR that integrates dry-validation with hanami-validations: hanami/validations#100 :100: - It will land in master next week, the release will happen after dry-v 0.8. Thank you all for your support! :green_heart: :blue_heart: :yellow_heart:
Fran Worley
@fran-worley
@jodosha looks great! :thumbsup:
@timriley @solnic Any objections to merging dry-rb/dry-validation#155 into master ?
Luca Guidi
@jodosha
:)
Piotr Solnica
@solnic
@fran-worley looks good
Fran Worley
@fran-worley
@solnic I'd love to have your thoughts on this: dry-rb/dry-logic#13
Piotr Solnica
@solnic
I'll check it out later today, busy working atm
Fran Worley
@fran-worley
@solnic no worries, I have to say now that I actually understand how the gem works I love it even more. :smiley_cat:
Piotr Solnica
@solnic
oh thanks :)
Fran Worley
@fran-worley
It really is rather clever!
(not that I was expecting anything less!)
Piotr Solnica
@solnic
I'm glad you liked it, I hope it's not that bad-type-of-clever though ;)
Fran Worley
@fran-worley
I don't think so, it is a bit hard to follow in places because there are no comments anywhere but I think I get it now!
Piotr Solnica
@solnic
sorry about that, I stopped writing yard comments in early-stage projects
the only really complex part is dealing with results, the rest is pretty simple
the good part though, is that we can continue improving it separately from types and validation, as long as ast stays the same we don't have to update validation/types
there are two things we rely on, ast format and result api, in dry-v a schema result implements logic's result api
Fran Worley
@fran-worley
@solnic it really was a stroke of genius to separate it. I am starting to use it to process non validation rules.
I had written something myself but it was not nearly as elegant or powerful
Piotr Solnica
@solnic
I can't wait to implement dry-v's equivalent in Clojure with 50LOC :laughing:
Piotr Solnica
@solnic
@fran-worley yeah this is a general purpose library, I'm pretty sure I will use it in other places too
Don Morrison
@elskwid
Now we just need to figure out how to get the big-refactors and other stuff out of Piotr’s head and into issues so we can help. :wink:
Fran Worley
@fran-worley
@solnic I think it's safe to say that changing the ast is a breaking change...
Finished in 6.18 seconds (files took 0.9631 seconds to load)
2256 examples, 1040 failures, 68 pending
Piotr Solnica
@solnic
@fran-worley yes it is
@fran-worley but this change isn't a big one, should be simple to fix
Phil Schalm
@pnomolos
For anyone using dry-types with Rails, dry-types-rails 0.3.0 was just released, which should (hopefully) solve a bunch of issues with using custom types in development :) https://rubygems.org/gems/dry-types-rails/
Thanks to @jeromegn and @AMHOL in making it happen
Andy Holland
@AMHOL
:+1: Nice one
Phil Schalm
@pnomolos
I am aware of issues if you have tendencies to mash reload and edit really rapidly (likely a race condition) but I don’t know if I’m going to bother fixing that. The better fix is to drink less coffee and calm down ;)
Andy Holland
@AMHOL
lol
Probably needs a mutex around the REGISTERED_TYPES stuff?
Phil Schalm
@pnomolos
I’m not sure, it actually may be a race condition with respect to the reloading code, since we’re doing the type re-registration out-of-band (only after ActiveSupport::Dependencies has completed its reload cycle)
I’ll try adding a mutex, though, to see if that fixes the problem
Nikita Shilnikov
@flash-gordon
@solnic apparently dry-v's cache machinery revealed a bug in jruby Array#hash which leads to collisions. I think it's one more proof that dry-v approach is very fresh :) Btw I tried to get collisions for symbols introduced by calling #hash and found that it's quite likely to have a few collisions on 100k random symbols (different chars & length) on jruby. So probability is actually low but issues are not impossible. Things are better on MRI and rubinius because #hash results has 2 ^ 64 variants against 2 ^ 32 in jruby. I don't think we should do anything about it right know, it's JFYI
oh, and Charles broke Array#hash quite badly in master trying to fix collisions :) Thus dry-v broke jruby eventually
Piotr Solnica
@solnic
@flash-gordon thanks for following up on this. I actually did see issues with this on rbx as well
Re caching, I'm trying to identify places where behavior can be pure and cache as much as possible and yes, it is a fresh approach :)
Joe Van Dyk
@joevandyk
Andrew Kozin
@nepalez
What is the policy for gems plugins like this one https://github.com/nepalez/dry-initializer-rails ? Do we want them to be reposited at dry-rb?
Piotr Solnica
@solnic
@nepalez yes assuming that one of dry-rb team members is willing to maintain it
Andrew Kozin
@nepalez
one more question. I've updated docs for dry-initializer at dry-rb.org. How could I publish those updates?
Tim Riley
@timriley
@nepalez bundle exec middleman deploy :)
Andrew Kozin
@nepalez
@timriley thanks! will made a try
Tim Riley
@timriley
Let me know how it goes!
Andrew Kozin
@nepalez
@timriley
/dry-rb.org $ bundle exec middleman deploy
/home/nepalez/.rvm/gems/ruby-2.3.0/gems/middleman-blog-4.0.0/lib/middleman-blog/blog_data.rb:170: warning: key :lang is duplicated and overwritten on line 170
== Executing: `./node_modules/webpack/bin/webpack.js --bail`
== External: Command failed with message: No such file or directory - ./node_modules/webpack/bin/webpack.js
Tim Riley
@timriley
OK, so you’ll want to see if the whole thing works locally first
Andrew Kozin
@nepalez
yes