Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 00:58
    dteoh starred dry-rb/dry-types
  • Nov 17 21:02
    flash-gordon commented #374
  • Nov 17 21:01

    flash-gordon on master

    Update custom_ci.yml Merge pull request #374 from sk… (compare)

  • Nov 17 21:01
    flash-gordon closed #374
  • Nov 17 20:59
    skryukov opened #374
  • Nov 17 16:42

    flash-gordon on use-immutable-equalizer

    (compare)

  • Nov 17 16:42

    flash-gordon on master

    Use immutable equalizer for all… Merge pull request #373 from dr… (compare)

  • Nov 17 16:42
    flash-gordon closed #373
  • Nov 17 16:38
    flash-gordon opened #373
  • Nov 17 16:38

    flash-gordon on use-immutable-equalizer

    Use immutable equalizer for all… (compare)

  • Nov 17 16:34

    flash-gordon on no-rewrap-for-structs

    (compare)

  • Nov 17 16:34

    flash-gordon on master

    Don't build constructors when c… Merge pull request #371 from dr… (compare)

  • Nov 17 16:34
    flash-gordon closed #371
  • Nov 16 11:28
    marekciupak starred dry-rb/dry-monads
  • Nov 16 07:48
    luizfonseca starred dry-rb/dry-view
  • Nov 15 18:52
    waiting-for-dev commented #114
  • Nov 15 16:06
    businessBoris starred dry-rb/dry-system
  • Nov 15 15:16
    businessBoris starred dry-rb/dry-monads
  • Nov 15 08:22
    gruz0 starred dry-rb/dry-types
  • Nov 14 12:03
    pedrofurtado starred dry-rb/dry-matcher
Piotr Solnica
@solnic
I'm glad you liked it, I hope it's not that bad-type-of-clever though ;)
Fran Worley
@fran-worley
I don't think so, it is a bit hard to follow in places because there are no comments anywhere but I think I get it now!
Piotr Solnica
@solnic
sorry about that, I stopped writing yard comments in early-stage projects
the only really complex part is dealing with results, the rest is pretty simple
the good part though, is that we can continue improving it separately from types and validation, as long as ast stays the same we don't have to update validation/types
there are two things we rely on, ast format and result api, in dry-v a schema result implements logic's result api
Fran Worley
@fran-worley
@solnic it really was a stroke of genius to separate it. I am starting to use it to process non validation rules.
I had written something myself but it was not nearly as elegant or powerful
Piotr Solnica
@solnic
I can't wait to implement dry-v's equivalent in Clojure with 50LOC :laughing:
Piotr Solnica
@solnic
@fran-worley yeah this is a general purpose library, I'm pretty sure I will use it in other places too
Don Morrison
@elskwid
Now we just need to figure out how to get the big-refactors and other stuff out of Piotr’s head and into issues so we can help. :wink:
Fran Worley
@fran-worley
@solnic I think it's safe to say that changing the ast is a breaking change...
Finished in 6.18 seconds (files took 0.9631 seconds to load)
2256 examples, 1040 failures, 68 pending
Piotr Solnica
@solnic
@fran-worley yes it is
@fran-worley but this change isn't a big one, should be simple to fix
Phil Schalm
@pnomolos
For anyone using dry-types with Rails, dry-types-rails 0.3.0 was just released, which should (hopefully) solve a bunch of issues with using custom types in development :) https://rubygems.org/gems/dry-types-rails/
Thanks to @jeromegn and @AMHOL in making it happen
Andy Holland
@AMHOL
:+1: Nice one
Phil Schalm
@pnomolos
I am aware of issues if you have tendencies to mash reload and edit really rapidly (likely a race condition) but I don’t know if I’m going to bother fixing that. The better fix is to drink less coffee and calm down ;)
Andy Holland
@AMHOL
lol
Probably needs a mutex around the REGISTERED_TYPES stuff?
Phil Schalm
@pnomolos
I’m not sure, it actually may be a race condition with respect to the reloading code, since we’re doing the type re-registration out-of-band (only after ActiveSupport::Dependencies has completed its reload cycle)
I’ll try adding a mutex, though, to see if that fixes the problem
Nikita Shilnikov
@flash-gordon
@solnic apparently dry-v's cache machinery revealed a bug in jruby Array#hash which leads to collisions. I think it's one more proof that dry-v approach is very fresh :) Btw I tried to get collisions for symbols introduced by calling #hash and found that it's quite likely to have a few collisions on 100k random symbols (different chars & length) on jruby. So probability is actually low but issues are not impossible. Things are better on MRI and rubinius because #hash results has 2 ^ 64 variants against 2 ^ 32 in jruby. I don't think we should do anything about it right know, it's JFYI
oh, and Charles broke Array#hash quite badly in master trying to fix collisions :) Thus dry-v broke jruby eventually
Piotr Solnica
@solnic
@flash-gordon thanks for following up on this. I actually did see issues with this on rbx as well
Re caching, I'm trying to identify places where behavior can be pure and cache as much as possible and yes, it is a fresh approach :)
Joe Van Dyk
@joevandyk
Andrew Kozin
@nepalez
What is the policy for gems plugins like this one https://github.com/nepalez/dry-initializer-rails ? Do we want them to be reposited at dry-rb?
Piotr Solnica
@solnic
@nepalez yes assuming that one of dry-rb team members is willing to maintain it
Andrew Kozin
@nepalez
one more question. I've updated docs for dry-initializer at dry-rb.org. How could I publish those updates?
Tim Riley
@timriley
@nepalez bundle exec middleman deploy :)
Andrew Kozin
@nepalez
@timriley thanks! will made a try
Tim Riley
@timriley
Let me know how it goes!
Andrew Kozin
@nepalez
@timriley
/dry-rb.org $ bundle exec middleman deploy
/home/nepalez/.rvm/gems/ruby-2.3.0/gems/middleman-blog-4.0.0/lib/middleman-blog/blog_data.rb:170: warning: key :lang is duplicated and overwritten on line 170
== Executing: `./node_modules/webpack/bin/webpack.js --bail`
== External: Command failed with message: No such file or directory - ./node_modules/webpack/bin/webpack.js
Tim Riley
@timriley
OK, so you’ll want to see if the whole thing works locally first
Andrew Kozin
@nepalez
yes
Tim Riley
@timriley
Looks like you need to npm install first
then you can bundle exec middleman build to see if it’ll build locally
if that succeeds, then you should be fine to deploy
what’s also handy is just bundle exec middleman, which will spin up a preview server
Andrew Kozin
@nepalez
Hmm... thats tricky one. My mint (ubuntu 14) makes this npm install a hard thing to do. Will do it later on free time
Piotr Solnica
@solnic
also don’t forget to stand on one foot, touch your nose with your left hand, and your left ear with your right hand, then curse node.js 3 times, this should make it work, at least worked for me
Tim Riley
@timriley
@nepalez want me to deploy your changes?
@solnic I for one <something> our new front-end overlords
Andrew Kozin
@nepalez
@timriley it would be great
Vasilis Spilka
@vasspilka
This message was deleted
Tim Riley
@timriley
@nepalez have you pushed them up into a branch or are they just on master?
@vasspilka I don’t think the Symbol#to_proc works like that when you have to supply an argument.
Vasilis Spilka
@vasspilka
I see @timriley thanks, I'm deleting the question as its unrelated
Luca Guidi
@jodosha
It's done!