the only really complex part is dealing with results, the rest is pretty simple
the good part though, is that we can continue improving it separately from types and validation, as long as ast stays the same we don't have to update validation/types
there are two things we rely on, ast format and result api, in dry-v a schema result implements logic's result api
I had written something myself but it was not nearly as elegant or powerful
@fran-worley but this change isn't a big one, should be simple to fix
For anyone using dry-types with Rails, dry-types-rails 0.3.0 was just released, which should (hopefully) solve a bunch of issues with using custom types in development :) https://rubygems.org/gems/dry-types-rails/
Thanks to @jeromegn and @AMHOL in making it happen
Probably needs a mutex around the
REGISTERED_TYPES stuff?
I’ll try adding a mutex, though, to see if that fixes the problem
@solnic apparently dry-v's cache machinery revealed a bug in jruby Array#hash which leads to collisions. I think it's one more proof that dry-v approach is very fresh :) Btw I tried to get collisions for symbols introduced by calling #hash and found that it's quite likely to have a few collisions on 100k random symbols (different chars & length) on jruby. So probability is actually low but issues are not impossible. Things are better on MRI and rubinius because #hash results has 2 ^ 64 variants against 2 ^ 32 in jruby. I don't think we should do anything about it right know, it's JFYI
oh, and Charles broke Array#hash quite badly in master trying to fix collisions :) Thus dry-v broke jruby eventually
Re caching, I'm trying to identify places where behavior can be pure and cache as much as possible and yes, it is a fresh approach :)
What is the policy for gems plugins like this one https://github.com/nepalez/dry-initializer-rails ? Do we want them to be reposited at dry-rb?
@timriley
/dry-rb.org $ bundle exec middleman deploy
/home/nepalez/.rvm/gems/ruby-2.3.0/gems/middleman-blog-4.0.0/lib/middleman-blog/blog_data.rb:170: warning: key :lang is duplicated and overwritten on line 170
== Executing: `./node_modules/webpack/bin/webpack.js --bail`
== External: Command failed with message: No such file or directory - ./node_modules/webpack/bin/webpack.js
then you can
bundle exec middleman build to see if it’ll build locally
if that succeeds, then you should be fine to deploy
what’s also handy is just
bundle exec middleman, which will spin up a preview server
@solnic I for one <something> our new front-end overlords
@vasspilka I don’t think the
Symbol#to_proc works like that when you have to supply an argument.
