Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Andy Holland
@AMHOL
lol
Probably needs a mutex around the REGISTERED_TYPES stuff?
Phil Schalm
@pnomolos
I’m not sure, it actually may be a race condition with respect to the reloading code, since we’re doing the type re-registration out-of-band (only after ActiveSupport::Dependencies has completed its reload cycle)
I’ll try adding a mutex, though, to see if that fixes the problem
Nikita Shilnikov
@flash-gordon
@solnic apparently dry-v's cache machinery revealed a bug in jruby Array#hash which leads to collisions. I think it's one more proof that dry-v approach is very fresh :) Btw I tried to get collisions for symbols introduced by calling #hash and found that it's quite likely to have a few collisions on 100k random symbols (different chars & length) on jruby. So probability is actually low but issues are not impossible. Things are better on MRI and rubinius because #hash results has 2 ^ 64 variants against 2 ^ 32 in jruby. I don't think we should do anything about it right know, it's JFYI
oh, and Charles broke Array#hash quite badly in master trying to fix collisions :) Thus dry-v broke jruby eventually
Piotr Solnica
@solnic
@flash-gordon thanks for following up on this. I actually did see issues with this on rbx as well
Re caching, I'm trying to identify places where behavior can be pure and cache as much as possible and yes, it is a fresh approach :)
Joe Van Dyk
@joevandyk
Andrew Kozin
@nepalez
What is the policy for gems plugins like this one https://github.com/nepalez/dry-initializer-rails ? Do we want them to be reposited at dry-rb?
Piotr Solnica
@solnic
@nepalez yes assuming that one of dry-rb team members is willing to maintain it
Andrew Kozin
@nepalez
one more question. I've updated docs for dry-initializer at dry-rb.org. How could I publish those updates?
Tim Riley
@timriley
@nepalez bundle exec middleman deploy :)
Andrew Kozin
@nepalez
@timriley thanks! will made a try
Tim Riley
@timriley
Let me know how it goes!
Andrew Kozin
@nepalez
@timriley
/dry-rb.org $ bundle exec middleman deploy
/home/nepalez/.rvm/gems/ruby-2.3.0/gems/middleman-blog-4.0.0/lib/middleman-blog/blog_data.rb:170: warning: key :lang is duplicated and overwritten on line 170
== Executing: `./node_modules/webpack/bin/webpack.js --bail`
== External: Command failed with message: No such file or directory - ./node_modules/webpack/bin/webpack.js
Tim Riley
@timriley
OK, so you’ll want to see if the whole thing works locally first
Andrew Kozin
@nepalez
yes
Tim Riley
@timriley
Looks like you need to npm install first
then you can bundle exec middleman build to see if it’ll build locally
if that succeeds, then you should be fine to deploy
what’s also handy is just bundle exec middleman, which will spin up a preview server
Andrew Kozin
@nepalez
Hmm... thats tricky one. My mint (ubuntu 14) makes this npm install a hard thing to do. Will do it later on free time
Piotr Solnica
@solnic
also don’t forget to stand on one foot, touch your nose with your left hand, and your left ear with your right hand, then curse node.js 3 times, this should make it work, at least worked for me
Tim Riley
@timriley
@nepalez want me to deploy your changes?
@solnic I for one <something> our new front-end overlords
Andrew Kozin
@nepalez
@timriley it would be great
Vasilis Spilka
@vasspilka
This message was deleted
Tim Riley
@timriley
@nepalez have you pushed them up into a branch or are they just on master?
@vasspilka I don’t think the Symbol#to_proc works like that when you have to supply an argument.
Vasilis Spilka
@vasspilka
I see @timriley thanks, I'm deleting the question as its unrelated
Luca Guidi
@jodosha
It's done!
Tim Riley
@timriley
Nice work @jodosha!
Luca Guidi
@jodosha
Thank you all! :green_heart:
Fran Worley
@fran-worley
Thank you @jodosha, here's to the start of a long and happy alliance!
Luca Guidi
@jodosha
@timriley @fran-worley :tada:
Piotr Solnica
@solnic
:tada: :cocktail: :wine_glass: :beers: :tada:
Luca Guidi
@jodosha
@solnic And as we speak, I'm starting to work on hanami-model w/ ROM ;)
Piotr Solnica
@solnic
@jodosha ooh, thanks for the heads-up, gonna join rom-rb “just in case”
Luca Guidi
@jodosha
@solnic Thank you. Any GH repo where to start? rom-repository? In my understanding the website doesn't report 2.0 changes yet.
Piotr Solnica
@solnic
@jodosha tell me what you want to do, more or less
Luca Guidi
@jodosha
@solnic for now just play with ROM + repository to refresh my memories, understand what's changed and what's possible to do.
Piotr Solnica
@solnic
@jodosha grab rom-repo from master then and look at latest specs, these are pretty high-level tests so should give you an overview of what’s possible
Luca Guidi
@jodosha
@solnic thank you! :)
Piotr Solnica
@solnic
I was going to add a bin/console to rom-repo but ran out of time
basically to have the same setup as we have in specs loaded for you so it’s easy to open console and do stuff
The last two are quite old
Damn, forgot that Gitter would expand those, sorry for the flood :(