dry-rb/chat

WE MOVED TO ZULIP => https://dry-rb.zulipchat.com <=

Piotr Solnica

@solnic

uhm, we should change it to accept kwargs

Nikita Shilnikov

@flash-gordon

I mean gist, not this cropped preview

Piotr Solnica

@solnic

I’m pretty sure it’s gonna need more options soon :D

Nikita Shilnikov

@flash-gordon

:laughing:

Oskar Szrajer

@gotar

ah sorry, It's to late for me :p

I try to prepare workshops based on rom, roda, and whole Dry stack but already see it will be too hard to accept by anyone

need to think how to go through it

Fran Worley

@fran-worley

@solnic is there a way of distinguishing between a :key? rule being created via required/optional vs the value block?

Piotr Solnica

@solnic

@gotar rom-rb or roda alone would be a lot for a single workshop :)

@fran-worley not really. why?

Fran Worley

@fran-worley

Trying to raise an error when you do: required(:foo) { key? } I can catch it easily with the macros but not with the blocks...

Piotr Solnica

@solnic

it’d be better to do that thing we talked about last month with predicates being available already when DSL is initialized

then we can explicitly define which predicates are available where

and improve UX in general

Fran Worley

@fran-worley

that's true. I'll take out the changes I made in #177 and then it can merge as its just spec updates?

Piotr Solnica

@solnic

actually that part can stay

just merge it in :)

Fran Worley

@fran-worley

Ok cool, does the error name make sense? InvalidSchemaError ?

Piotr Solnica

@solnic

yep

Fran Worley

@fran-worley

cool

Piotr Solnica

@solnic

seems like the fixes in dry-types made tons of specs pass :)

Fran Worley

@fran-worley

I got the whole lot to pass, then skipped another load which were fudged

Ralf Schmitz Bongiolo

@mrbongiolo

@solnic dry-rb/dry-validation#172 should be passing now too, I updated my app code and the array? rule seems to be working correctly

Piotr Solnica

@solnic

@mrbongiolo pls merge these specs in if they are passing now

Ralf Schmitz Bongiolo

@mrbongiolo

let me check it

Ralf Schmitz Bongiolo

@mrbongiolo

@solnic that's weird, in my app it's working, but the specs are still failing...

Piotr Solnica

@solnic

@mrbongiolo it needs dry-types from master

Ralf Schmitz Bongiolo

@mrbongiolo

@solnic shouldn't a bundle update get it from master already?

Piotr Solnica

@solnic

yeah but travis is weird with caching so…maybe remove cache and restart

Ralf Schmitz Bongiolo

@mrbongiolo

@solnic the build passed on Travis, for some reason my local build doesn't want to update dry-types or is just not using the version from master, gonna check out later what's going on

Oskar Szrajer

@gotar

Another probably stupid question ;]

require "dry-validation"

module Validations
  PostValidator = Dry::Validation.Form do
    required(:title) { filled? & str? }
    required(:body){ filled? & str? }
  end
end

if I have Validator like this how I can use it with AutoInject? There is no method new to call by it, t's just a function. I need to mark it somehow or do sth else?

Blog::Container["validations.post_validator"]
NoMethodError: undefined method `new' for #<#<Class:0x007fdbb0c8b1b0>:0x007fdbb0bf2898>
    from /Users/gotar/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/bundler/gems/dry-component-0bebc656b625/lib/dry/component/loader.rb:42:in `instance'

Nikita Shilnikov

@flash-gordon

@gotar I know @timriley had a similar issue. I don't use dry-component atm so I don't know how to handle it properly, too high level for me :)

Oskar Szrajer

@gotar

ok I have solution

just pack class around it

require "dry-validation"

module Validations
  class PostValidator
    PostSchema = Dry::Validation.Form do
      required(:title) { filled? & str? }
      required(:body){ filled? & str? }
    end

    def call(args)
      PostSchema.call(args)
    end
  end
end

Piotr Solnica

@solnic

I don't register schemas in containers

just set them as constants

Andy Holland

@AMHOL

@gotar you can pass a block to auto_register!

And use that to determine how to construct the objects

@solnic perhaps we should have a configuration and delegate that to an object

Piotr Solnica

@solnic

better to skip auto-registering schemas

just define them as constants

that's why I added block syntax for building an object

Andy Holland

@AMHOL

How come @solnic ?

Oskar Szrajer

@gotar

it will be the best if AutoInject recognize it's class or not and then defind as contant not call new on it

Andy Holland

@AMHOL

@gotar just watching your wroc_love.rb talk BTW :)

Piotr Solnica

@solnic

link pls?

Oskar Szrajer

@gotar

nothing to see :p

:cat2:

Where communities thrive

People

Repo info

Activity