Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 05:53
    technofreak starred dry-rb/dry-monads
  • 00:14
    thekuwayama starred dry-rb/dry-monads
  • Dec 11 09:29
    blasterun starred dry-rb/dry-monads
  • Dec 11 08:34
    flash-gordon closed #115
  • Dec 11 08:34
    flash-gordon commented #115
  • Dec 11 08:31

    flash-gordon on v1.3.3

    (compare)

  • Dec 11 08:30

    flash-gordon on master

    Bump version to 1.3.3 (compare)

  • Dec 11 08:30

    flash-gordon on master

    Update CHANGELOG (compare)

  • Dec 10 23:46
    johnmaxwell commented #116
  • Dec 10 21:54

    flash-gordon on master

    Halt with mutable backtrace Ex… Merge pull request #116 from jo… (compare)

  • Dec 10 21:54
    flash-gordon closed #116
  • Dec 10 21:54
    flash-gordon commented #116
  • Dec 10 21:49
    johnmaxwell commented #116
  • Dec 10 21:47
    johnmaxwell commented #116
  • Dec 10 21:43
    johnmaxwell commented #116
  • Dec 10 21:39
    johnmaxwell commented #116
  • Dec 10 21:31
    johnmaxwell commented #116
  • Dec 10 21:22
    flash-gordon commented #116
  • Dec 10 19:41
    johnmaxwell opened #116
  • Dec 10 19:36
Russell Edens
@rx
I'll be pushing some code to look at later today/tonight.
^^ unfortunate typo - should be: As it is right now I have to make dry-s look more like dry-v at the rule-ast level.
Piotr Solnica
@solnic
@rx did you use dry-logic from master? it changed quite a bit
Russell Edens
@rx
@solnic I have been following the changes. I'm re-working the work I did against master now.
Piotr Solnica
@solnic
@rx I’m not entirely sure if it’s the best direction but we’ll see. rules are not for defining data structures, they are generic. We can easily add generating some meta-data in dry-v schemas though, or try to use generated dry-t’s schemas (that do define the structures). I think I mentioned that in the related issue :)
Russell Edens
@rx
@solnic yes I started down that route but it started feeling like I was pushing the metadata requirements into both dry-v and dry-s, when the rules_ast already had everything that is needed (and more). This lead me to treating the metadata api more like an extension, like you mentioned earlier in the issue :smile: I translated dry-s rules-ast to dry-v rules-ast temporarily to allow me to start using the extension with dry-s. The next step is resolving the non-symmetrical dry-s and dry-v schemas, that would allow me to throw away my temporary dry-s(ast)->dry-v(ast) translation. This approach allowed me to build a more complete set of metadata for both dry-v and dry-s with minimal dependencies and saving anyone else from groking the underlying rules_ast. :smile: If the underlying rules_ast is likely to change more than the dry-s and dry-v object model then I did indeed take a wrong turn.
Russell Edens
@rx
@solnic I just happened to embark on this approach, then I saw you refactored the dry-l ast. :worried:
Piotr Solnica
@solnic
sorry about that, it’s been planned for months, I actually didn’t know you started working on this
fwiw the ast approach is going to be the most powerful, so assuming it’s easy to translate it to what we need, this will be the best approach :)
Russell Edens
@rx
No problem. it should be very easy to re-map. I'll provide a heads up next time. I was just trying to stay out of the way. It looked like you got some really good stuff done.
Right now I'm putting this into its own repo as a WIP for you to look at.
Piotr Solnica
@solnic
yes these are major improvements bringing us much closer to 1.0.0’s
Russell Edens
@rx
:clap:
Piotr Solnica
@solnic
I still need to improve OR-message handling though (it’s a tricky beast…)
Russell Edens
@rx
yes it would be by definition!
btw - I had trouble finding a dry-v rules_ast set and not examples. Do you have one? And do you want me to open an issue or PR against the website documentation?
Piotr Solnica
@solnic
@rx are you asking about examples of DSL usage in dry-v?
Russell Edens
@rx
@solnic yes.
I built my specs using the documentation on the website.
Piotr Solnica
@solnic
I barely covered 50% of the functionality in the docs :)
(not sure why I’m smiling lol)
required(:admin) { true? | true?.not } == required(:admin) { true? | false? }
we could probably add support for not(true?) though
it’d look better
Russell Edens
@rx
Yes I know, I dug around the specs/code to find the rest. I also found missing predicates from #155.
:+1: on not(true?)
Would you like issues opened on the website for missing doc items?
thx!
Piotr Solnica
@solnic
@rx yes website’s issue tracker is the right place
Russell Edens
@rx
I know you'd like PR's for the missing doc items! :worried:
@solnic will do
@solnic do you have an example of a dry-v 'set' off the top of your head?
Piotr Solnica
@solnic
@rx every time you define more than one key you end up with a set rule
it’s basically a list of rules that must be applied to the same input
Russell Edens
@rx
ok - so they don't really show up in the rules_ast
Piotr Solnica
@solnic
they do
Russell Edens
@rx
alright, looks like I'm missing a spec
Piotr Solnica
@solnic
oh actually we don’t create :set from multiple keys
it’s just an array of individual rules that will be executed
Russell Edens
@rx
@solnic so is there a dry-v schema that will generate a :set rule_ast? (I'm throwing not implemented, so I haven't found it yet.)
Piotr Solnica
@solnic
@rx just ignore it for now
Russell Edens
@rx
ha didn't escape that one
@solnic will do
@solnic thanks for your help!
Wilson Silva
@wilsonsilva
I'm getting a privacy error on Chrome when I try to access https://discuss.dry-rb.org/
Piotr Solnica
@solnic
@wilsonsilva uhm, lemme see
@wilsonsilva green for me
safari ff and chrome
John Backus
@backus
@solnic dry-rb/dry-types#141 is up :)
John Backus
@backus
@solnic I can't remember if we decided on doing anything new in dry-struct land to move away from the constructor_type thing