just removed that line, I overlooked it, sorry
@joevandyk you can see it in action here: https://github.com/dry-rb/dry-validation/blob/master/spec/integration/schema/macros/input_spec.rb#L123
@flash-gordon it’d be fine to push 0.10.1 with your fix, I think, wdyt?
@timriley thanks, wasn’t easy, thankfully we’ve got amazing help from contributors :)
now I gotta sum this up in a blog post :sweat_smile:
I think I found my first dry-v bug of the new release
gem 'dry-validation', '~> 0.10'
require 'dry/validation'
schema =
Dry::Validation.Schema do
required(:foo) { str? }
required(:bar) { str? | int? }
end
schema.call(foo: 1, bar: 'blah').message_set.first.text # => "must be a string"
begin
schema.call(foo: 'hi', bar: 1.0).message_set.first.text
rescue => err
p err
end
# >> #<NoMethodError: undefined method `text' for #<Dry::Validation::Message::Or:0x007fbcb32514b8>>
@solnic or @flash-gordon ^
Is it a bug or were we using private API?
gem 'dry-validation', '~> 0.10'
require 'dry/validation'
SCHEMA =
Dry::Validation.Schema do
required(:foo) { str? }
required(:bar, %i[string int]) { str? | int? }
end
SCHEMA.call(foo: 1, bar: 'blah').message_set.first.to_s # => "must be a string"
begin
SCHEMA.call(foo: 'hi', bar: 1.0).message_set.first.to_s # => "must be a string or must be an integer"
rescue => err
p err
end
there’s also
Result#errors and Result#hints
thanks
http://dry-rb.org/gems/dry-validation/reusing-schemas/ deals with a hash with a key that has a schema of X
oh hm.. that works with plain schemas, not form schemas
on dry-v master
if I use a form schema, I get:
/home/monkey/.gem/ruby/2.2.5/gems/dry-types-0.9.0/lib/dry/types/compiler.rb:80:in `merge': no implicit conversion of Dry::Types::Safe into Hash (TypeError)
from /home/monkey/.gem/ruby/2.2.5/gems/dry-types-0.9.0/lib/dry/types/compiler.rb:80:in `each'
that a bug?
will check this out
re pattern matching, you can use
case for simple ugh ... cases
until 0.10 we only have
messages that merge both errors and hints, this turned out to be problematic in some cases so it was separated in 0.10.0
each { schema SomeFormSchema } doesnt seem to work. Using a non form schema does.
