dry-rb/chat

WE MOVED TO ZULIP => https://dry-rb.zulipchat.com <=

Uros Jurglic

@jurglic

Now the business requirement changed so that first three operations need to be run always - regardless of the result of the previous operation.

What would be the right way to approach in dry transaction?

Piotr Solnica

@solnic

@jurglic then it’s no longer a transaction :)

Uros Jurglic

@jurglic

Yeah, that crossed my mind too!

@solnic But if we forget that one for a minute... would something like that make more sense?

Piotr Solnica

@solnic

@jurglic it does

Uros Jurglic

@jurglic

Can the first three operations still use Either response? Or will it fail if one of them returns Left?

Nikita Shilnikov

@flash-gordon

a transaction will be halted once a step will return Left, all the moving parts are https://github.com/dry-rb/dry-transaction/blob/master/lib/dry/transaction/step.rb#L34-L45 and https://github.com/dry-rb/dry-transaction/blob/master/lib/dry/transaction/sequence.rb#L60

@jurglic

Uros Jurglic

@jurglic

Is that so even if step is defined as map :qc_silence?

Thanks

Nikita Shilnikov

@flash-gordon

the only place where step adapter is used is here https://github.com/dry-rb/dry-transaction/blob/master/lib/dry/transaction/step.rb#L36 so your step have to return a Right instance always

Uros Jurglic

@jurglic

Sorry it's a bit confusing to me. So if I use map :qc_silence, the QcSilence should never return Left?

Nikita Shilnikov

@flash-gordon

no worries, well, map always returns Right so it should work just fine for you :) BUT there is a caveat

if you return Left/Right from QcSilence, map will wrap it once again

so you'll get Right(Right(...)) or Right(Left(...))

Uros Jurglic

@jurglic

Aha, I see.

Piotr Solnica

@solnic

according to docs, map always returns Right

Uros Jurglic

@jurglic

So you think my approach is somewhat acceptable? :D

@solnic Thanks Piotr yeah I saw that one, that's why I was confused before.

Piotr Solnica

@solnic

feels like an overhead though, if it always returns Right then maybe it’d be better to just pass plain values

Uros Jurglic

@jurglic

So the first 3 operations, - as implemented now - can return Left or Right. However they are independent. And now new requirement came they should run always no matter if any of them failed in a previous step.

So I'm trying to figure out what's the approach best aligned with dry-transaction.

Tim Riley

@timriley

Right now, it feels like it's be better just to run those three things in a custom class

@apotonick's pipetree stuff in trailblazer 2 makes me want to enrich some of the functionality of dry-transaction, but in a little while

Nick Sutterer

@apotonick

@timriley i was evaluating it

and decided to use my own pipetree stuff that is approved to work in representable, and is super fast

it's very important for that to be fast, since i want to use pipetree for all my gems and everything

we should probably "merge" those two gems

Nick Sutterer

@apotonick

@timriley question reg. dry-matcher. so, when i define using Matcher.new that's called the matcher object?

and when i evaluate it, how's that named?

and, what are you doing awake at 7am on a sunny saturday?

Tim Riley

@timriley

Kids :p

Yeah, I guess Matcher.new makes the matcher object, and then you run it with a a "match block" against some kind of value

/me will think about those names a little more

Steve

@dnd

is there a way to get the errors from dry-validation as symbols/keys instead of text sentences? I'm looking to get output like {amount: [:missing, :min_size]} or something like that

Nick Sutterer

@apotonick

@timriley "match block", i just called it handler, but yeah

Martín Fernández

@bilby91

Hello, do I need to require something in order to use Types::Maybe ?

Tim Riley

@timriley

Yeah, it's an "extension" now, @bilby91 - I'm on my phone right now but if you grep the specs for :maybe, you should see how it's done.

Martín Fernández

@bilby91

Perfect! Will check

Thanks @timriley

Is this correct ?

# frozen_string_literal: true
class User < Dry::Struct
  attribute :id, Types::Strict::Int
  attribute :source_url, Types::Strict::String
  attribute :width, Types::Maybe::Float
  attribute :height, Types::Maybe::Float
  attribute :format, Types::Maybe::String
end

I’m getting NameError: Float cannot be autoloaded from an anonymous class or module

Nick Sutterer

@apotonick

@bilby91 did you require the types file?

Tim Riley

@timriley

I've never seen this error. Are you using this inside Rails?

Yeah, you might want to explicitly require the file where you set up the Types module

Nick Sutterer

@apotonick

@timriley how can i know whether or not a matcher has executed a "handler"?

Martín Fernández

@bilby91

My bad, I was missing Strict or Coercible on the Maybe types

I’m working on a rails project

Tim Riley

@timriley

@apotonick how do you mean?

Where communities thrive

People

Repo info

Activity