Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Dec 15 19:07
    jjw starred dry-rb/dry-types
  • Dec 15 18:13

    flash-gordon on master

    Remove unreachable method (compare)

  • Dec 15 18:11

    flash-gordon on master

    Remove Dry::Types.type_keys It… (compare)

  • Dec 15 18:09

    flash-gordon on master

    Remove unreachable code (compare)

  • Dec 15 18:04

    flash-gordon on master

    Coverage for function.rb (compare)

  • Dec 15 17:15

    flash-gordon on fix-maybe-call-safe

    (compare)

  • Dec 15 17:15

    flash-gordon on master

    Fix behavior of Maybe#call_safe… Merge pull request #380 from dr… (compare)

  • Dec 15 17:15
    flash-gordon closed #380
  • Dec 15 17:13
    flash-gordon synchronize #380
  • Dec 15 17:13

    flash-gordon on fix-maybe-call-safe

    Fix behavior of Maybe#call_safe… (compare)

  • Dec 15 17:12
    flash-gordon opened #380
  • Dec 15 17:11

    flash-gordon on fix-maybe-call-safe

    Fix behavior of Maybe#call_safe… (compare)

  • Dec 15 17:00

    flash-gordon on fix-maybe-try

    (compare)

  • Dec 15 17:00

    flash-gordon on master

    Fix behavior of Types::Maybe#try Merge pull request #379 from dr… (compare)

  • Dec 15 17:00
    flash-gordon closed #379
  • Dec 15 15:09

    flash-gordon on master

    Fix typo Merge pull request #67 from gru… (compare)

  • Dec 15 15:09
    flash-gordon closed #67
  • Dec 15 14:43
    flash-gordon opened #379
  • Dec 15 14:43

    flash-gordon on fix-maybe-try

    Fix behavior of Types::Maybe#try (compare)

  • Dec 15 14:30

    flash-gordon on master

    Lax coverage (compare)

Oskar Szrajer
@gotar
yeah. I'm ok with that, we just need more examples and docs
Piotr Solnica
@solnic
right, accepting the fact we isolate global state in containers is probably step #1 :D
Oskar Szrajer
@gotar
so it's a step in good direction - blog example
@timriley hmm in new dry-view how to access Page those assets, csfr_token ?or those whole class should be dropped and moved to those new controller?
Piotr Solnica
@solnic
IIRC all methods provided by the context object are available in templates
basically context == global template api
Oskar Szrajer
@gotar
yeah I have setting :context, Container["page"]
and do not work with page.assets or just assets, for just assets drop error,. no key found like assets
like in template layout:
== csrf_metatag
and I got
  KeyError:
    key not found: :csrf_metatag
  # ./lib/athit/page.rb:54:in `fetch'
  # ./lib/athit/page.rb:54:in `[]'
  # ./lib/athit/page.rb:30:in `csrf_metatag'
Tim Riley
@timriley
@gotar you'll need to pass a context at call-time with the request-specific stuff loaded into it
view.(context: some_context)
@gotar check out the PR I just made to dry-web-roda, so you can see it there
I'm sleeping now, happy to answer q's in the morning
Oskar Szrajer
@gotar
eheh thx ;]
Tim Riley
@timriley
I'll try update Berg next week but I may not be able to fit it in
Oskar Szrajer
@gotar
not a problem i Just play to learn
Piotr Solnica
@solnic
psst, we have a new gem => https://github.com/dry-rb/dry-monitor
just pushed 0.0.1 to rubygems /cc @AMHOL
Luca Guidi
@jodosha
:+1:
Maciej Mensfeld
@mensfeld
Tim Riley
@timriley
@mensfeld things don't go to the website right away :)
Andy Holland
@AMHOL
@solnic awesome :)
Piotr Solnica
@solnic
I’ll build a website with docs once it’s out of alpha
which should be soon, because it’s so simple
the biggest challenge is to make this 1st class concept in rom
for now I monkeypatched SQL::Relation :monkey_face:
Tim Riley
@timriley
"OH solnic now I monkeypatched..."
Piotr Solnica
@solnic
heh btw THIS is how monkeypatching is useful
otherwise we’d be blocked
and in such cases I love Ruby SO MUCH
Tim Riley
@timriley
Yeah I was just gonna say that too, haha :)
Piotr Solnica
@solnic
btw instrumentation integration between Sequel/rom-sql and AS::Notifications for rom-rails == a monkey-patch
which I actually copied from sequel-rails railite
but it won’t be like that for long
because I’ll be adding proper support for instrumentation to rom and rom-sql (as I mentioned already)
Oskar Szrajer
@gotar
Wot so fast ;] I need update again :)
@timriley I update dry view in the project and everything work ok (but will probably change few things after I see how you guys resolve it in berg, I'm not fully happy how I extend view_context by assets and current user . Plus I spend some time investigating why my partial do not work (single one) and found that it have the same name as one method in context. So it render method not partial, It's something a lot probably hit one day, so maybe another idea here will be better to explicity know when I want to render partial and when method
Oskar Szrajer
@gotar
@solnic I think your last update for dry-web-(roda) can cause problems - (need changes in dry-web-roda). It requires log directory to exists for any app in apps folder, store logs there not in main log directory, plus app generator for dry-web-roda already add to boot logger and register it as logger in Container so it crash . Maybe it's only my app but worth to check
Tim Riley
@timriley
Thanks for for trying these out, @gotar. I'll check dry-web-roda today
Oskar Szrajer
@gotar
chages required (I assume are required) for dry-monitor are super easy, both for app generator to drop custom logger and add two directories
Piotr Solnica
@solnic
@gotar yeah I didn’t have time to update generators
I’ll add docs over the weekend while flying to AU :laughing:
btw we follow “shifted semver” so if you see a minor bump while we’re still in beta (and all dry gems are in beta) then it means a breaking change
and re logger, just configure config.logger = YourMainContainer[:logger] in sub-apps
unless you want separate loggers per app
Darcy Laycock
@Sutto
@solnic when do you get in?