Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 14:41
    Travis dry-rb/dry-view (master) errored (638)
  • 14:36

    dry-bot on master

    [devtools] config sync (compare)

  • 14:36

    dry-bot on master

    [devtools] config sync (compare)

  • 14:36

    dry-bot on master

    [devtools] config sync (compare)

  • 14:36

    dry-bot on master

    [devtools] config sync (compare)

  • 14:36

    dry-bot on master

    [devtools] config sync (compare)

  • 14:36

    dry-bot on master

    [devtools] config sync (compare)

  • 14:36

    dry-bot on master

    [devtools] config sync (compare)

  • 14:36

    dry-bot on master

    [devtools] config sync (compare)

  • 14:36

    dry-bot on master

    [devtools] config sync (compare)

  • 14:36

    dry-bot on master

    [devtools] config sync (compare)

  • 14:36

    dry-bot on master

    [devtools] config sync (compare)

  • 14:36

    dry-bot on master

    [devtools] config sync (compare)

  • 11:48

    flash-gordon on v1.2.2

    (compare)

  • 11:47

    flash-gordon on master

    Update CHANGELOG (compare)

  • 11:36
    flash-gordon closed #376
  • 11:36

    flash-gordon on reject-string-keys

    (compare)

  • 11:36

    flash-gordon on master

    Reject non-symbol keys in schem… Test invalid exception message Merge pull request #378 from dr… (compare)

  • 11:36
    flash-gordon closed #378
  • 11:24
    flash-gordon synchronize #378
Alejandro E. Babio
@alejandrobabio
Good! Thank you!
Nikita Shilnikov
@flash-gordon
not all the monads are required for dry-transaction hence those methods are not required by default
Alejandro E. Babio
@alejandrobabio
Thanks for say that. Now it's working.
Piotr Solnica
@solnic
@gotar I think I know why you had issues with instrumentation patch in rom, you basically can’t boot!(:rom) too early, otherwise patch won’t be applied before your relations are built
Oskar Szrajer
@gotar
yeah i assume it's condition problem, is there a way to force order, like in rom force loading monit first? maybe in init?
@solnic
for now i just add:
        notifications ||= Athit::Container[:notifications]
        notifications.instrument(:sql, name: name.relation, query: dataset.sql) do
          super
        end
works, but it's ugly hack
Oskar Szrajer
@gotar
:facepalm: ok fixed ;]
there is just use :monitor missing in rom boot file (init section)
@timriley @solnic
so probably should be added to dry-web-roda geenrator too
thx guys for help
Oskar Szrajer
@gotar
@timriley I already add those missing line to dry-web-roda skeleton apps
Tim Riley
@timriley
@gotar oh! Would you mind PR-ing this? I'll add you as a contributor if you're not already, too.
Oskar Szrajer
@gotar
I put this automaticaly on master branch (for mistake ;P) hope you don't mind
specs do not catch this problem with monitor because non of them use db
Piotr Solnica
@solnic
@gotar well first of all I need to add notifications support to rom, so that we don’t have a monkey patch :)
I’ve got it in a local branch, I’ll push this tomorrow
Tim Riley
@timriley
@gotar oh no worries, master is good. I actually want to add some specs that generate an app and add enough files to set up a persistence layer, just to test that all works properly
Oskar Szrajer
@gotar
now should all works
probably there is not to much users of those skeletons but I use them for every app ;]
Tim Riley
@timriley
😎
Piotr Solnica
@solnic
@flash-gordon so I started working on ASTs for dry-types here dry-rb/dry-types#178
Nikita Shilnikov
@flash-gordon
@solnic yeah, I see what you're doing there 😀
Piotr Solnica
@solnic
@flash-gordon this was my intention from the beginning, I’m pretty sure reducing types into simpler forms will be a great feature useful in many places
the only thing that worries me a little is that constructors can’t be represented with pure data :(
as in, if you use an anonymous proc instead of a method-based proc, you can’t represent it as data
in case of class methods it’d be possible, ie [:constructor, [User, :new]]
which can be easily compiled as klass, meth = node + klass.method(meth) :)
Nikita Shilnikov
@flash-gordon
@solnic well, you can register procs as methods with generated names
Piotr Solnica
@solnic
hmmm you mean capture them in #constructor and register somewhere?
Nikita Shilnikov
@flash-gordon
yep
Piotr Solnica
@solnic
Worth exploring this idea
Maciej Mensfeld
@mensfeld
guys where's configurable 0.6.0?
I can't bundle it :/
Maciej Mensfeld
@mensfeld
ok nvmd - something with bundler cahce
Nikita Shilnikov
@flash-gordon
@mensfeld it seems @AMHOL has bumped version number only a few minutes ago
Maciej Mensfeld
@mensfeld
@flash-gordon yeah ;) I was just 2 fast and hit a rubygems server that was out of sync
Pablo Herrero
@pabloh
why does Dry::Validation::Result is not a monad as well?
Nikita Shilnikov
@flash-gordon
@pabloh because dry-monads is not a required dependecy of dry-validation
Pablo Herrero
@pabloh
@flash-gordon, I think it would we useful to have it that way
is it possible to make it a soft dependency at least?
have you consider it, I mean?
Nikita Shilnikov
@flash-gordon
you can activate dry-monads integration with Dry::Validation.load_extensions(:monads), then you'll be able to call .to_either on Result :sparkles:
so it has been considered :)
Pablo Herrero
@pabloh
hehe, sorry for been a bit of touch... :P
Nikita Shilnikov
@flash-gordon
ah, no worries :)