Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Maciej Mensfeld
@mensfeld
@apotonick ask me to do that from time to time as I hve 100% coverage of operations as well
Since your gems aren't considered stable by me - I prefer to cover all the things
Piotr Solnica
@solnic
you sure you wanted to mention Nick ^_^? :D
Maciej Mensfeld
@mensfeld
hahaha :P
will something bad happen?
Piotr Solnica
@solnic
anyhow, yes dry-rb gems are not stable
:bike: time, bbiab
Maciej Mensfeld
@mensfeld
I would say they are not stable but they aren't unstable ;) and if you don't hack internals they work well
Piotr Solnica
@solnic
heh yeah, we need better terminology for this stuff
Nick Sutterer
@apotonick
Haha! My stuff is usually 100% tested, but Ruby makes it too easy to "fix" internals in your project and then the next minor update breaks things... surprisingly!
@solnic There are rumors about us :beers: at grill camp or whatever the name was?! ;)
Nikita Shilnikov
@flash-gordon
grill camp :laughing:
Nick Sutterer
@apotonick
What was the name again? Haha :joy:
Nikita Shilnikov
@flash-gordon
http://railsclub.ru/en/main there're your faces ;)
Nick Sutterer
@apotonick
@flash-gordon Hahaha, yes, but I meant something else
It's in Wroclaw
Grillruby or something... god damnit, @mensfeld what's it called, again, the event in July?
Maciej Mensfeld
@mensfeld
@apotonick http://grillrb.com/ :)
Nikita Shilnikov
@flash-gordon
@apotonick haha, so you don't avoid to mention rails that much? :laughing:
https://www.instagram.com/p/BOfulQVAk8U/ that looks nice :)
Nikita Shilnikov
@flash-gordon
you'd be very lucky to sit like that at the end of September in Moscow :worried:
Piotr Solnica
@solnic
@flash-gordon hey man, I want to release dry-types 0.10.0 with these two changes you’ve made
you ok with that?
I tested it against rom/rom-sql, looks good
Nikita Shilnikov
@flash-gordon
@solnic yes, feel free
Piotr Solnica
@solnic
I bumped to 0.10.0 btw
since meta change is (a bit) significant
Piotr Solnica
@solnic
@flash-gordon bad news, specs in my app started to fail when I upgraded to dry-t 0.10 :(
Oskar Szrajer
@gotar
I have a question, there is logger automatically created for dry-web, can I overwrite it somehow? Normal way do not works: There is already an item registered with the key "logger" (Dry::Container::Error). I want to change it to force logger to log to STDOUT, not to file
Piotr Solnica
@solnic
@gotar it’s a configuration setting
Nikita Shilnikov
@flash-gordon
@solnic what's wrong?
Piotr Solnica
@solnic
that’s the funny part, I have no clue
worse part - specs pass when run individually
Nikita Shilnikov
@flash-gordon
oh wow, love that
Piotr Solnica
@solnic
which makes me think there’s some global state
that keeps changing between spec runs
and some specs depend on it and they fail
Piotr Solnica
@solnic
all failures are related to structs being initialized with a missing attribute
Piotr Solnica
@solnic
@flash-gordon got it
we missed the fact we no longer equalize on :meta too
for some reason it broke some other things
as ie Types::String == Types::String.meta(i_am: “different”) returns true
which is a bug
you wrote specs that specifically check if this works like that, so I wonder why?
we set meta to empty hash by default, so Types::String == Types::String.meta({}) # true
Nikita Shilnikov
@flash-gordon
@solnic because we need to support things like hash[type]
in some way
Piotr Solnica
@solnic
where?
types with different meta are not the same, so I don’t think it’s a good idea to treat them as such
Nikita Shilnikov
@flash-gordon
https://github.com/rom-rb/rom-sql/pull/184/files#diff-93f5db3fcfdb30da17f863f05851ad8fR30 first of all here