Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Dec 15 19:07
    jjw starred dry-rb/dry-types
  • Dec 15 18:13

    flash-gordon on master

    Remove unreachable method (compare)

  • Dec 15 18:11

    flash-gordon on master

    Remove Dry::Types.type_keys It… (compare)

  • Dec 15 18:09

    flash-gordon on master

    Remove unreachable code (compare)

  • Dec 15 18:04

    flash-gordon on master

    Coverage for function.rb (compare)

  • Dec 15 17:15

    flash-gordon on fix-maybe-call-safe

    (compare)

  • Dec 15 17:15

    flash-gordon on master

    Fix behavior of Maybe#call_safe… Merge pull request #380 from dr… (compare)

  • Dec 15 17:15
    flash-gordon closed #380
  • Dec 15 17:13
    flash-gordon synchronize #380
  • Dec 15 17:13

    flash-gordon on fix-maybe-call-safe

    Fix behavior of Maybe#call_safe… (compare)

  • Dec 15 17:12
    flash-gordon opened #380
  • Dec 15 17:11

    flash-gordon on fix-maybe-call-safe

    Fix behavior of Maybe#call_safe… (compare)

  • Dec 15 17:00

    flash-gordon on fix-maybe-try

    (compare)

  • Dec 15 17:00

    flash-gordon on master

    Fix behavior of Types::Maybe#try Merge pull request #379 from dr… (compare)

  • Dec 15 17:00
    flash-gordon closed #379
  • Dec 15 15:09

    flash-gordon on master

    Fix typo Merge pull request #67 from gru… (compare)

  • Dec 15 15:09
    flash-gordon closed #67
  • Dec 15 14:43
    flash-gordon opened #379
  • Dec 15 14:43

    flash-gordon on fix-maybe-try

    Fix behavior of Types::Maybe#try (compare)

  • Dec 15 14:30

    flash-gordon on master

    Lax coverage (compare)

Nikita Shilnikov
@flash-gordon
http://railsclub.ru/en/main there're your faces ;)
Nick Sutterer
@apotonick
@flash-gordon Hahaha, yes, but I meant something else
It's in Wroclaw
Grillruby or something... god damnit, @mensfeld what's it called, again, the event in July?
Maciej Mensfeld
@mensfeld
@apotonick http://grillrb.com/ :)
Nikita Shilnikov
@flash-gordon
@apotonick haha, so you don't avoid to mention rails that much? :laughing:
Nikita Shilnikov
@flash-gordon
you'd be very lucky to sit like that at the end of September in Moscow :worried:
Piotr Solnica
@solnic
@flash-gordon hey man, I want to release dry-types 0.10.0 with these two changes you’ve made
you ok with that?
I tested it against rom/rom-sql, looks good
Nikita Shilnikov
@flash-gordon
@solnic yes, feel free
Piotr Solnica
@solnic
I bumped to 0.10.0 btw
since meta change is (a bit) significant
Piotr Solnica
@solnic
@flash-gordon bad news, specs in my app started to fail when I upgraded to dry-t 0.10 :(
Oskar Szrajer
@gotar
I have a question, there is logger automatically created for dry-web, can I overwrite it somehow? Normal way do not works: There is already an item registered with the key "logger" (Dry::Container::Error). I want to change it to force logger to log to STDOUT, not to file
Piotr Solnica
@solnic
@gotar it’s a configuration setting
Nikita Shilnikov
@flash-gordon
@solnic what's wrong?
Piotr Solnica
@solnic
that’s the funny part, I have no clue
worse part - specs pass when run individually
Nikita Shilnikov
@flash-gordon
oh wow, love that
Piotr Solnica
@solnic
which makes me think there’s some global state
that keeps changing between spec runs
and some specs depend on it and they fail
Piotr Solnica
@solnic
all failures are related to structs being initialized with a missing attribute
Piotr Solnica
@solnic
@flash-gordon got it
we missed the fact we no longer equalize on :meta too
for some reason it broke some other things
as ie Types::String == Types::String.meta(i_am: “different”) returns true
which is a bug
you wrote specs that specifically check if this works like that, so I wonder why?
we set meta to empty hash by default, so Types::String == Types::String.meta({}) # true
Nikita Shilnikov
@flash-gordon
@solnic because we need to support things like hash[type]
in some way
Piotr Solnica
@solnic
where?
types with different meta are not the same, so I don’t think it’s a good idea to treat them as such
oh, yes, the latter is now solved since we have an empty hash by default, but anyway
Nikita Shilnikov
@flash-gordon
tbh the reason I did this is that we don't have type ast transformations yet, otherwise I'd trim a tree with excluding metas
and I'm not sure whether it's a good idea to use meta in comparisons. But I'm OK with that. So we need another way to drop meta then
Nikita Shilnikov
@flash-gordon
this can be done with .with(meta: {})
Piotr Solnica
@solnic
that’s a tough one
I wonder what’s less surprising to be honest
Nikita Shilnikov
@flash-gordon
exactly
Piotr Solnica
@solnic
ie ROM::SQL::Types::Int.meta(primary_key: true) == ROM::SQL::Types::Int # true does not look reasonable
those two things mean two different things after all
this can easily bite us in many places
Nikita Shilnikov
@flash-gordon
but I'd say relying on this is a bad idea
Piotr Solnica
@solnic
we use various enumerable methods to find attributes so…dunno