Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Piotr Solnica
@solnic
those two things mean two different things after all
this can easily bite us in many places
Nikita Shilnikov
@flash-gordon
but I'd say relying on this is a bad idea
Piotr Solnica
@solnic
we use various enumerable methods to find attributes so…dunno
why you think that?
Nikita Shilnikov
@flash-gordon
why would you compare two types like this? Why would compare them at all?
Piotr Solnica
@solnic
we do that man and it is useful
ie projecting attributes and then using uniq
or checking if an attribute exist in a schema
all these things rely on equality
and in general it’s about semantics too, like in this PK example I showed, two types, one with special meaning, they are not the same
besides, for hash-based mappings we can use a different method for getting some identifier for a type object
Nikita Shilnikov
@flash-gordon
@solnic don't get me wrong, I don't say they are the same, I'm just wondering how this is used
Piotr Solnica
@solnic
can’t remember exact places
but it’s clearly used given that our specs started to fail
would be good to track it down of course, but I don’t have time :(
Nikita Shilnikov
@flash-gordon
two different approaches are using a type as something that acts as a type and using a type like an object, I think that's the difference
@solnic so we need a method to strip out meta, wdyt?
Piotr Solnica
@solnic
Type#pristine? O_o
but if AST transformations could be used to trim types for special purposes, then maybe we should focus on that
Nikita Shilnikov
@flash-gordon
whatever name you like :) Even with AST this would be useful. The only difference is that AST trimming will trim the whole tree, that is erase meta from underlying types as well
@solnic OK, you now can merge this one https://github.com/dry-rb/dry-types/pull/188/files and I will add Type#pristine tomorrow
Piotr Solnica
@solnic
right
we’ll see what makes sense
Nikita Shilnikov
@flash-gordon
and in the next version we'll add AST transformations, this will make Type#pristine better. That's the plan. I think
I also pushed a small fix for Any
Piotr Solnica
@solnic
I saw that, cool
can I release 0.10.1 later today?
Nikita Shilnikov
@flash-gordon
yes
Egor Lynko
@flexoid
Hi guys. I have an issue, this simple line of code leads to huge performance impact in my use case
https://github.com/dry-rb/dry-types/blob/master/lib/dry/types/definition.rb#L67
the thing is, I use dry-validation in pair with reform, and my input is a Reform::Form object, which has quite a lot fields by itself, and also parent form in :parent property (recursively to the root form)
so, input.inspectbecomes quite heavy call, and if the property is validated with maybe, it always firstly tried to convert to NilClass, which runs this routine many many times
Egor Lynko
@flexoid
How do you think, what can be done in this situation? Does this entire approach is efficient enough?
to be more specific, removing that inspect call reduces query execution time from 4s to 0.2s
Alexander Gräfe
@rickenharp
I just ran into the problem with dry-system, that stubbing doesn't work with a finalized container. I was able to rewrite everything so that I didn't need to finalize in the tests, but I'm wondering: How do you handle having tests that do need a finalized container? Do you have two seperate test runs so the finalization doesn't contaminate the unit tests?
Sergey Kukunin
@Kukunin
@flash-gordon is there a chance you could release new dry-struct with my changes?
I'd like to remove monkey patches from my project
Nikita Shilnikov
@flash-gordon
@Kukunin yeah man, thanks for the reminder. I need to test it with rom first. Will do this tonight. Then I'll release 0.2
Sergey Kukunin
@Kukunin
great. thanks!
Nikita Shilnikov
@flash-gordon
Also there is a PR from Gustavo, Need to check it out
Julien Blanchard
@julienXX
Hello is there a way to reject unknown keys with dry-validation?
Piotr Solnica
@solnic
@julienXX it ignores unspecced keys by default
Gustavo Caso
@GustavoCaso
@here I have a Rails app with the typical setup, but everything been auto loaded from the app folder.
Inside the app folder we have a services folder that contain service objects, I was thinking about moving to a container base implementation
Has anyone tried before ? Any advice ?
Nikita Shilnikov
@flash-gordon
@solnic I've released 0.10.2 with a tiny bugfix
Piotr Solnica
@solnic
oh boy :)
Hannes Nevalainen
@kwando
Damn, I wanna do stuff in Elixir but I'm missing dry-validation to much sigh
Piotr Solnica
@solnic
hah yeah, once you start using such a solution it becomes an integral part of your system and the way you think about handling input so…I’m not surprised :)
Nick Sutterer
@apotonick
Hahaha