Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 14:25

    dry-bot on master

    [devtools] update changelog.yml… [devtools] sync (compare)

  • 14:24

    solnic on master

    Centralize error definitions in… Merge pull request #137 from cg… (compare)

  • 14:24
    solnic closed #137
  • 13:47
    dry-bot commented #137
  • 13:45
    cgeorgii review_requested #137
  • 13:45
    cgeorgii opened #137
  • Jan 25 23:15
    tiagogodinho starred dry-rb/dry-monads
  • Jan 25 18:27
    laertispappas starred dry-rb/dry-auto_inject
  • Jan 24 17:58
    leandrocp starred dry-rb/dry-matcher
  • Jan 24 10:36
    i-karimov starred dry-rb/dry-monads
  • Jan 24 09:15
    Travis dry-rb/dry-view (master) errored (711)
  • Jan 24 09:11

    dry-bot on master

    [devtools] sync (compare)

  • Jan 24 09:11

    dry-bot on master

    [devtools] sync (compare)

  • Jan 24 09:11

    dry-bot on master

    [devtools] sync (compare)

  • Jan 24 09:11

    dry-bot on master

    [devtools] sync (compare)

  • Jan 24 09:11

    dry-bot on master

    [devtools] sync (compare)

  • Jan 24 09:11

    dry-bot on master

    [devtools] sync (compare)

  • Jan 24 09:10

    dry-bot on master

    [devtools] sync (compare)

  • Jan 24 09:10

    dry-bot on master

    [devtools] sync (compare)

  • Jan 24 09:10

    dry-bot on master

    [devtools] sync (compare)

Nikita Shilnikov
@flash-gordon
you can use Dry::Struct::Value I think
but keep in mind that deep-freeze is dead slow
Markus Unterwaditzer
@untitaker
I'm not even talking about deep-freeze. I have a model Model::Foo where one field is of type Types::Strict::Array.member(Model::Bar). My problem is that that field is still mutable, I can append more Bars.
both models are structs
Nikita Shilnikov
@flash-gordon
it’s no difference with other types of attributes, say, you have a string attr and you still can mutate it with gsub! and etc
you can workaround this with your own constructor types
Markus Unterwaditzer
@untitaker
sure, but I wonder if you would accept a PR which would call freeze in Types::Strict::Array or something like that. Or is dry-types not supposed to be always immutable?
Nikita Shilnikov
@flash-gordon
dry-types has nothing to do with this
though it can have types that dups and freezes values
list of types I mean
like strict but frozen of something
/cc @solnic
Gustavo Caso
@GustavoCaso
Something in the lines of Types::Freeze::Array
Markus Unterwaditzer
@untitaker
What do you think about having Types::Strict::Array.frozen as constructor?
I'm wishing for something that would automatically load that constructor for me in any dry-struct (since I want everything in my models to be immutable without me explicitly specifying it for each attribute)
Also not sure what to do with coercible types etc... you'd need Types::CoercibleFrozen, Types::StrictFrozen, ...
Nikita Shilnikov
@flash-gordon
you probably want to benchmark it. Anyway, we won’t add a new method to the API because it affects everything
you can just redefine Struct.attribute to make it work the way you want
Markus Unterwaditzer
@untitaker
This message was deleted
isn't the entire point of using dry-struct to have everything as immutable?
Gustavo Caso
@GustavoCaso
I think using dry-struct is to have something like a value object
Or application data if you will
Represent something from your system
But I’m sure @flash-gordon will be able to provide a better answer
Markus Unterwaditzer
@untitaker
well if that's all there is to it I might as well keep on using activemodel ;)
Nikita Shilnikov
@flash-gordon
you certainly can
dry-struct by itself doesn’t provide an interface for mutating attributes
as in, setters
but it doesn’t do anything with values
Markus Unterwaditzer
@untitaker
I was just being facetious. My point is that I am using dry-struct not because it doesn't support mutation, but because it prevents it
Nikita Shilnikov
@flash-gordon
it’s not the point
Markus Unterwaditzer
@untitaker
or at least I thought it did
Nikita Shilnikov
@flash-gordon
you don’t need a mutable interface, that’s why you don’t get it
Markus Unterwaditzer
@untitaker
right, I'm not asking for a mutable interface
Nikita Shilnikov
@flash-gordon
but if you're using other ruby primitives, such as arrays and strings, they're mutable
but since they're more efficient we stick to them
otherwise we would have to go with our own
or freezing everything which is, as I mentioned, is slow
so what we do instead is discouraging
from mutating values
Markus Unterwaditzer
@untitaker
I'll figure something out. But thanks.
Nikita Shilnikov
@flash-gordon
and if you want to enforce immutability it will cost you some performance but can do it
Markus Unterwaditzer
@untitaker
I might have underestimated runtime cost of freeze. I thought it could be O(1)
Nikita Shilnikov
@flash-gordon
I personally only watched a talk by @solnic where he measured this
tldr we just don't mutate anything thus don't have a problem with mutation :)
Piotr Solnica
@solnic
it is too slow, deep freezing kills perf. Do it only with memoized objects that are instantiates once per process
Gustavo Caso
@GustavoCaso
:clap: :clap:
Hamza Khan-Cheema
@hamzakc
Hi, Just a quick question. I am using dry-web-roda and making a API application. I am toying with a few ideas on how to test it. How do other people test API apps? I was playing with the idea of using bacon, but would like to use Rspec. Capybara is not really used to test API's so feature tests are out. The other option is just to use rack-test directly
Oskar Szrajer
@gotar
I use rack-test always