(and if it makes testing too hard, well, that’s a code problem)
@timriley, well, the test is perfectly easy. it’s just that rspec double’s aren’t designed with type checking in mind, which is fair enough given how atypcal it is in ruby. imo dry::struct types bring a certain sanity to ruby that should be there, but the fact remains it’s still an addon to the language, so to speak.
@timriley which is indeed the case here. i sort of added the class constraint just as a way of enforcing the interface, but now that you mention it i think that’s where my mistake was — the contract really is just an interface and not a particular class. and removing the type constraint which i’ve what i did to fix the issue was probably the correct move anyway and not just a hack as i’ve been viewing it
I could use
result.errors to filter result.output manually, but maybe there is another way?
Hello,
when defining an enum without 0 as a valid value:
subject(:enum) { Dry::Types['integer'].enum(4, 5, 6) }I expected that it would be invalid
expect(enum.try(0)).to be_failurebut it is actually valid because of inverted_mapping. I found this to be really confusing.
Should't this inverted behavior only happen when the mapping is defined explicitly?
subject(:enum) { Dry::Types['integer'].enum(4 => 0) }At least when the values are all integers?
well,
try didn't work in prev version actually but fixed this :)
[] worked
I would say it's better not to have mapping by default
but this is a breaking change
Any idea why I could be getting the error:
Attribute :authenticator_name has already been defined (Dry::Struct::RepeatedAttributeError)when that is not the case?
My class looks like this:
class Input < ::Dry::Struct
attribute :authenticator_name, Types::NonEmptyString
attribute :service_id, Types::Coercible::String
attribute :account, Types::NonEmptyString
attribute :username, Types::NonEmptyString
attribute :password, Types::NonEmptyString
end
How can I mix required and optional/default attributes? That is, the following works fine:
class Test < Dry::Struct
attribute :optional, Types::Any.default('default value')
end
p Test.new.optional #=> prints 'default value'However
class Test2 < Dry::Struct
attribute :required, Types::Any
attribute :optional, Types::Any.default('default value')
end
p Test2.new(required: 'my required val')
# Raises:
# [Test2.new] :optional is missing in Hash input (Dry::Struct::Error)
Yet in my actual code I’m doing the same thing with a Sequel class:
attribute :resource_class, ::Types::Any.default(Resource)resource_class it returns not the class, but it seems an instance of the class:#<Resource @values=#<#<Class:0x00000003e7bf00> primitive=Object options={} meta={}>>
Is there any magic the dry::struct does on class values for defaults that would explain this?
IntType = Types.Constructor(Types::Hash){|value| Types::Hash(:strict_with_defaults, int: Types::Form::Int)[int: value]}
class MyClass < Dry::Struct
constructor_type :strict_with_defaults
attribute int_attribute_one, Types::IntType.default(1)
attribute int_attribute_two, Types::IntType.default(2)
end
2.3.3 :181 > MyClass.new()
TypeError: class or module required
using the block notation:
attribute int_attribute_one, Types::IntType.default{1}
attribute int_attribute_two, Types::IntType.default{2}
2.3.3 :188 > MyClass.new()
=> #<MyClass int_attribute_one={:int=>1} int_attribute_two={:int=>2}>
2.3.3 :189 > MyClass.new(int_attribute_one: 1)
=> #<MyClass int_attribute_one={:int=>1} int_attribute_two=2>
Hi guys! I have a problem with dry-validations (0.11)
require 'dry-validation'
UserSchema = Dry::Validation.Schema do
rule(value_filled: [:value1, :value2, :value3]) do |value1, value2, value3|
value1.eql?('1') | value2.eql?('1') | value3.eql?('1')
end
end
UserSchema.(
value1: '0',
value2: '0',
value3: '0'
).inspect
# => "#<Dry::Validation::Result output={:value1=>\"0\", :value2=>\"0\", :value3=>\"0\"} errors={}>"Why there are no errors for the schema? y rule is one of the fields must be filled with '1'
Also if I define three optional properties, than I will get a strange error:
=> "#<Dry::Validation::Result output={:value1=>\"0\", :value2=>\"0\", :value3=>\"0\"} errors={:some_filled=>[\"must be equal to 1 or must be equal to 1\"]}>"
Turns out: I don't know Ruby.
I can't tell if I've hit a bug or I'm using some kind of behavior incorrectly, but it seems to me there are oddities when using schema inheritance with schemas that are create with
JSON or Form. Consider this:Schema = Dry::Validation.Schema do
configure { config.type_specs = true }
required(:first_name, :string).filled(:str?)
end
OtherSchema = Dry::Validation.Schema(Schema) do
required(:last_name, :string).filled(:str?)
end
input = { first_name: 'John', last_name: 'Smith' }
Schema.(input).success? => true
Schema.(input).output => {:first_name=>"John", :last_name=>"Smith"}
OtherSchema.(input).success? => true
OtherSchema.(input).output => {:first_name=>"John", :last_name=>"Smith"}
Schema = Dry::Validation.JSON do
configure { config.type_specs = true }
required(:first_name, :string).filled(:str?)
end
OtherSchema = Dry::Validation.Schema(Schema) do
required(:last_name, :string).filled(:str?)
end
input = { 'first_name' => 'Joe', 'last_name' => 'Smith' }
Schema.(input).success? => true
Schema.(input).output => {:first_name=>"Joe"}
OtherSchema.(input).success? => false
OtherSchema.(input).errors => {:first_name=>["is missing"]}
I cannot seem seem to get
OtherSchema to recognize first_name. Inheritance works as I would expect with the normal schema. It's not a problem with the JSON macro either, as this would yield the same issues:Schema = Dry::Validation.Schema do
configure do
config.type_specs = true
config.input_processor = :json
config.hash_type = :symbolized
end
required(:first_name, :string).filled(:str?)
end
OtherSchema = Dry::Validation.Schema(Schema) do
required(:last_name, :string).filled(:str?)
end
I thought perhaps explicitly setting configuration on both would do the trick, but no dice:
OtherSchema = Dry::Validation.Schema(Schema) do
configure do
config.type_specs = true
config.input_processor = :json
config.hash_type = :symbolized
end
required(:last_name, :string).filled(:str?)
end