hi @hellboy81, this is how I do it (read file from disk, pipe to db attachment ):
// add attachment
var dbWriteStream = db.attachment.insert(doc._id, filename, null, type, {rev: doc._rev}, uploaded);
var fileReadStream = fs.createReadStream(file.path);
fileReadStream.on('error', error);
dbWriteStream.on('error', error);
fileReadStream.pipe(dbWriteStream);
uploaded is the callback that gets called when piping is complete
then, uploaded():
function uploaded(err, body) {
if (err) {
console.log("[Attachment] Error in upload.");
if (err.status_code === 409) {
console.log('Attachment upload conflict, retry.');
addAttachment(req, res);
return;
}
else {
console.log("Unrecoverable error in upload", err);
clearTmp();
return error(err);
}
}
clearTmp();
....
}
so i would suggest you to use the variant above, where nano handles it the way it wants
It's celar
@hellboy81 i have no idea, i just remember that dealing with
on('end', ...) was not successful that time i wrote that code
?
But a good programmer handles it in one way or the other ;)
(my strategy here is to refetch the document to get the latest revision and try again to upload, as long until it works, may not be the best for all applications)
for "making it work", you don't need to handle 409. Handle it when the problem gets frequent
ok then just go for it and not handle 409 that's perfectly fine
you can read more about conflicts here: http://guide.couchdb.org/draft/conflicts.html or here: http://writing.jan.io/2013/12/19/understanding-couchdb-conflicts.html
Isn't it?
wir können auch Deutsch sprechen ;-)
No, let's go with english, as this is a public channel and other people may want to profit from our discussion
aber danke :)
Habe noch eine Frage: wenn db.insert ein nicht-leeres
err - Objekt zurückgibt, dies bedeutet automatisch, dass ok == false und umgekehrt kein Error - ok ist immer true
?
*them
OK, at the moment I have following problem:
I am trying to implement attachment upload in the right way.
As I mentioned I should do it in following steps
- db.get - Get document (existing or not existing)
- db.insert - If document not exists
- db.attachment.insert - Insert attachment
- If attachment upload success:
- db.get to get the updated versions (with `_attachments`) - Add additional custom attachment meta data to the document - db.insert - Save updated document
- If attachment upload success:
Can you verify it?
Is there
db.attachment.head implementation?
Since v6.x passing in a url requires it to be https? Therefor require('nano')('http://localhost:5984/foo'); fails. Is this the expected behavior and we should all use https now?
?
@dscape
As I mentioned in nano there is no db.head
And the best way to ensure that
- CouchDB is online
- Database is available (exists)
it to create it?
