Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Artemiy Stepanov
@0xk175un3
Is it in development for now?
David Mohl
@dvcrn
@0xk175un3 currently not
but feel free to take over if you want!
André Madeira Cortes
@BamBalaam
@dvcrn I wouldn't mind taking over or asking your permission for an official fork.
David Mohl
@dvcrn
@BamBalaam that would be cool! But I feel that at this point the project needs a bit of rewriting and redesigning to get it back up to speed
There are a lot of learnings from https://github.com/dvcrn/proton and spacemacs in how to do everything more reliable that I was hoping to use as a base for sublimious
For example we should clean up layer loading and split components like the space keyhelper from the rest more cleanly
David Mohl
@dvcrn
if you're interested, maybe we can make a little plan in what changes are needed and could try to bring it back up to speed
André Madeira Cortes
@BamBalaam
@dvcrn Rewriting (or at least refactoring) is a definite need yeah. Also some styling cleanup to make it more readable for future contributors.
I'd definitely be interested in hearing what you've learned from Proton and prepare a plan with you of the next steps :smile:
Email or private message here?
David Mohl
@dvcrn

@BamBalaam I think here is fine. Makes it also accessible easier :)

The first 2 things I want to do is break up the monolithic sublimious.py/helpers into more smaller and better written components. I already rewrote the package manager into more simple python code but didn't put it in yet.

Then the layer format. Currently its a bunch of variables that are getting pulled out but that's not so great. Proton is using a handful of functions (or phases) that are getting called step by step with state so the layer can do whatever it needs to based on the configuration (like this https://github.com/dvcrn/proton/blob/master/src/cljs/proton/layers/lang/elixir/core.cljs) (Proton goes a step further and has 'modes' and hooks for when packages are loaded. For example if the linter layer is actived, the clojure layer could hook into that and do some extra steps for setting up the linter. But that's likely not needed for the beginning)

It would be also really cool if we could make it work that layers can define actual sublimetext commands
André Madeira Cortes
@BamBalaam
@dvcrn Hey David
I'll explore Proton's code (even though it's been quite a while since I read Clojure code haha :smile: ), it seems to have a lot of interesting approaches from what you're telling me.
By "define actual sublimetext commands" you mean CTRL+SHIFT+P commands?
Yeah that would be quite cool
But what kind of commands do you envision? Because the Layers mainly bring forward the related packages
David Mohl
@dvcrn
yeah CTRL+SHIFT+P commands
for example so that layers could define custom commands, then bind them to either keybindings directly or through the space menu
Nothing particular in mind, but it'd be cool if layers have more power to customize things if needed
David Mohl
@dvcrn
but if you have other ideas, please :)
André Madeira Cortes
@BamBalaam
It's a good idea, but maybe not for right now immediately. I think first we should fix longstanding bugs and refactor the code, as you said.
I've been opening some PRs and Issues for that :)
If you feel like you will not have the time/want to review them, tell me and I'll just merge them when I feel I've tested them extensively.
David Mohl
@dvcrn
I'll try to commit a bit more time, but feel free to take over and do what you think is right.
Really appreciate that you want to pick it up! It definitely needs some love
André Madeira Cortes
@BamBalaam
It's a great project, of course it needs some love :D
It has its flaws, but I think it's mostly due to it being your first project of the kind. Proton visibly is a step up from this.
André Madeira Cortes
@BamBalaam
So now it needs some caring :D
David Mohl
@dvcrn
I think SublimeText definitely has a lot to offer over Atom and VSCode so if we could get it up to speed it would be pretty sweet
André Madeira Cortes
@BamBalaam
I'll try to make some time in the coming weeks, after work :)