Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 12:02
    codeclimate[bot] commented #4269
  • 12:02
    codeclimate[bot] commented #4269
  • 11:59
    Jimmi08 closed #4274
  • 11:59
    Jimmi08 commented #4274
  • 11:58
    Deltik synchronize #4269
  • 09:47
    Jimmi08 labeled #4274
  • 09:47
    Jimmi08 opened #4274
  • 06:38
    Serios commented #4263
  • Nov 29 22:11
    CaMer0n milestoned #4272
  • Nov 29 22:10
    CaMer0n commented #4272
  • Nov 29 22:05
    CaMer0n closed #4268
  • Nov 29 22:05

    CaMer0n on master

    Fixes #4268 - missing field in … (compare)

  • Nov 29 21:53
    CaMer0n milestoned #4268
  • Nov 29 20:48
    Jimmi08 edited #4273
  • Nov 29 20:48
    Jimmi08 opened #4273
  • Nov 29 20:48
    Jimmi08 labeled #4273
  • Nov 29 20:36
    Jimmi08 commented #4272
  • Nov 29 20:25
    Jimmi08 closed #4217
  • Nov 29 20:24
    Jimmi08 commented #4272
  • Nov 29 19:34
    CaMer0n commented #4272
Crytiqal.Aero
@Crytiqal
2020-11-23.png
the <a class=""> should have to contain nav-link according to bootstrap 4
$LOGIN_MENU_LOGGED = '
<ul class="login-menu-logged nav flex-column">
    {LM_MAINTENANCE}
    {LM_ADMINLINK}
    <li class="nav-item login-menu-usersettings {LM_ACTIVE: mode=usersettings}">{LM_USERSETTINGS}</li>
    <li class="nav-item login-menu-profile {LM_ACTIVE: mode=profile}">{LM_PROFILE}</li>
    {LM_ADMIN_CONFIGURE}
    {LM_EXTERNAL_LINKS}
    {LM_LOGOUT}
    {LM_STATS}
    {LM_LISTNEW_LINK}
</ul>
';
$sc_style['LM_ADMINLINK']['pre'] = '<li class="nav-item login-menu-admin">';
$sc_style['LM_ADMINLINK']['post'] = '</li>';
        function sc_lm_adminlink($parm='')
        {
            if(ADMIN == TRUE) {
                return $parm == 'href' ? e_ADMIN_ABS.'admin.php' : '<a class="login_menu_link admin" id="login_menu_link_admin" href="'.e_ADMIN_ABS.'admin.php">'.LAN_LOGINMENU_11.'</a>';
            }
            return '';
        }
e107git/e107_plugins/login_menu/login_menu_shortcodes.php
Jimako
@Jimmi08
And do you have problem with styling or what? Just from curiosity. I am very familiar with this problem.
Crytiqal.Aero
@Crytiqal
well, it is possible for me to overwrite the login_menu_template.php
by copying it to my themes folder
e107git/e107_themes/bootstrap4/templates/login_menu/login_menu_template.php
but the same can not be done with the login_menu_shortcodes.php
I would have to edit a core file ?
Jimako
@Jimmi08
look at login shortcodes and you will know why.
Crytiqal.Aero
@Crytiqal
i dont understand?
e107 checks e107_themes/templates/ first if a file exists, but not for the shortcodes.php ?
I must edit the core file then ? or is there a way to change the styling ?
sorry if this is a dumb question
Jimako
@Jimmi08
You can use parameters for styling some shortcodes, but not for these. I tried to do, then I gave up and there are at least 3 other, no 5 other solutions how to do this. You best choice is create issue and get this fixed. Actual solution is correct because you have there at least one class login_menu_link.
if missing class is needed for behaviour (not for look, for example dropdowns) than change it by javascript. if missing class is needed for look, then just use nav-link styling from bootstrap4 for login_menu-link. Or you can:
  • overrride core shortcodes with theme shortcodes
  • create your own menu and used there correct code... I forgot what was fifth.
Nevermind. it took me years to find workarounds for those limitations. First 2 options are the best. And don't forget glyphs icons don't work in bootstrap4 etc...
Crytiqal.Aero
@Crytiqal
being able to override core shortcodes with theme shortcodes would be the cleanest solution I think.
yes, glyphs also...
:<
it's a little dificult rewriting bootstrap3 to bootstrap4
Jimako
@Jimmi08
@Crytiqal help: e107inc/e107#1484
Crytiqal.Aero
@Crytiqal
awesome, thanks!
this should be in the official documentation ^^
Jimako
@Jimmi08
it is marked as documentation - see blue tag on right side.
Crytiqal.Aero
@Crytiqal
right, ok :)
Jimako
@Jimmi08
Good night
regarding this comment, I would use a require()
ok, good night :)
thanks for your help
Jimako
@Jimmi08
I remembered now. The easier one. 5. Copy the content of shortcode to template (replace the shortcode with actual code). They are just strings and it is PHP file.. so. You will do this sometimes with buttons or other stuff when you see that almost each (submit) button has different styling and class and there is no parameter for it.
Really good night, bye
Jimako
@Jimmi08
Hi, could you release rc2 version or something? You did a change in the admin UI that causes problems in my plugins. You renamed (fixed name) property without worrying about the old one is used. Thanks
Jimako
@Jimmi08
@Crytiqal I just bought this https://themewagon.com/themes/black-bundle/ Now just find more time. I can't believe they offer sass version for almost all of them. I was watching that drop down builder long time, but it was too expensive for an unlimited license.
WhiteGrizly
@WhiteGrizly
The site was on e107 1.0.4. updated to 2.3, in the settings admin/eurl. php? mode=main&action=config changed the path to "friendly" from the old type (/page.php?14 and /request.php?4) save the settings and then clicke "edit". It wrote that everything was updated, but in fact nothing has changed. Installed the gallery plugin. I can't log in to it, the link is not working.
WhiteGrizly
@WhiteGrizly
link to default Gallery 1 is - /gallery/index/list?media_cat_id=18&media_cat_owner=gallery&media_cat_category=gallery_image&media_cat_title=Gallery%201&media_cat_sef=gallery-1&media_cat_diz=&media_cat_class=0&media_cat_image=%7Be_PLUGIN%7Dgallery%2Fimages%2Fbutterfly.jpg&media_cat_order=0
Gallery placed in {e_PLUGIN}gallery/gallery.php but all links in gallery is without {e_PLUGIN} part
I made an update to the lgsl plugin :) it can now return json format
Jimako
@Jimmi08
@Crytiqal It is great, but you didn't post it, don't you?
Jimako
@Jimmi08
@LaocheXe did you notice this before?- with caching javascript ON holidays lights are not working. If I set it off, they are there.
leo
@tgtje
@Moc @CaMer0n pull request on Spanish language (for 2.3.0) (latest only, combines all others), was approved by Spanish users. Maintainer is presently not engaged.