Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 13:44
    codecov[bot] commented #1683
  • 13:44
    eriksven synchronize #1683
  • 13:40
    codecov[bot] commented #1683
  • 13:39
    eriksven synchronize #1683
  • 13:35
    jbtrystram synchronize #1769
  • Feb 15 16:18
    bobeal starred eclipse/hono
  • Feb 14 17:12
    boaks synchronize #1762
  • Feb 14 15:56
    boaks commented #1772
  • Feb 14 15:54
    calohmn commented #1772
  • Feb 14 15:12

    sophokles73 on master

    Create stable docs from 1.1.x b… (compare)

  • Feb 14 15:08

    sophokles73 on 1.1.x

    Fix env variable names for conf… Share common configuration opti… (compare)

  • Feb 14 15:01

    sophokles73 on master

    Fix env variable names for conf… Share common configuration opti… Fix Checkstyle violations Sign… (compare)

  • Feb 14 14:56
    boaks commented #1772
  • Feb 14 14:55
    boaks commented #1772
  • Feb 14 14:51
    calohmn commented #1772
  • Feb 14 14:46
    boaks commented #1772
  • Feb 14 14:40
    boaks opened #1772
  • Feb 14 13:58
    calohmn commented #1727
  • Feb 14 12:59
    jbtrystram commented #1769
  • Feb 14 12:58
    jbtrystram synchronize #1769
Kai Hudalla
@sophokles73
no worries, found it ...
Kai Hudalla
@sophokles73
@dejanb Hi Dejan, have you been able to take a look at #1647 ?
Dejan Bosanac
@dejanb
@sophokles73 just briefly ... I plan to work on it tomorrow
Kai Hudalla
@sophokles73
cool
Kai Hudalla
@sophokles73
@ctron @dejanb @calohmn It looks like there is only a single place where we still use code from Google Guava: some toString() methods in the Device Registry helper classes. I wonder if we can remove that dependency altogether from Hono ... WDYT?
Jens Reimann
@ctron
hm … while I like the "ToStringHelper" stuff, guava's dependencies are sometimes tricky, so getting rid of it might be a good idea :+1:
that would be a change for 1.1?
Kai Hudalla
@sophokles73
I guess so. Guava is not part of any of our public APIs AFAIK
Dejan Bosanac
@dejanb
+1
Carsten Lohmann
@calohmn
I'm also for removing it then.
Kai Hudalla
@sophokles73
I will create an issue for it then and assign it to @ctron !?
Dejan Bosanac
@dejanb
@sophokles73 how do you wanna proceed with #1647
I have some fixes, but I doubt I can push them to bsinno
Kai Hudalla
@sophokles73
I can push the branch to eclipse/hono as well. We can then work on it together an create a PR from it. Would that work for you?
Dejan Bosanac
@dejanb
yeah ... sounds perfect
Kai Hudalla
@sophokles73
ok, gimme a minute ...
Dejan Bosanac
@dejanb
so basically I have helm chart running (at least getting started looks ok) and systems tests run but I saw a couple of failures
would love to push this to see how it looks in CI and then continue tweaking it
Kai Hudalla
@sophokles73
ok, I have pushed the branch to eclipse/hono ...
Dejan Bosanac
@dejanb
cheers
Dejan Bosanac
@dejanb
new pr is #1651 as I don't think we can edit the old one
I also rebased the branch, so now is mergable
Kai Hudalla
@sophokles73
@ctron would you mind taking a look at #1654 ? It is supposed to be part of 1.0.2 which we want to release this week ...
Jens Reimann
@ctron
done
Kai Hudalla
@sophokles73
@ctron thanks, man :-)
Kai Hudalla
@sophokles73
@ctron @calohmn @dejanb Today is the day we have scheduled 1.1.0-M1 for :-) Anything you got cooking that should be in this milestone in addition to what we have in the "done" column of our 1.1.0 project board?
Carsten Lohmann
@calohmn
From my side that would be #1654. @ctron I've pushed a change to that PR yesterday. Could you have another look?
Jens Reimann
@ctron
@calohmn done … sorry, I assumed you would simply add a comment and merge :grinning:
Dejan Bosanac
@dejanb
@sophokles73 I would like to take a look at the artemis logs
when are you planning to cut it?
Kai Hudalla
@sophokles73
@dejanb No particular plan. What about 5PM?
Dejan Bosanac
@dejanb
@sophokles73 sure ... I'm looking into this now
Kai Hudalla
@sophokles73
I would like to change the way we handled the release notes for milestones in the past. We used to add a heading for the milestone in the release notes, basically treating it as a separate release. However, the Eclipse Foundation doesn't consider a milestone to be a release and neither should we. Base on that, I propose to simply keep on adding text to the release notes for 1.1.0 and include it in the announcement mail I send out for the milestone. This way people still can see what has changed in the milestone but we do not need to create a project board for the milestone(s) which we can reference by URL. WDYT?
Dejan Bosanac
@dejanb
+1
Karthees Kalidass
@kaniyan
+1
Abel Büchner-Mihaljević
@b-abel
+1
Jens Reimann
@ctron
+1
Carsten Lohmann
@calohmn
+1
Trystram Jean-Baptiste
@jbtrystram
+1
Kai Hudalla
@sophokles73
ok everybody, I am now preparing the milestone build and will then push the button ...
Carsten Lohmann
@calohmn
It looks like #1645 takes longer than expected. Therefore I would suggest postponing the 1.0.2 build to end of the week at least. WDYT?
Kai Hudalla
@sophokles73
It seems like a fix to have in 1.0.2 so I am in favor or trying to get it into it. If that means delaying the release a little, I am fine with that ...
Kai Hudalla
@sophokles73
@calohmn are you able to successfully compile and test master locally? I can, but Travis and Jenkins seem to have a problem with it ...
Dejan Bosanac
@dejanb
@sophokles73 I tried it now ... and see the failure
let me check it out
Abel Büchner-Mihaljević
@b-abel
@dejanb We found it. The merge introduced an error. @sophokles73 is on it
Kai Hudalla
@sophokles73
@dejanb we already found the problem: it was an automatic merge error for the latest commit. I am currently fixing it
Dejan Bosanac
@dejanb
@b-abel @sophokles73 cool!
Kai Hudalla
@sophokles73
pushed the fix ...
Dejan Bosanac
@dejanb
let me give it a test