Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 15:46
    sophokles73 commented #1780
  • 15:35
    soheilade commented #1780
  • 15:33
    calohmn milestoned #1794
  • 15:33
    calohmn labeled #1794
  • 15:33
    calohmn opened #1794
  • 15:24
    soheilade commented #1780
  • 15:13
    sophokles73 commented #1780
  • 14:56
    soheilade commented #1780
  • 14:39
    fkaltner commented #1780
  • 14:34
    fkaltner commented #1780
  • 13:57
    boaks synchronize #1762
  • 13:40
    soheilade commented #1780
  • 13:40
    soheilade commented #1780
  • 13:40
    soheilade commented #1780
  • 13:33
    soheilade commented #1780
  • 12:19
    sophokles73 milestoned #1792
  • 12:12
    sophokles73 labeled #1791
  • 12:12
    sophokles73 labeled #1791
  • 12:12
    sophokles73 milestoned #1791
  • 12:03
    ctron opened #1793
Carsten Lohmann
@calohmn
I'm also for removing it then.
Kai Hudalla
@sophokles73
I will create an issue for it then and assign it to @ctron !?
Dejan Bosanac
@dejanb
@sophokles73 how do you wanna proceed with #1647
I have some fixes, but I doubt I can push them to bsinno
Kai Hudalla
@sophokles73
I can push the branch to eclipse/hono as well. We can then work on it together an create a PR from it. Would that work for you?
Dejan Bosanac
@dejanb
yeah ... sounds perfect
Kai Hudalla
@sophokles73
ok, gimme a minute ...
Dejan Bosanac
@dejanb
so basically I have helm chart running (at least getting started looks ok) and systems tests run but I saw a couple of failures
would love to push this to see how it looks in CI and then continue tweaking it
Kai Hudalla
@sophokles73
ok, I have pushed the branch to eclipse/hono ...
Dejan Bosanac
@dejanb
cheers
Dejan Bosanac
@dejanb
new pr is #1651 as I don't think we can edit the old one
I also rebased the branch, so now is mergable
Kai Hudalla
@sophokles73
@ctron would you mind taking a look at #1654 ? It is supposed to be part of 1.0.2 which we want to release this week ...
Jens Reimann
@ctron
done
Kai Hudalla
@sophokles73
@ctron thanks, man :-)
Kai Hudalla
@sophokles73
@ctron @calohmn @dejanb Today is the day we have scheduled 1.1.0-M1 for :-) Anything you got cooking that should be in this milestone in addition to what we have in the "done" column of our 1.1.0 project board?
Carsten Lohmann
@calohmn
From my side that would be #1654. @ctron I've pushed a change to that PR yesterday. Could you have another look?
Jens Reimann
@ctron
@calohmn done … sorry, I assumed you would simply add a comment and merge :grinning:
Dejan Bosanac
@dejanb
@sophokles73 I would like to take a look at the artemis logs
when are you planning to cut it?
Kai Hudalla
@sophokles73
@dejanb No particular plan. What about 5PM?
Dejan Bosanac
@dejanb
@sophokles73 sure ... I'm looking into this now
Kai Hudalla
@sophokles73
I would like to change the way we handled the release notes for milestones in the past. We used to add a heading for the milestone in the release notes, basically treating it as a separate release. However, the Eclipse Foundation doesn't consider a milestone to be a release and neither should we. Base on that, I propose to simply keep on adding text to the release notes for 1.1.0 and include it in the announcement mail I send out for the milestone. This way people still can see what has changed in the milestone but we do not need to create a project board for the milestone(s) which we can reference by URL. WDYT?
Dejan Bosanac
@dejanb
+1
Karthees Kalidass
@kaniyan
+1
Abel Büchner-Mihaljević
@b-abel
+1
Jens Reimann
@ctron
+1
Carsten Lohmann
@calohmn
+1
Trystram Jean-Baptiste
@jbtrystram
+1
Kai Hudalla
@sophokles73
ok everybody, I am now preparing the milestone build and will then push the button ...
Carsten Lohmann
@calohmn
It looks like #1645 takes longer than expected. Therefore I would suggest postponing the 1.0.2 build to end of the week at least. WDYT?
Kai Hudalla
@sophokles73
It seems like a fix to have in 1.0.2 so I am in favor or trying to get it into it. If that means delaying the release a little, I am fine with that ...
Kai Hudalla
@sophokles73
@calohmn are you able to successfully compile and test master locally? I can, but Travis and Jenkins seem to have a problem with it ...
Dejan Bosanac
@dejanb
@sophokles73 I tried it now ... and see the failure
let me check it out
Abel Büchner-Mihaljević
@b-abel
@dejanb We found it. The merge introduced an error. @sophokles73 is on it
Kai Hudalla
@sophokles73
@dejanb we already found the problem: it was an automatic merge error for the latest commit. I am currently fixing it
Dejan Bosanac
@dejanb
@b-abel @sophokles73 cool!
Kai Hudalla
@sophokles73
pushed the fix ...
Dejan Bosanac
@dejanb
let me give it a test
alles gut :)
Abel Büchner-Mihaljević
@b-abel
:thumbsup:
Kai Hudalla
@sophokles73
@ctron @dejanb @calohmn I would like to do the 1.0.2 release today. The 1.0.2 project board (https://github.com/eclipse/hono/projects/24) on GitHub contains all issues/PRs that had been scheduled for 1.0.2. Can you take a look at the list and see if there is anything missing or if any of the items should not go into 1.0.2 from your point of view?
Dejan Bosanac
@dejanb
Looks good
Carsten Lohmann
@calohmn
List looks good. FMPOV, we could include PR #1668 there as well.
Kai Hudalla
@sophokles73
Ok, I will now start cherry-picking/backporting the commits from the 1.0.2 board to the 1.0.x branch ...
Abel Büchner-Mihaljević
@b-abel
Hi @sophokles73 @dejanb @ctron @calohmn, I just found the GitHub App WIP. It allows authors of pull requests to set the status to pending while still working on it. FMPOV it would be helpful to use this in Hono. WDYT?
Kai Hudalla
@sophokles73
Personally, I do not really have a problem with my PRs so far. However, I also have no problem with using this, if we can get webmasters to install/configure it for our repo ...
Jens Reimann
@ctron
What is the difference between this app and the existing GitHub WIP state?